New issue
Advanced search Search tips

Issue 733526 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: [Payments] Settings link should link to Autofill settings

Project Member Reported by ajha@chromium.org, Jun 15 2017

Issue description

Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
https://chromium.googlesource.com/chromium/src/+/c1f6df2403aa8ae7beb0df1fac923add396b41d1

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=728873


Thank you!
 

Comment 1 by ma...@chromium.org, Jun 20 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89af2de3b342b6de68b72560c03c446f99c92904

commit 89af2de3b342b6de68b72560c03c446f99c92904
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Jun 20 20:48:40 2017

[Payments] Add a browsertest for loading the settings from PaymentRequest

Bug:  733526 
Test: browser_tests
Change-Id: Ia098210f38039221c1b4fcc7ee25c83f93cfb55c
Reviewed-on: https://chromium-review.googlesource.com/541679
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480952}
[modify] https://crrev.com/89af2de3b342b6de68b72560c03c446f99c92904/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/89af2de3b342b6de68b72560c03c446f99c92904/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/89af2de3b342b6de68b72560c03c446f99c92904/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Comment 3 by ma...@chromium.org, Jun 20 2017

Status: Fixed (was: Started)
Components: -Test>Missing Tests>Missing

Sign in to add a comment