New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733520 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

CQ bot stop voting "on behalf of" and use delete vote API instead.

Project Member Reported by primiano@chromium.org, Jun 15 2017

Issue description

https://chromium-review.googlesource.com/c/535541/

- I reviewed somebody hjd's CL and did Review: +1, CQ: +2 .
- The CQ started testing the CL as expected.
- The link posted by the CQ (https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/535541/1) suggests that all trybots went green.
- However at some point a message showed up:
"""
Commit Bot on behalf of Primiano Tucci
Patch Set 1: -Commit-Queue
"""
I am pretty sure that I didn't touch the CL after my review.

1. What is that message trying to say, not fully clear to me? 
2. Why that bot writes things on other pepole CLs on my behalf?
3. Why the CL didn't land after passing all the trybots? the author had to click submit again to get it landed.

 

Comment 1 by rsesek@chromium.org, Jun 15 2017

Labels: -OS-Mac
Labels: Proj-Gerrit-Migration
1, 2: Removing CQ vote is the way to cancel CQ attempt. Since you voted CQ+2, so your vote had to be removed.
To be clear: we are aware this kind of interaction with CQ doesn't allow for awesome UX. Sorry for this :(


3. The CQ status link you've shared also says:
"(Committing failed: Error submitting change .)" which means Gerrit flaked. CQ does retry submits, but apparently gerrit flake was persistent. Since Gerrit error reason wasn't clear to CQ, CQ aborted attempt.
btw, wrt to 1,2: I am not sure but it could be possible to add text message XXX in 
"""
Commit Bot on behalf of Primiano Tucci
Patch Set 1: -Commit-Queue

XXX
"""

what XXX would make it better?

Comment 4 by aga...@chromium.org, Jun 16 2017

Owner: tandrii@chromium.org
Status: Assigned (was: Unconfirmed)
tandrii@: The CQ should simply both set the label and post the message in the same API call. Right now, _cancel_attempt makes two separate API calls: one via _reset_cq_votes, and the other via _add_comment. If those are combined, the UX might be a lot better.

Comment 5 by aga...@chromium.org, Jun 16 2017

Labels: Milestone-Afterglow
What you suggest is clearly feasible, but there are more special cases then:
1) There could be more than one user voting on CQ label. Perhaps then msg can be sent for both calls.
2) If removing vote fails, CQ still needs pots a message in order to stop processing a CL.
Owner: ----
Status: Available (was: Assigned)
Components: -Infra>CQ Infra>Platform>CQdaemon

Comment 9 by efoo@chromium.org, Aug 31 2017

Components: Infra>Platform>CQ

Comment 10 by efoo@chromium.org, Aug 31 2017

Components: -Infra>Platform>CQdaemon
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug -Hotlist-Recharge-Cold -Milestone-Afterglow -Proj-Gerrit-Migration Type-Feature
Status: Available (was: Untriaged)
Summary: CQ bot stop voting "on behalf of" and use delete vote API instead. (was: CQ bot stop other people CLs on my behalf)

Sign in to add a comment