New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733511 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Blank page gets opened after navigating to chrome://settings/content into 'Guest' mode.

Reported by db...@etouch.net, Jun 15 2017 
Chrome Version:61.0.3131.0 (Official Build) (cohort: 59_86_Win)fd6a40f8117b184c5fa64ac66f95a050842c0759-refs/heads/master@{#479564}(32/64 Bit).
OS:  Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
(1) Launch chrome, Switch to Guest mode and navigate to chrome://settings/content
(2) Observe.

Actual: Blank page gets opened after navigating to chrome://settings/content

Expected: Blank page should get opened.

This is a regression issue, broken in 'M-61', will soon update the other info:

Good Build: 61.0.3116.0
Bad Build: 61.0.3117.0
Actual_Guest.mp4
291 KB View Download

Comment 1 by brajkumar@chromium.org, Jun 15 2017

Labels: hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using per revision bisect providing information below.

Bisect Information:
--------------------
You are probably looking for a change made after 476059 (known good), but no later than 476060 (first known bad).

Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/4c605f53266369c61044568d8e2dcbd77bc3a800..d84ddac6a6b61604f0057ccb8046144287f795ec
 
From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2825203003

scottchen@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. 

Thanks!

Comment 2 by dpa...@chromium.org, Jun 15 2017

Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2

Comment 3 by scottchen@chromium.org, Jun 16 2017

Labels: Needs-Feedback
dbote@, can you explain what the "expected behavior" should be? current bug description for "expected" is the same as "actual".

Comment 4 by scottchen@chromium.org, Jun 20 2017

Owner: db...@etouch.net

Comment 5 by db...@etouch.net, Jun 21 2017

Cc: scottchen@chromium.org
Owner: dpa...@chromium.org
With respect to comment 3:

In Expected behavior page doesnot opened blank after navigating to chrome://settings/content 

Please find the below screen cast for the same
Expected_Issue.mov
611 KB Download

Comment 6 by dpa...@chromium.org, Jun 21 2017

Cc: -scottchen@chromium.org
Owner: scottchen@chromium.org
The expected behavior in comment#5 is not 100% correct either. The user should be forwarded chrome://settings and the URL should reflect that (which is tracked by issue 729492).

@scottchen: Did we figure out why a blank page is shown? Is the bisect CL indeed responsible for the difference in behavior?

Comment 7 by scottchen@chromium.org, Jun 27 2017

Status: Started (was: Assigned)
The bisect CL is most likely responsible for difference in behavior, but instead of making it work the same way as before, I think it's better to work on a new CL that will just make it forward to chrome://settings.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03a2ed59818d98677f9f6f6992da70a328edcf6c

commit 03a2ed59818d98677f9f6f6992da70a328edcf6c
Author: scottchen <scottchen@chromium.org>
Date: Thu Jun 29 20:30:05 2017

MD Settings: decouple page visibility from settings_ui.html.

Move PageVisibility out of settings_ui and into the global 'settings' namespace, so
that it's easier to manage and can be accessed by other parts of the program. This is
the beginning of reworking guest-mode routing in order to fix 733511, and there will
be a follow-up CL to further utilize the new page_visibility files.

BUG= 733511 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2962823002
Cr-Commit-Position: refs/heads/master@{#483471}

[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/appearance_page/compiled_resources2.gyp
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/compiled_resources2.gyp
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/downloads_page/compiled_resources2.gyp
[add] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/page_visibility.html
[add] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/page_visibility.js
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/settings_menu/compiled_resources2.gyp
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/03a2ed59818d98677f9f6f6992da70a328edcf6c/chrome/browser/resources/settings/settings_ui/settings_ui.js
[delete] https://crrev.com/81e96954be78ebe12476c548b678986db0fc04b4/chrome/browser/resources/settings/settings_ui/settings_ui_types.js
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c31781b0a4f7137b4b51919086092404594bce24

commit c31781b0a4f7137b4b51919086092404594bce24
Author: scottchen <scottchen@chromium.org>
Date: Mon Jul 10 19:52:42 2017

MD Settings: remove unsupported routes from guest-mode.

Currently in guest mode, there are valid routes that are not visible, which leads to odd behavior when directly visiting those routes. This CL aims to prevent those kinds of routes from being added into settings.Route during initialization.

BUG= 733511 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2957153003
Cr-Commit-Position: refs/heads/master@{#485353}

[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/chromeos/compiled_resources2.gyp
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/help/compiled_resources2.gyp
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/options/compiled_resources2.gyp
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/a11y_page/a11y_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/a11y_page/manage_a11y_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/appearance_page/appearance_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/compiled_resources2.gyp
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/device_page/keyboard.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/device_page/storage.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/internet_page/network_proxy.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/languages_page/edit_dictionary_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/page_visibility.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/people_page/change_picture.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/people_page/fingerprint_list.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/people_page/lock_screen.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/people_page/manage_profile.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/people_page/sync_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/people_page/user_list.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/reset_page/reset_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/reset_page/reset_profile_banner.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/route.html
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/search_page/search_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/settings_page/main_page_behavior.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/site_settings/all_sites.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/about_page_tests.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/android_apps_page_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/basic_page_browsertest.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/people_page_change_picture_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/people_page_manage_profile_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/people_page_sync_page_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/reset_page_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/reset_profile_banner_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/settings_animated_pages_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/settings_main_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/settings_menu_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/settings_subpage_test.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/settings_ui_browsertest.js
[modify] https://crrev.com/c31781b0a4f7137b4b51919086092404594bce24/chrome/test/data/webui/settings/site_data_details_subpage_tests.js

Comment 10 by scottchen@chromium.org, Jul 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment