Issue metadata
Sign in to add a comment
|
Optimize grouping on ComputedStyle |
||||||||||||||||||||||||
Issue descriptionWIP Design doc here: https://docs.google.com/document/d/18iFIyJCsHoDU8joDjXc8EPp9ZEPZZiausccxf6h5fhM/edit# This bug aims to track progress in experimenting with the current grouping on ComputedStyle.
,
Jun 16 2017
,
Jun 19 2017
Assigning to shend@. We will be working on this together.
,
Jun 30 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed4698554ab3fdfdc4da6f4e60d9994c2e57616c commit ed4698554ab3fdfdc4da6f4e60d9994c2e57616c Author: Minh-Duc Nguyen <nmduc@google.com> Date: Thu Aug 10 07:38:46 2017 Group optimization on Computed Style Perform group optimization on Computed Style's RareNonInherited and RareInherited groups. This patch will be reverted before the next release. The detail design is discuss in https://docs.google.com/a/google.com/document/d/1VqyZfjWf4b3dlVYmOuNHYQpnlenGjojMAfyRgjCUORA/edit?usp=sharing Gist diff: https://gist.github.com/nguyen-minh-duc/ded64446593f2f19e38c1d96aa84f97d/revisions Bug: 733502 Change-Id: Ie18b6cfdfc896ca1353da6eb269b7355fc207023 Reviewed-on: https://chromium-review.googlesource.com/602099 Reviewed-by: nainar <nainar@chromium.org> Reviewed-by: meade_UTC10 <meade@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Cr-Commit-Position: refs/heads/master@{#493319} [modify] https://crrev.com/ed4698554ab3fdfdc4da6f4e60d9994c2e57616c/third_party/WebKit/Source/build/scripts/make_computed_style_base.py [modify] https://crrev.com/ed4698554ab3fdfdc4da6f4e60d9994c2e57616c/third_party/WebKit/Source/core/BUILD.gn [add] https://crrev.com/ed4698554ab3fdfdc4da6f4e60d9994c2e57616c/third_party/WebKit/Source/core/css/CSSPropertiesRanking.json5
,
Aug 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8971145053593782032
,
Aug 16 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Eric Karl Commit : dd8208f70e44b269eb09d26e506f79f9c1d2eefb Date : Thu Aug 10 20:34:31 2017 Subject: Reduce GPU image cache to 512KB Bisect Details Configuration: android_one_perf_bisect Benchmark : thread_times.simple_mobile_sites Metric : thread_other_cpu_time_per_frame/http___www.ebay.co.uk_ Change : 95.31% | 3.65064490295 -> 0.171309672716 Revision Result N chromium@493218 3.65064 +- 0.489432 6 good chromium@493387 3.70818 +- 0.345669 6 good chromium@493471 3.6051 +- 0.487721 6 good chromium@493513 3.55024 +- 0.276605 6 good chromium@493524 3.5607 +- 0.541487 6 good chromium@493525 3.57206 +- 0.42516 6 good chromium@493526 0.278407 +- 0.242001 6 bad <-- chromium@493527 0.206049 +- 0.31992 6 bad chromium@493529 0.256091 +- 0.313432 6 bad chromium@493534 0.19414 +- 0.380678 6 bad chromium@493555 0.17131 +- 0.233188 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.ebay.co.uk. thread_times.simple_mobile_sites More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8971145053593782032 For feedback, file a bug with component Speed>Bisection
,
Aug 16 2017
Was just testing the bisect to see if it's related to our changes.
,
Aug 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8971136603744983600
,
Aug 16 2017
,
Aug 16 2017
=== Auto-CCing suspected CL author nmduc@google.com === Hi nmduc@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Minh-Duc Nguyen Commit : ed4698554ab3fdfdc4da6f4e60d9994c2e57616c Date : Thu Aug 10 07:38:46 2017 Subject: Group optimization on Computed Style Bisect Details Configuration: android_one_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:chrome:all_processes:reported_by_chrome:partition_alloc:allocated_objects_size_avg/foreground/http_www_amazon_com_gp_aw_s_k_nexus Change : 0.44% | 2924897.33333 -> 2911934.66667 Revision Result N chromium@493218 2924897 +- 1172.85 6 good chromium@493303 2924241 +- 1176.77 6 good chromium@493314 2923748 +- 958.065 6 good chromium@493317 2924140 +- 794.864 6 good chromium@493318 2923941 +- 2061.34 6 good chromium@493319 2912020 +- 1030.98 6 bad <-- chromium@493324 2912404 +- 1009.65 6 bad chromium@493345 2912220 +- 1490.45 6 bad chromium@493387 2911871 +- 555.487 6 bad chromium@493555 2911935 +- 1355.51 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8971136603744983600 For feedback, file a bug with component Speed>Bisection
,
Aug 18 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970963924858635728
,
Aug 18 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970963661041204160
,
Aug 18 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970954385647745792
,
Aug 18 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8970954000275484704
,
Aug 18 2017
,
Aug 18 2017
=== Auto-CCing suspected CL author nmduc@google.com === Hi nmduc@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Minh-Duc Nguyen Commit : ed4698554ab3fdfdc4da6f4e60d9994c2e57616c Date : Thu Aug 10 07:38:46 2017 Subject: Group optimization on Computed Style Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:chrome:all_processes:reported_by_chrome:partition_alloc:effective_size_avg/foreground Change : 1.08% | 2727468.13333 -> 2698142.26667 Revision Result N chromium@492940 2727468 +- 4376.97 6 good chromium@493130 2731823 +- 3852.76 6 good chromium@493225 2724138 +- 6125.71 6 good chromium@493272 2720726 +- 6836.84 6 good chromium@493296 2723593 +- 8938.73 6 good chromium@493308 2724552 +- 3523.24 6 good chromium@493314 2725215 +- 8026.33 6 good chromium@493317 2723349 +- 7559.09 6 good chromium@493318 2723661 +- 8790.48 6 good chromium@493319 2698142 +- 3440.86 6 bad <-- Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970954000275484704 For feedback, file a bug with component Speed>Bisection
,
Aug 18 2017
=== Auto-CCing suspected CL author rockot@chromium.org === Hi rockot@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Ken Rockot Commit : fda282af5fded17df0f15b61c0907aba81609ea4 Date : Thu Aug 10 16:29:12 2017 Subject: Mojo Bindings: Single-phase serialization Bisect Details Configuration: android_one_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:chrome:all_processes:reported_by_chrome:allocated_objects_size_avg/foreground Change : 0.05% | 100567108.878 -> 100514207.411 Revision Result N chromium@493218 100567109 +- 117303 9 good chromium@493387 100574712 +- 54580.1 6 good chromium@493408 100567419 +- 75644.2 14 good chromium@493419 100542801 +- 168806 21 good chromium@493420 100459518 +- 61806.9 6 bad <-- chromium@493421 100497012 +- 167149 14 bad chromium@493422 100512330 +- 96027.5 9 bad chromium@493424 100486765 +- 101153 9 bad chromium@493429 100508937 +- 131129 14 bad chromium@493471 100506097 +- 66356.7 6 bad chromium@493555 100514207 +- 69340.6 9 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970963924858635728 For feedback, file a bug with component Speed>Bisection
,
Aug 18 2017
=== Auto-CCing suspected CL author dcheng@chromium.org === Hi dcheng@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Daniel Cheng Commit : 6ca7f1c95ea0346e53d00c24c940f6d2a52b3d28 Date : Wed Aug 09 21:45:41 2017 Subject: Limit the maximum length of frame unique names. Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/foreground/http_www_amazon_com_gp_aw_s_k_nexus Change : 0.75% | 21691753.3333 -> 21527112.1111 Revision Result N chromium@492940 21691753 +- 264664 9 good chromium@493130 21649295 +- 284171 14 good chromium@493142 21755111 +- 239981 6 good chromium@493148 21680178 +- 187098 6 good chromium@493151 21663253 +- 267300 9 good chromium@493152 21655294 +- 236248 9 good chromium@493153 21517747 +- 471366 14 bad <-- chromium@493154 21517489 +- 224209 9 bad chromium@493178 21507881 +- 378381 14 bad chromium@493225 21502781 +- 217619 9 bad chromium@493319 21527112 +- 207640 9 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8970954385647745792 For feedback, file a bug with component Speed>Bisection
,
Aug 18 2017
Removing erroneous owners caused by the bisect. Sorry folks!
,
Aug 21 2017
Does anyone know why comment #17 merged this issue to seemingly unrelated 755089?
,
Aug 22 2017
No idea, I was bisecting with my own test, why did it merge with another test?
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/550d7e428477d679b8365fcc3454871cd54137c4 commit 550d7e428477d679b8365fcc3454871cd54137c4 Author: Minh-Duc Nguyen <nmduc@google.com> Date: Mon Aug 28 03:53:54 2017 Group optimization with auto parameter update Perform group optimization on Computed Style's RareNonInherited and RareInherited groups. The grouping parameters will update whenever update_css_ranking.py is called. The detail design is discuss in https://docs.google.com/a/google.com/document/d/1VqyZfjWf4b3dlVYmOuNHYQpnlenGjojMAfyRgjCUORA/edit?usp=sharing Gen Diff: https://gist.github.com/nguyen-minh-duc/49faa7c2878e2eafd7d061bb30ea7a35/revisions Bug: 733502 Change-Id: I5ea518a2b9c2b8664b74f9ea21585e8fdcc511c6 Reviewed-on: https://chromium-review.googlesource.com/623008 Reviewed-by: dstockwell <dstockwell@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Cr-Commit-Position: refs/heads/master@{#497693} [add] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/build/scripts/cluster.py [modify] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/build/scripts/make_computed_style_base.py [add] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/build/scripts/update_css_ranking.py [modify] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/core/BUILD.gn [add] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/core/css/CSSGroupConfig.json5 [modify] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/core/css/CSSPropertiesRanking.json5 [modify] https://crrev.com/550d7e428477d679b8365fcc3454871cd54137c4/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8679c3fa444570915be08549ceca108865849b27 commit 8679c3fa444570915be08549ceca108865849b27 Author: Minh-Duc Nguyen <nmduc@google.com> Date: Tue Aug 29 06:17:30 2017 Change group name of auto generated group Currently, group name for auto generated group are ambiguous for reader so we change the group name to include the cumulative probability of the rule it is associated with. Gist diff: https://gist.github.com/nguyen-minh-duc/09f09271c6daeed76151b0c8719391b8/revisions Bug: 733502 Change-Id: I4d0a7feaea084833295ddb489b78b2a8e4212675 Reviewed-on: https://chromium-review.googlesource.com/637062 Reviewed-by: nainar <nainar@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Cr-Commit-Position: refs/heads/master@{#498031} [modify] https://crrev.com/8679c3fa444570915be08549ceca108865849b27/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
,
Aug 29 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8969948514219033120
,
Aug 29 2017
=== Auto-CCing suspected CL author nmduc@google.com === Hi nmduc@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Minh-Duc Nguyen Commit : 550d7e428477d679b8365fcc3454871cd54137c4 Date : Mon Aug 28 03:53:54 2017 Subject: Group optimization with auto parameter update Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:chrome:all_processes:reported_by_chrome:partition_alloc:effective_size_avg/foreground Change : 0.26% | 2696588.05714 -> 2703088.28571 Revision Result N chromium@497676 2696588 +- 13573.9 14 good chromium@497691 2698722 +- 11463.1 14 good chromium@497692 2698793 +- 11592.9 14 good chromium@497693 2702077 +- 16226.1 21 bad <-- chromium@497695 2704321 +- 6521.34 14 bad chromium@497698 2704767 +- 4736.69 6 bad chromium@497705 2703088 +- 13446.6 14 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8969948514219033120 For feedback, file a bug with component Speed>Bisection
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7725f2e0f1d9ecca1b72eee3ea5c00bf905cc53 commit d7725f2e0f1d9ecca1b72eee3ea5c00bf905cc53 Author: Minh-Duc Nguyen <nmduc@google.com> Date: Thu Aug 31 05:45:55 2017 Fix CSS properties Revert "Group optimization with auto parameter update" This reverts commit 550d7e428477d679b8365fcc3454871cd54137c4. Reason for revert: Cause regression because parameter is not up to date Original change's description: > Group optimization with auto parameter update > > Perform group optimization on Computed Style's RareNonInherited and > RareInherited groups. The grouping parameters will update whenever > update_css_ranking.py is called. > The detail design is discuss in https://docs.google.com/a/google.com/document/d/1VqyZfjWf4b3dlVYmOuNHYQpnlenGjojMAfyRgjCUORA/edit?usp=sharing > Gen Diff: https://gist.github.com/nguyen-minh-duc/49faa7c2878e2eafd7d061bb30ea7a35/revisions > > Bug: 733502 > Change-Id: I5ea518a2b9c2b8664b74f9ea21585e8fdcc511c6 > Reviewed-on: https://chromium-review.googlesource.com/623008 > Reviewed-by: dstockwell <dstockwell@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: nainar <nainar@chromium.org> > Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> > Cr-Commit-Position: refs/heads/master@{#497693} TBR=dstockwell@chromium.org,nainar@chromium.org,shend@chromium.org,nmduc@google.com Bug: 733502 Change-Id: Ie47eac5131da7be6861fc8171257b140936a8fca Reviewed-on: https://chromium-review.googlesource.com/641692 Reviewed-by: nainar <nainar@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Cr-Commit-Position: refs/heads/master@{#498765} [delete] https://crrev.com/e8dfd2da399e98b0aacba0057a85d546ac095233/third_party/WebKit/Source/build/scripts/cluster.py [modify] https://crrev.com/d7725f2e0f1d9ecca1b72eee3ea5c00bf905cc53/third_party/WebKit/Source/build/scripts/make_computed_style_base.py [delete] https://crrev.com/e8dfd2da399e98b0aacba0057a85d546ac095233/third_party/WebKit/Source/build/scripts/update_css_ranking.py [modify] https://crrev.com/d7725f2e0f1d9ecca1b72eee3ea5c00bf905cc53/third_party/WebKit/Source/core/BUILD.gn [delete] https://crrev.com/e8dfd2da399e98b0aacba0057a85d546ac095233/third_party/WebKit/Source/core/css/CSSGroupConfig.json5 [modify] https://crrev.com/d7725f2e0f1d9ecca1b72eee3ea5c00bf905cc53/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/d7725f2e0f1d9ecca1b72eee3ea5c00bf905cc53/third_party/WebKit/Source/core/css/CSSPropertiesRanking.json5 [modify] https://crrev.com/d7725f2e0f1d9ecca1b72eee3ea5c00bf905cc53/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8df398233040b8ec1cf464a48428b2448967214 commit e8df398233040b8ec1cf464a48428b2448967214 Author: Minh-Duc Nguyen <nmduc@google.com> Date: Wed Sep 06 00:09:37 2017 Group optimization with auto parameter update Perform group optimization on Computed Style's RareNonInherited and RareInherited groups. The grouping parameters will update whenever update_css_ranking.py is called. The detail design is discuss in https://docs.google.com/a/google.com/document/d/1VqyZfjWf4b3dlVYmOuNHYQpnlenGjojMAfyRgjCUORA/edit?usp=sharing Gen Diff: https://gist.github.com/nguyen-minh-duc/49faa7c2878e2eafd7d061bb30ea7a35/revisions The previous CL was reverted because it caused a regression on the perfbot. We have changed the parameters to the best parameter tested locally. Bug: 733502 Change-Id: I2aca34caa185b5ffd1defcdb6599bc8788d2819c Reviewed-on: https://chromium-review.googlesource.com/644591 Reviewed-by: dstockwell <dstockwell@chromium.org> Commit-Queue: Minh-Duc Nguyen <nmduc@google.com> Cr-Commit-Position: refs/heads/master@{#499810} [add] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/build/scripts/cluster.py [modify] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/build/scripts/make_computed_style_base.py [add] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/build/scripts/update_css_ranking.py [modify] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/core/BUILD.gn [add] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/core/css/CSSGroupConfig.json5 [modify] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/core/css/CSSPropertiesRanking.json5 [modify] https://crrev.com/e8df398233040b8ec1cf464a48428b2448967214/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
,
Sep 12 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by alancutter@chromium.org
, Jun 16 2017