New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733499 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Crash is observed on refreshing the page.

Reported by aiman.an...@etouch.net, Jun 15 2017

Issue description

Chrome Version: 61.0.3131.0 (Official Build) (cohort: 59_86_Win)fd6a40f8117b184c5fa64ac66f95a050842c0759-refs/heads/master@{#479564}(32/64 Bit).

OS:  Windows(7,8,8.1,10).

Steps to reproduce:
1.Launch Chrome, chrome://settings refresh the page multiple times and observe

Actual Result: Page crash is observed
Expected Result: Page should not crash

This is regression issue broken in 'M 61' and will soon update the bisect info:

Crash Report ID 68cb6b6e40000000 (Local Crash ID: 7b9470ba-bd0a-455d-b6b2-fc64a77fe3ca)

Manual Bisect Info: 
Good Build 61.0.3130.0
Bad Build 61.0.3131.0

Note: Will soon update MAC and LINUX OS status once build is available.

 
Cc: ranjitkan@chromium.org msrchandra@chromium.org
Components: UI>Settings
Labels: OS-Linux
Issue is also observed on Linux(14.04 LTS) OS and not seen on MAC OS
Actual Result.mp4
939 KB View Download
Expected Result.mp4
515 KB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Dev
Owner: toyoshim@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3130.0 (Revision:479232).
Bad build:61.0.3131.0 (Revision:479564).

You are probably looking for a change made after 479336 (known good), but no later than 479337 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/17645964f33b591deea14589845132be05e8ad9f..45ec95118f8fed84dde10e7044f17580fa3ddc06

From the CL above, assigning the issue to the concern owner

@Takashi Toyoshima: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Stack Trace: (Report ID: 65c59b47f0000000)
-----------
Thread 0 (id: 29002) CRASHED [SIGSEGV @ 0x00000030 ] MAGIC SIGNATURE THREAD
Stack Quality72%Show frame trust levels
0x0000564e4c3dec76	(chrome -HTMLImportState.h:49 )	blink::HTMLImportsController::ShouldBlockScriptExecution(blink::Document const&) const
0x0000564e4bd61a17	(chrome -Document.cpp:1042 )	blink::Document::ExecuteScriptsWaitingForResources()
0x0000564e4bc3cdf5	(chrome -callback.h:80 )	blink::TaskHandle::Runner::Run(blink::TaskHandle const&)
0x0000564e497e004f	(chrome -callback.h:91 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x0000564e4bcf3abe	(chrome -task_queue_manager.cc:531 )	blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*)
0x0000564e4bcf2e9e	(chrome -task_queue_manager.cc:329 )	blink::scheduler::TaskQueueManager::DoWork(bool)
0x0000564e497e004f	(chrome -callback.h:91 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x0000564e497de6e1	(chrome -message_loop.cc:422 )	base::MessageLoop::RunTask(base::PendingTask*)
0x0000564e497deb27	(chrome -message_loop.cc:433 )	base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
0x0000564e497de07b	(chrome -message_loop.cc:540 )	base::MessageLoop::DoWork()
0x0000564e497e0484	(chrome -message_pump_default.cc:33 )	base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
0x0000564e497ff95d	(chrome -run_loop.cc:111 )	base::RunLoop::Run()
0x0000564e4cfe8f8b	(chrome -renderer_main.cc:219 )	content::RendererMain(content::MainFunctionParams const&)
0x0000564e4946aece	(chrome -content_main_runner.cc:340 )	content::RunZygote(content::MainFunctionParams const&, content::ContentMainDelegate*)
0x0000564e4946bed4	(chrome -content_main_runner.cc:704 )	content::ContentMainRunnerImpl::Run()
0x0000564e49472a37	(chrome -main.cc:469 )	service_manager::Main(service_manager::MainParams const&)
0x0000564e4946ac71	(chrome -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const&)
0x0000564e4803d22b	(chrome -chrome_main.cc:109 )	ChromeMain
0x00007fe219dc7f44	(libc-2.19.so + 0x00021f44 )	
0x0000564e4803d18f	(chrome + 0x0160d18f )	SyscallAsm
0x0000564e47f56fff	(chrome + 0x01526fff )	
0x00007fe2203b61f2	(ld-2.19.so + 0x000101f2 )	
0x0000564e47f56fff	(chrome + 0x01526fff )	
0x0000564e47f57028	(chrome + 0x01527028 )	_start
0x00007ffcfec14997		

Note:
1.Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Not in Mac 10.12.5 and Able to reproduce in latest Canary #61.0.3131.0
2.While reproducing this crash different stack trace are getting in crash server.
3.Adding Release Block-Dev for this issue.Please remove if not the case.
Cc: manoranj...@chromium.org gov...@chromium.org ajha@chromium.org
Please find the different crash id's : 68cb6b6e40000000,c923bb6e40000000 & 7769af47f0000000.



Comment 5 by dpa...@chromium.org, Jun 15 2017

Labels: Proj-MaterialDesign-WebUI
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/362845cf3a6b3b455bd2457090747b361a51cd12

commit 362845cf3a6b3b455bd2457090747b361a51cd12
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Jun 16 11:51:47 2017

Revert "HTMLImportLoader do not need to call ClearImportsController in Dispose"

This reverts commit 45ec95118f8fed84dde10e7044f17580fa3ddc06.

Reason for revert: this change makes reload flaky

Original change's description:
> HTMLImportLoader do not need to call ClearImportsController in Dispose
> 
> HTMLImportLoader::Dispose() is called only in HTMLImportsController::Dispose()
> and it is called in Document::Shutdown() as a following step.
> 
>  1. HTMLImportsController::Dispose()
>  2. Document::ClearImportsController()
> 
> So, HTMLImportLoader::Dispose() do not need to call
> Document::ClearImportsController() for each HTMLImportLoader instance.
> 
> BUG=none
> 
> Change-Id: I0b1df123deedfa773c893df2f51b5cbe98cfbb20
> Reviewed-on: https://chromium-review.googlesource.com/535434
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#479337}

TBR=toyoshim@chromium.org,hayato@chromium.org
BUG= 733499 
# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ice94f8ed9f1ac6ecfbb4915f15a0ac818c992cdf
Reviewed-on: https://chromium-review.googlesource.com/538476
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480019}
[modify] https://crrev.com/362845cf3a6b3b455bd2457090747b361a51cd12/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp

Status: Fixed (was: Started)
Issue 733837 has been merged into this issue.
Cc: toyoshim@chromium.org
 Issue 733478  has been merged into this issue.
Issue 733817 has been merged into this issue.
Cc: hdodda@chromium.org
Labels: TE-Verified-61.0.3135.4 TE-Verified-M61
Tested the issue on windows 7 and ubuntu 14.04 using chrome dev M61 #61.0.3135.4 and issue seems fixed.

No Crash is seen on multiple refresh of chrome://settings page.

Attached screencas for reference.

Adding TE-Verified labels.

Thanks!


733499.ogv
2.8 MB View Download

Comment 14 by kochi@chromium.org, Jun 23 2017

Cc: kkaluri@chromium.org
 Issue 733182  has been merged into this issue.

Sign in to add a comment