mlamouri: could you help triage?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32a1bef0ff75c8e8117685119bc045b495e7aea7

commit 32a1bef0ff75c8e8117685119bc045b495e7aea7
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Thu Jun 15 05:21:34 2017

sheriff: Disable document-user-activattion and styles-history

Both tests are failing on Linux Trusty Leak. See issues for examples.

TBR=dgozman@chromium.org, mlamouri@chromium.org, lushnikov@chromium.org
NOTRY=true

Bug:  733495 , 733494
Change-Id: If194b96f51490357bba327759d833eb379a7639f
Reviewed-on: https://chromium-review.googlesource.com/536380
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479612}
[modify] https://crrev.com/32a1bef0ff75c8e8117685119bc045b495e7aea7/third_party/WebKit/LayoutTests/TestExpectations

tansell@ should have this be in the LeakExpectations? If not, any advice in how to reproduce this?

Also, before the logs disappear, this is the error the bots gave:
21:22:16.218 2280 worker/1 media/autoplay/document-user-activation.html failed:
21:22:16.218 2280 worker/1  leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,23],"numberOfLiveResources":[0,3],"numberOfLiveSuspendableObjects":[2,4]})

To reproduce locally, use the --enable-leak-detection flag of run-webkit-tests. This enables DOM object leak reporting:

  ./run-webkit-tests --enable-leak-detection media/autoplay/document-user-activation.html
OR
  ./run-webkit-tests --enable-leak-detection --skipped=ignore media/autoplay

In principle, any such leaks should be fixed. I'm not sure best how to debug them, but this might be helpful: https://developers.google.com/web/tools/chrome-devtools/memory-problems/heap-snapshots#uncover_dom_leaks

To mark a test as temporarily expected to have leak results, it's preferable to put a line in LeakExpectations rather than a Skip in TestExpectations, so that the tests are still run.

The test seems to have issues with user activation.  If the activation in the second promise_test is removed, i.e. the line
  eventSender.keyDown('a');
The following 4 promise_tests fail despite having their own pointerdown/up activation.

Becca can you PTAL?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63f4ae00dae6b21f11ecc4b5657a18b0daf5c04a

commit 63f4ae00dae6b21f11ecc4b5657a18b0daf5c04a
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Nov 23 21:23:38 2018

TestExpectations: do not skip document-user-activation.html as the test seems to pass.

Tested locally and everything is fine.

Bug: 733494
Change-Id: I23f3cde42b14d2461fc94a391c6427d5c2aa9e1d
Reviewed-on: https://chromium-review.googlesource.com/c/1263569
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610670}
[modify] https://crrev.com/63f4ae00dae6b21f11ecc4b5657a18b0daf5c04a/third_party/WebKit/LayoutTests/TestExpectations

Still fails on Linux Trusty Leak.

Revert triggered here: https://chromium-review.googlesource.com/c/chromium/src/+/1350184

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fec60db9be1f1c625025b3209fac8320d54f82b

commit 4fec60db9be1f1c625025b3209fac8320d54f82b
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Nov 26 11:06:31 2018

Revert "TestExpectations: do not skip document-user-activation.html as the test seems to pass."

This reverts commit 63f4ae00dae6b21f11ecc4b5657a18b0daf5c04a.

Reason for revert: Still fails with leak detector on Linux Trusty Leak.

Original change's description:
> TestExpectations: do not skip document-user-activation.html as the test seems to pass.
> 
> Tested locally and everything is fine.
> 
> Bug: 733494
> Change-Id: I23f3cde42b14d2461fc94a391c6427d5c2aa9e1d
> Reviewed-on: https://chromium-review.googlesource.com/c/1263569
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610670}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 733494
Change-Id: I509b798f79e64b8fb67be392d17a91834fd9c05a
Reviewed-on: https://chromium-review.googlesource.com/c/1350184
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610807}
[modify] https://crrev.com/4fec60db9be1f1c625025b3209fac8320d54f82b/third_party/blink/web_tests/TestExpectations

Any chance we could get a link to the failure?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbb424135e6f25ea3256d932834e7048394d3d0

commit 9bbb424135e6f25ea3256d932834e7048394d3d0
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Nov 28 23:07:02 2018

Move document-user-activation.html expectations to LeakExpectations.

This is allowing the test to run and mark it properly as a leak test
problem.

Bug: 733494
Change-Id: I9c4b9276745510482e58ea89dce9c65c596bcba5
Reviewed-on: https://chromium-review.googlesource.com/c/1352619
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611921}
[modify] https://crrev.com/9bbb424135e6f25ea3256d932834e7048394d3d0/third_party/blink/web_tests/LeakExpectations
[modify] https://crrev.com/9bbb424135e6f25ea3256d932834e7048394d3d0/third_party/blink/web_tests/TestExpectations