Omnibox suggestions animate on every key stroke when compiling with Xcode 9 |
|||||||||
Issue descriptionEvery time [self.tableView endUpdates] is called in omnibox_popup_material_view_controller, something weird is happening inside UIKit in _UITableViewUpdateSupport(Private) _setupAnimationsForExistingOffscreenCells which resets the cell to the default height of 44. Since the cell height is really 48, every keystroke constantly animates the height of each row from 44 to 48. I built a sample that does exactly what we do and couldn't reproduce, and I ripped out most of the non-standard things we do in Chrome and could still reproduce it. I'm out of ideas.
,
Jul 18 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69c6332a10bb33507627a75508e8ed2cca923c1e commit 69c6332a10bb33507627a75508e8ed2cca923c1e Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed Jul 19 14:43:38 2017 Fix omnibox popup animation on iOS 11. Set estimated row height so that the suggestions in omnibox popup don't jump upon typing. in correct place, without jumping up and down upon typing. Bug: 733488 Test: Type anything in omnibox. Observe that the suggestions appear Change-Id: Ie198f4b2220f2e035f34a012e4c07eef3b2f7482 Reviewed-on: https://chromium-review.googlesource.com/576182 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487854} [modify] https://crrev.com/69c6332a10bb33507627a75508e8ed2cca923c1e/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
,
Jul 19 2017
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label. All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 19 2017
,
Jul 19 2017
,
Jul 19 2017
,
Jul 25 2017
Tested on 62.0.3167.0 canary, iPhone 7 iOS 11, iPad Pro 11, also happening for ios 9.3.5, iOS 10 When Answer in suggest is shown than omnibox suggestions jump upon typing. https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLMHhwRUZOenNoRFk/view Justin, Please let me know if you would like me to open a separate bug for that.
,
Jul 25 2017
No, I think https://chromium-review.googlesource.com/c/576182/ just needs to account for answers in suggest. Thanks!
,
Aug 8 2017
stk@ FYI, from the release notes: Table views now use estimated heights by default, which also means that cells and section header/footer views now self-size by default. The default value of the estimatedRowHeight, estimatedSectionHeaderHeight, and estimatedSectionFooterHeight properties is now UITableViewAutomaticDimension, which means the table view selects an estimated height to use. You should still provide a more accurate estimate for each property if possible, which is your best guess of the average value of the actual heights. If you have existing table view code that behaves differently when you build your app with the iOS 11 SDK, and you don’t want to adopt self-sizing, you can restore the previous behavior by disabling estimated heights by setting a value of zero for each estimated height property. (30197915)
,
Aug 10 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65de85691df4bed564f3bbaf34e05c4c688b8900 commit 65de85691df4bed564f3bbaf34e05c4c688b8900 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Thu Aug 10 15:55:32 2017 Remove jumping when typing into omnibox on iOS 11. Disable self-sizing cells by setting estimatedRowHeight to 0, which prevents jumping from happening on iOS 11, even with suggest answers. Bug: 733488 Change-Id: I853f8e7a308437ee6d72329ad10e5e7bcf0561a2 Reviewed-on: https://chromium-review.googlesource.com/610005 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#493402} [modify] https://crrev.com/65de85691df4bed564f3bbaf34e05c4c688b8900/ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm
,
Aug 10 2017
,
Aug 15 2017
Omnibox suggestion animations are looking good. Also tested for Answers in Suggest. Verified in iPad Pro with iOS11.0 beta#6 Build: M62.0.3186.0 dev |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by justincohen@chromium.org
, Jun 15 2017Status: Assigned (was: Untriaged)