New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733482 link

Starred by 2 users
Status: Fixed
Owner:
moh...@chromium.org
Closed: Aug 20
Cc:
danakj@chromium.org
█ fsam...@chromium.org
rjkroege@chromium.org
sadrul@chromium.org
piman@chromium.org
█ reve...@chromium.org
kylec...@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 709332
issue 851488



Sign in to add a comment

Use ServerGpuMemoryBufferManager in content/browser

Project Member Reported by sadrul@chromium.org, Jun 15 2017 
ServerGpuMemoryBufferManager is currently used by mus-ws to allocate gpu memory. It uses the mojom.GpuService api.

BrowserGpuMemoryBufferManager is currently used by content/browser to allocate gpu memory. It uses the mojom.GpuService api through GpuProcessHost.

We should use ServerGpuMemoryBufferManager in //content/browser too, and get rid of BrowserGpuMemoryBufferManager.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f51373d28edbd397234c9ee7d60198f0a5e0189

commit 1f51373d28edbd397234c9ee7d60198f0a5e0189
Author: sadrul <sadrul@chromium.org>
Date: Wed Jun 21 17:24:53 2017

viz: Use a simple GpuMemoryBufferManager implementation.

Introduce InProcessGpuMemoryBufferManager, which directly interacts
with a GpuMemoryBufferFactory to allocate memory used by the display
compositor.

Follow on steps: relocate ServerGpuMemoryBufferManager into viz/host.

BUG= 733482 

Review-Url: https://codereview.chromium.org/2942283002
Cr-Commit-Position: refs/heads/master@{#481231}

[modify] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/components/viz/service/BUILD.gn
[modify] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/components/viz/service/display_compositor/gpu_display_provider.cc
[modify] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/components/viz/service/display_compositor/gpu_display_provider.h
[add] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/components/viz/service/display_compositor/in_process_gpu_memory_buffer_manager.cc
[add] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/components/viz/service/display_compositor/in_process_gpu_memory_buffer_manager.h
[modify] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/services/ui/gpu/BUILD.gn
[modify] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/services/ui/gpu/gpu_main.cc
[modify] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/services/ui/gpu/gpu_main.h
[modify] https://crrev.com/1f51373d28edbd397234c9ee7d60198f0a5e0189/services/ui/gpu/gpu_service.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9

commit fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9
Author: sadrul <sadrul@chromium.org>
Date: Thu Jun 22 13:39:21 2017

viz: Convert a sync api in ServerGpuMemoryBufferManager into async.

Convert ServerGpuMemoryBufferManager::CreateGpuMemoryBufferHandle() into
an async api. This is in preparation for using this implementation from
content.

BUG= 733482 
TBR=jbauman@ for gpu_memory_buffer_manager.h doc update
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2941933002
Cr-Commit-Position: refs/heads/master@{#481517}

[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/base/threading/thread_restrictions.h
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/components/BUILD.gn
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/components/viz/common/BUILD.gn
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/components/viz/common/DEPS
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/components/viz/common/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/components/viz/common/server_gpu_memory_buffer_manager.h
[add] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/components/viz/common/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/gpu/command_buffer/client/gpu_memory_buffer_manager.h
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/services/ui/gpu/interfaces/gpu_service.mojom
[modify] https://crrev.com/fbccda44a34bf3ddaf0aa3119afbba21fa9ab5a9/services/ui/ws/gpu_client.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e7ac4345c9b98f7a32115809a64f7e86bee33e6

commit 1e7ac4345c9b98f7a32115809a64f7e86bee33e6
Author: sadrul <sadrul@chromium.org>
Date: Mon Jun 26 21:54:10 2017

viz: Replace a DCHECK with proper error handling.

The code processes input from untrusted clients (e.g. renderers). So
instead of enforcing valid input through DCHECK(), properly handle
unsupported input and return invalid memory handles.

BUG= 733482 

Review-Url: https://codereview.chromium.org/2955813002
Cr-Commit-Position: refs/heads/master@{#482425}

[modify] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/components/viz/common/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/components/viz/common/server_gpu_memory_buffer_manager_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20c537c4f7982d52ba84cbbef7de7f48380dbd17

commit 20c537c4f7982d52ba84cbbef7de7f48380dbd17
Author: sadrul <sadrul@chromium.org>
Date: Tue Jun 27 17:40:02 2017

viz: Move ServerGpuMemoryBufferManager into host/gpu.

ServerGpuMemoryBufferManager used to live in viz/common, because it was used
by both the gpu host, and the display compositor service. Now that the latter
uses InProcessGpuMemoryBufferManager, ServerGpuMemoryBufferManager can move
into its rightful place.

BUG= 733482 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2941423002
Cr-Commit-Position: refs/heads/master@{#482669}

[modify] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/components/BUILD.gn
[delete] https://crrev.com/9a740797201d02dea291dfc83c8abb01f26fbc53/components/viz/common/BUILD.gn
[delete] https://crrev.com/9a740797201d02dea291dfc83c8abb01f26fbc53/components/viz/common/DEPS
[modify] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/components/viz/host/BUILD.gn
[modify] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/components/viz/host/DEPS
[rename] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/components/viz/host/server_gpu_memory_buffer_manager.cc
[rename] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/components/viz/host/server_gpu_memory_buffer_manager.h
[rename] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/services/ui/ws/BUILD.gn
[modify] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/services/ui/ws/DEPS
[modify] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/20c537c4f7982d52ba84cbbef7de7f48380dbd17/services/ui/ws/gpu_host.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/227004835aacc330a48440eae31f4aa1e666dcb8

commit 227004835aacc330a48440eae31f4aa1e666dcb8
Author: sadrul <sadrul@chromium.org>
Date: Sat Jul 08 22:51:42 2017

mus-gpu: Add support for tracking allocated gpu memory.

Make ServerGpuMemoryBufferManager a MemoryDumpProvider, so that it can
report the gpu memory usage by various clients.

BUG= 733482 

Review-Url: https://codereview.chromium.org/2971903003
Cr-Commit-Position: refs/heads/master@{#485151}

[modify] https://crrev.com/227004835aacc330a48440eae31f4aa1e666dcb8/components/viz/host/DEPS
[modify] https://crrev.com/227004835aacc330a48440eae31f4aa1e666dcb8/components/viz/host/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/227004835aacc330a48440eae31f4aa1e666dcb8/components/viz/host/server_gpu_memory_buffer_manager.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0

commit d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0
Author: sadrul <sadrul@chromium.org>
Date: Tue Jul 11 01:16:30 2017

gpu: Reduce direct use of BrowserGpuMemoryBufferManager.

. BrowserGpuMemoryBufferManager register itself as a dump-provider to
  MemoryDumpManager upon creation.
. Instead of getting the list of supported native gpu memory buffer
  configurations from BrowserGpuMemoryBufferManager, generate the list
  directly in GpuInternalUI. This is called only when the chrome:gpu page is
  loaded. So this should happen rarely enough that this should not introduce
  any latency, or any other kind of regression.

BUG= 733482 

Review-Url: https://codereview.chromium.org/2971083002
Cr-Commit-Position: refs/heads/master@{#485480}

[modify] https://crrev.com/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0/content/browser/browser_main_loop.cc
[modify] https://crrev.com/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/d30c3532f0cead481b8ef4c7290e0eb15d8fb6d0/content/browser/renderer_host/render_process_host_impl.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f970265e015bcf489f828967962e41ec431edfff

commit f970265e015bcf489f828967962e41ec431edfff
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Jul 21 23:36:21 2017

viz: Fix destroying gfx::GpuMemoryBuffers.

The destruction callback of a GpuMemoryBufferImpls can be called on any
thread[1]. So make sure the destruction callbacks hops onto the correct
thread before mutating local data structures or sending mojo messages.

[1] See doc for GpuMemoryBufferImpl::CreateFromHandle()
https://cs.chromium.org/chromium/src/gpu/ipc/client/gpu_memory_buffer_impl.h?l=28

BUG= 733482 

Change-Id: Ifc3fecd6a8bb42aa61f3d2d9667bd0e931d7261c
Reviewed-on: https://chromium-review.googlesource.com/565858
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488793}
[modify] https://crrev.com/f970265e015bcf489f828967962e41ec431edfff/components/viz/host/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/f970265e015bcf489f828967962e41ec431edfff/components/viz/host/server_gpu_memory_buffer_manager.h
[modify] https://crrev.com/f970265e015bcf489f828967962e41ec431edfff/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc

Comment 8 by jamescook@chromium.org, Apr 24 2018

Components: Internals>Services>WindowService
Labels: -Proj-Mustash-Mus-WS
Deprecating Proj-Mustash-Mus-WS in favor of component Internals>Services>WindowService.

Comment 9 by sadrul@chromium.org, May 29 2018

Cc: kylec...@chromium.org sadrul@chromium.org
Owner: moh...@chromium.org
Status: Assigned (was: Started)

Comment 10 Deleted

Comment 11 by moh...@chromium.org, Jul 5 

CL to replace usage of BrowserGpuMemoryBufferManager in //contnt/browser/ with ServerGpuMemoryBufferManager under review: https://crrev.com/c/1095815

Comment 12 by moh...@chromium.org, Jul 10 

The CL is getting big. Dividing it into smaller ones...
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fcf0520510bfa4f3dc4c5bbfea5a41ce99f20b8

commit 6fcf0520510bfa4f3dc4c5bbfea5a41ce99f20b8
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Tue Jul 10 19:33:12 2018

Pass in task runner to ServerGpuMemoryBufferManager

ServerGpuMemoryBufferManager uses a thread task runner to make sure
tasks are run on the expected thread. This CL passes in a task runner to
the constructor so this can be done against a thread other than the one
that created the instance. This is to make ServerGpuMemoryBufferManager
ready to be used in content where buffer allocation happens on IO
thread.

BUG= 733482 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie864e827de7f0464e2518316c4b7880a347f4074
Reviewed-on: https://chromium-review.googlesource.com/1131559
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573858}
[modify] https://crrev.com/6fcf0520510bfa4f3dc4c5bbfea5a41ce99f20b8/components/viz/host/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/6fcf0520510bfa4f3dc4c5bbfea5a41ce99f20b8/components/viz/host/server_gpu_memory_buffer_manager.h
[modify] https://crrev.com/6fcf0520510bfa4f3dc4c5bbfea5a41ce99f20b8/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/6fcf0520510bfa4f3dc4c5bbfea5a41ce99f20b8/services/ui/gpu_host/gpu_host.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c8fad4aae5553262a7bb32f4c3e5a974e9f294d

commit 7c8fad4aae5553262a7bb32f4c3e5a974e9f294d
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Tue Jul 17 22:21:57 2018

Handle GPU service restart in ServerGpuMemoryBufferManager

ServerGpuMemoryBufferManager is updated to support changing the GPU
service it is using, in case GPU process is crashed and restarted. If
this happens, it will retry pending allocation requests as soon as the
new GPU service is available.

BUG= 733482 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I56fa97c7b74ec71d7e7a18e0e3036ffd7350e296
Reviewed-on: https://chromium-review.googlesource.com/1132679
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575804}
[modify] https://crrev.com/7c8fad4aae5553262a7bb32f4c3e5a974e9f294d/components/viz/host/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/7c8fad4aae5553262a7bb32f4c3e5a974e9f294d/components/viz/host/server_gpu_memory_buffer_manager.h
[modify] https://crrev.com/7c8fad4aae5553262a7bb32f4c3e5a974e9f294d/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/7c8fad4aae5553262a7bb32f4c3e5a974e9f294d/services/ui/gpu_host/gpu_host.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25448d6a8806bbddc1ff4b487ef552bf467bf1ee

commit 25448d6a8806bbddc1ff4b487ef552bf467bf1ee
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Wed Jul 18 20:21:38 2018

Rename ServerGpuMemoryBufferManager to HostGpuMemoryBufferManager

BUG= 733482 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I2e886c67eb09f89a1bf8ddcdfc83bd8382dfa907
Reviewed-on: https://chromium-review.googlesource.com/1140918
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576183}
[modify] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/base/threading/thread_restrictions.h
[modify] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/components/viz/host/BUILD.gn
[rename] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/components/viz/host/host_gpu_memory_buffer_manager.cc
[rename] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/components/viz/host/host_gpu_memory_buffer_manager.h
[rename] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/components/viz/host/host_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/services/ui/gpu_host/gpu_client.cc
[modify] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/services/ui/gpu_host/gpu_client.h
[modify] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/services/ui/gpu_host/gpu_host.cc
[modify] https://crrev.com/25448d6a8806bbddc1ff4b487ef552bf467bf1ee/services/ui/gpu_host/gpu_host.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/914a6a5785c362ebedfa611648dafde6b51fc8ad

commit 914a6a5785c362ebedfa611648dafde6b51fc8ad
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Mon Jul 30 20:20:27 2018

Use factory callback for GpuService in HostGpuMemoryBufferManager

The callback is supposed to try to launch the GPU service if it is not
running.

BUG= 733482 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia65bb4b190d97920579ee55f735491e5f090bed7
Reviewed-on: https://chromium-review.googlesource.com/1152482
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579145}
[modify] https://crrev.com/914a6a5785c362ebedfa611648dafde6b51fc8ad/components/viz/host/host_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/914a6a5785c362ebedfa611648dafde6b51fc8ad/components/viz/host/host_gpu_memory_buffer_manager.h
[modify] https://crrev.com/914a6a5785c362ebedfa611648dafde6b51fc8ad/components/viz/host/host_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/914a6a5785c362ebedfa611648dafde6b51fc8ad/services/ui/gpu_host/gpu_host.cc

Comment 17 by moh...@chromium.org, Aug 9

Blocking: 851488
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/021565ba51cfea2594e02bb67a367118daaf5021

commit 021565ba51cfea2594e02bb67a367118daaf5021
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Fri Aug 10 08:16:41 2018

Allow HostGpuMemoryBufferManager to add connection error handler for GpuService

Whenever HostGpuMemoryBufferManager tries to get the GpuService instance
using GpuServiceProvider callback, it also sends a callback to be used
as the connection error handler for the GpuService. The code is also
updated such that the provider callback is called only when GpuService
has changed and the return value is cached.

BUG= 733482 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7f30dc4fd63fe079a02f6c2484ac14c75da3c36a
Reviewed-on: https://chromium-review.googlesource.com/1161211
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582089}
[modify] https://crrev.com/021565ba51cfea2594e02bb67a367118daaf5021/components/viz/host/host_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/021565ba51cfea2594e02bb67a367118daaf5021/components/viz/host/host_gpu_memory_buffer_manager.h
[modify] https://crrev.com/021565ba51cfea2594e02bb67a367118daaf5021/components/viz/host/host_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/021565ba51cfea2594e02bb67a367118daaf5021/services/ui/gpu_host/gpu_host.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b9d29e9d39da3cee7557e8b159a075cef1e681a

commit 8b9d29e9d39da3cee7557e8b159a075cef1e681a
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Mon Aug 20 15:34:26 2018

Use HostGpuMemoryBufferManager in content

This change replaces usage of content::BrowserGpuMemoryBufferManager
with viz::HostGpuMemoryBufferManager.

With this change BrowserGpuMemoryBufferManager is not needed anymore and
code to handle buffer allocation in GpuProcessHost is also removed.

BUG= 733482 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6a9387e2e33a5d98d4ed7559618f4995256bafa4
Reviewed-on: https://chromium-review.googlesource.com/1095815
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584455}
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/base/threading/thread_restrictions.h
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/components/viz/host/host_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/components/viz/host/host_gpu_memory_buffer_manager.h
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/BUILD.gn
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/browser_main_loop.cc
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/browser_process_sub_thread.cc
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/browser_gpu_channel_host_factory.cc
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/browser_gpu_channel_host_factory.h
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/browser_gpu_client_delegate.cc
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/browser_gpu_client_delegate.h
[delete] https://crrev.com/5f2d6d0ebafe50070086b76f4dd01db956e4d751/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[delete] https://crrev.com/5f2d6d0ebafe50070086b76f4dd01db956e4d751/content/browser/gpu/browser_gpu_memory_buffer_manager.h
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/gpu_client_delegate.h
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/gpu_data_manager_impl_private.cc
[add] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/gpu_memory_buffer_manager_singleton.cc
[add] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/gpu_memory_buffer_manager_singleton.h
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/8b9d29e9d39da3cee7557e8b159a075cef1e681a/content/browser/renderer_host/media/media_stream_manager.cc

Comment 20 by moh...@chromium.org, Aug 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment