New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733473 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Split testing/buildbot/chromium.*.json files into one file per builder.

Project Member Reported by tansell@chromium.org, Jun 15 2017

Issue description

Currently the buildbots are configured with a couple of giant JSON files.

This makes it extremely easy to edit the config for the wrong bot as you could have just paged up or down to far.

Because so much of the JSON file is also repeated between the bots it also makes the diffs problematic as they can frequently apply to multiple locations inside.

Having everything in the same file also makes it impossible to diff the config between two builders.

It would be much easier if the JSON file was split into one per bot. IE Something like;

  testing/buildbot/chromium.webkit/WebKit Linux Trusty.json
  testing/buildbot/chromium.webkit/WebKit Linux Trusty (dbg).json

The only real complication is the special characters (like brackets) in some builder names.

You could then do things like;

 diff "testing/buildbot/chromium.webkit/WebKit Linux Trusty.json" "testing/buildbot/chromium.webkit/WebKit Linux Trusty (dbg).json"

I know there are plans to replace / fix / modify this file in some way. However, this would be a relatively small change which would drastically improve the editing experience here.

As an example, I made a couple of mistakes editing this file last night while deploying layout tests on swarming that were not caught by myself or reviewers. I doubt I'm the only person who will end up making mistakes like this before these files are replaced.
 
Components: -Blink>Infra -Infra -Infra>Platform>Recipes Infra>Client>Chrome
Status: Available (was: Untriaged)
This seems like a reasonable thing to me (and is in fact what the iOS bots already do).

In addition to modifying the recipe code to read the individual files, you'd have to modify the GPU and Perf generators to do one-per-builder, but that should be straightforward.
FYI I'm not committing to doing this -- just came out of a discussion with Pawel.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Please reopen it if the request is still needed.

Sign in to add a comment