New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733471 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

GPU IDC doesn't handle greater than max texture size images with a scale factor in RGBA_4444 path

Project Member Reported by ericrk@chromium.org, Jun 15 2017

Issue description

Skia can't scale RGBA_4444 images, which the GPU IDC currently expects. We should decode to RGBA_8888, scale, and then convert to RGBA_4444 to get the correct behavior.
 

Comment 1 by ericrk@chromium.org, Jun 19 2017

Components: Internals>GPU>Image
Labels: -Pri-3 OS-Android Pri-1

Comment 2 by ericrk@chromium.org, Jun 21 2017

Labels: Merge-Request-60
Status: Started (was: Untriaged)
For some reason the commit bot didn't update this bug.

Requesting merge for the fix here: https://chromium-review.googlesource.com/c/540260
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 21 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by ericrk@chromium.org, Jun 21 2017

amineer@, this is the other bug I mentioned in our discussion on  crbug.com/720105 . Thanks!

Comment 5 by ericrk@chromium.org, Jun 21 2017

Cc: amineer@chromium.org
Labels: -Merge-Review-60 Merge-Approved-60
Approved for M60 branch 3112.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 22 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8d794a795b41500849a90cebef384b0b5f322ba

commit b8d794a795b41500849a90cebef384b0b5f322ba
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Jun 21 23:58:56 2017

Handle RGBA_4444 scales in > max texture size images

Currently, we have a hole in the GPU Image Decode Controller where a
greater-than-max-texture-size image, rendered in non-RGBA-8888 color,
and scaled down by more than 50%, will hit a guaranteed failure case in
Skia. This change adds a path which works around this failure case.

Bug:  733471 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0d1aed82c3e4590de37eb403ffa96673fbe1e163
Reviewed-on: https://chromium-review.googlesource.com/540260
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480887}
Review-Url: https://codereview.chromium.org/2952923002 .
Cr-Commit-Position: refs/branch-heads/3112@{#434}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/b8d794a795b41500849a90cebef384b0b5f322ba/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/b8d794a795b41500849a90cebef384b0b5f322ba/cc/tiles/gpu_image_decode_cache_unittest.cc

Comment 8 by ericrk@chromium.org, Jun 22 2017

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23cafd658effa3ad82eb3584eb37cb3e52d0095

commit c23cafd658effa3ad82eb3584eb37cb3e52d0095
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Jun 22 18:12:48 2017

Handle RGBA_4444 scales in > max texture size images

Re-land with merge fix.

Currently, we have a hole in the GPU Image Decode Controller where a
greater-than-max-texture-size image, rendered in non-RGBA-8888 color,
and scaled down by more than 50%, will hit a guaranteed failure case in
Skia. This change adds a path which works around this failure case.

Bug:  733471 , 735795
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0d1aed82c3e4590de37eb403ffa96673fbe1e163
Reviewed-on: https://chromium-review.googlesource.com/540260
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480887}
Review-Url: https://codereview.chromium.org/2949303002 .
Cr-Commit-Position: refs/branch-heads/3112@{#443}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/c23cafd658effa3ad82eb3584eb37cb3e52d0095/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/c23cafd658effa3ad82eb3584eb37cb3e52d0095/cc/tiles/gpu_image_decode_cache_unittest.cc

Sign in to add a comment