GPU IDC doesn't handle greater than max texture size images with a scale factor in RGBA_4444 path |
|||||||
Issue descriptionSkia can't scale RGBA_4444 images, which the GPU IDC currently expects. We should decode to RGBA_8888, scale, and then convert to RGBA_4444 to get the correct behavior.
,
Jun 21 2017
For some reason the commit bot didn't update this bug. Requesting merge for the fix here: https://chromium-review.googlesource.com/c/540260
,
Jun 21 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2017
amineer@, this is the other bug I mentioned in our discussion on crbug.com/720105 . Thanks!
,
Jun 21 2017
,
Jun 21 2017
Approved for M60 branch 3112.
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8d794a795b41500849a90cebef384b0b5f322ba commit b8d794a795b41500849a90cebef384b0b5f322ba Author: Eric Karl <ericrk@chromium.org> Date: Wed Jun 21 23:58:56 2017 Handle RGBA_4444 scales in > max texture size images Currently, we have a hole in the GPU Image Decode Controller where a greater-than-max-texture-size image, rendered in non-RGBA-8888 color, and scaled down by more than 50%, will hit a guaranteed failure case in Skia. This change adds a path which works around this failure case. Bug: 733471 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d1aed82c3e4590de37eb403ffa96673fbe1e163 Reviewed-on: https://chromium-review.googlesource.com/540260 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#480887} Review-Url: https://codereview.chromium.org/2952923002 . Cr-Commit-Position: refs/branch-heads/3112@{#434} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/b8d794a795b41500849a90cebef384b0b5f322ba/cc/tiles/gpu_image_decode_cache.cc [modify] https://crrev.com/b8d794a795b41500849a90cebef384b0b5f322ba/cc/tiles/gpu_image_decode_cache_unittest.cc
,
Jun 22 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c23cafd658effa3ad82eb3584eb37cb3e52d0095 commit c23cafd658effa3ad82eb3584eb37cb3e52d0095 Author: Eric Karl <ericrk@chromium.org> Date: Thu Jun 22 18:12:48 2017 Handle RGBA_4444 scales in > max texture size images Re-land with merge fix. Currently, we have a hole in the GPU Image Decode Controller where a greater-than-max-texture-size image, rendered in non-RGBA-8888 color, and scaled down by more than 50%, will hit a guaranteed failure case in Skia. This change adds a path which works around this failure case. Bug: 733471 , 735795 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d1aed82c3e4590de37eb403ffa96673fbe1e163 Reviewed-on: https://chromium-review.googlesource.com/540260 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#480887} Review-Url: https://codereview.chromium.org/2949303002 . Cr-Commit-Position: refs/branch-heads/3112@{#443} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/c23cafd658effa3ad82eb3584eb37cb3e52d0095/cc/tiles/gpu_image_decode_cache.cc [modify] https://crrev.com/c23cafd658effa3ad82eb3584eb37cb3e52d0095/cc/tiles/gpu_image_decode_cache_unittest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ericrk@chromium.org
, Jun 19 2017Labels: -Pri-3 OS-Android Pri-1