New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733467 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-after-poison in blink::HTMLSlotElement::LazyReattachDistributedNodesIfNeeded

Project Member Reported by ClusterFuzz, Jun 15 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5350335169429504

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Use-after-poison READ 8
Crash Address: 0x7e8c3d224798
Crash State:
  blink::HTMLSlotElement::LazyReattachDistributedNodesIfNeeded
  blink::SlotAssignment::ResolveDistribution
  blink::Node::RecalcDistribution
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=474583:474657

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5350335169429504


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 15 2017

Labels: M-60
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 15 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 15 2017

Labels: Pri-1

Comment 4 by est...@chromium.org, Jun 16 2017

Cc: hayato@chromium.org
Components: Blink>DOM
Owner: aboxhall@chromium.org
Status: Assigned (was: Untriaged)
aboxhall, could you please take a look and see if this is related to https://chromium.googlesource.com/chromium/src/+/58a3e83e1325c8a366941564ca8ce096bb1345df?

Also cc hayato in case it's related to https://chromium.googlesource.com/chromium/src/+/933dc3199a9418e3c5b1d14d681d976867e8e4f9
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 16 2017

Labels: M-60
Project Member

Comment 6 by ClusterFuzz, Jun 20 2017

ClusterFuzz has detected this issue as fixed in range 480271:480432.

Detailed report: https://clusterfuzz.com/testcase?key=5350335169429504

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Use-after-poison READ 8
Crash Address: 0x7e8c3d224798
Crash State:
  blink::HTMLSlotElement::LazyReattachDistributedNodesIfNeeded
  blink::SlotAssignment::ResolveDistribution
  blink::Node::RecalcDistribution
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=474583:474657
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=480271:480432

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5350335169429504


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jun 20 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5350335169429504 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 20 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 22 2017

Labels: Merge-Request-60
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 22 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Approving merge to M60. 
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 27 2017

Cc: abdulsyed@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 30 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi aboxhall@ - any ideas what in 61 might have fixed this, and is worth a merge to 60?  (If not we can remove the merge tags) 
Please merge this to M60 ASAP. branch:3112
Labels: -Hotlist-Merge-Review -ReleaseBlock-Stable -M-60 -Merge-Approved-60 M-61
Removing labels as we don't have an identified fix to merge.
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 26 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment