Issue metadata
Sign in to add a comment
|
Improve DumpAccessibilityTreeTest.* |
||||||||||||||||||||||||
Issue descriptionThe AccessibilityTreeFormatterWin code generates an AXTree which we compare against known values. This code currently reaches into the internals of BrowserAccessibilityWin instead of using the public COM interfaces which screen readers and other AT uses. Recently, I made a change to a low level API (get_accState()) which I thought would have been tested by our DumpAccessibilityTreeTest.* tests. Unfortunately I didn't test as well as I should have and caused a regression: https://bugs.chromium.org/p/chromium/issues/detail?id=733313 What I would like to do is clean up things such that: 1) BrowserAccessibilityWin only exposes the accessors that we need to. 2) Modify AccessibilityTreeFormatterWin to use the public COM API.
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5859af4f6c0c07cf97069fdbe5d40afb40a7ad17 commit 5859af4f6c0c07cf97069fdbe5d40afb40a7ad17 Author: dougt <dougt@chromium.org> Date: Thu Jun 15 06:12:18 2017 Improvements to our windows accessibility tree testing. This cl makes two changes. First it makes private some BrowserAccessibilityWin accessors. Clients should use the public COM API when accessing state/roles/etc. Second, I am also modifying AccessibilityTreeFormatterWin to use the public COM API. This works for the most part, but the formatter still needs access to the role name as well as some positioning information. BUG= 733437 Review-Url: https://codereview.chromium.org/2938113002 Cr-Commit-Position: refs/heads/master@{#479620} [modify] https://crrev.com/5859af4f6c0c07cf97069fdbe5d40afb40a7ad17/content/browser/accessibility/accessibility_tree_formatter_win.cc [modify] https://crrev.com/5859af4f6c0c07cf97069fdbe5d40afb40a7ad17/content/browser/accessibility/browser_accessibility_com_win.h
,
Jul 13 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dougt@chromium.org
, Jun 14 2017