VR: Scroll end can hit DCHECK in RenderWidgetHostImpl |
||||||
Issue descriptionDCHECK being hit is: [FATAL:render_widget_host_impl.cc(1128)] Check failed: is_in_gesture_scroll_[gesture_event.source_device] || gesture_event.GetType() == blink::WebInputEvent::kGestureFlingStart. Steps to reproduce: ??? I was playing with interstitial pages at the time? Navigating from NTP maybe? I'm fairly certain though that the cause is renderer swaps happen asynchronously to our event generation. We create our input events on the GL thread, and post them to the UI thread, and the renderer may have been swapped in the meantime. What we should probably do is stop processing input from the GL thread until it's ACK'd in response to renderer change message and reset its gesture state.
,
Jun 20 2017
,
Jul 10 2017
I wonder if this could be due to not setting the source device on the event when we create it here? https://cs.chromium.org/chromium/src/chrome/browser/android/vr_shell/vr_controller.cc?rcl=c76d136a3896d6cb15b833193035333a3f3ca161&l=290
,
Aug 14 2017
,
Sep 15 2017
,
Sep 15 2017
Is this P1? If so, what are the next steps for this?
,
Sep 22 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e60013f285b808bade0969bad9f9cf274ea47ab3 commit e60013f285b808bade0969bad9f9cf274ea47ab3 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Oct 12 03:36:30 2017 VR: Lock the scrolling events to a content If there is a content swap in the middle of a scrolling, the remaining of the sequence of scrolling/fling events shouldn't be sent to the new content. This stops the hitting the DCHECKs for scrollUpdate without scrollBegin when moving from a native page to a webcontent and other way around. BUG= 733419 Change-Id: Ieba0278218332f602f084f47267fd38d29533c2a Reviewed-on: https://chromium-review.googlesource.com/712836 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#508248} [modify] https://crrev.com/e60013f285b808bade0969bad9f9cf274ea47ab3/chrome/browser/android/vr_shell/gl_browser_interface.h [modify] https://crrev.com/e60013f285b808bade0969bad9f9cf274ea47ab3/chrome/browser/android/vr_shell/vr_gl_thread.cc [modify] https://crrev.com/e60013f285b808bade0969bad9f9cf274ea47ab3/chrome/browser/android/vr_shell/vr_gl_thread.h [modify] https://crrev.com/e60013f285b808bade0969bad9f9cf274ea47ab3/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/e60013f285b808bade0969bad9f9cf274ea47ab3/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/e60013f285b808bade0969bad9f9cf274ea47ab3/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/e60013f285b808bade0969bad9f9cf274ea47ab3/chrome/browser/android/vr_shell/vr_shell_gl.h
,
Oct 12 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 Deleted