New issue
Advanced search Search tips

Issue 733416 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 631151
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: ----
Type: Bug-Security



Sign in to add a comment

Crash in blink::HTMLFrameElementBase::DidNotifySubtreeInsertionsToDocument

Project Member Reported by ClusterFuzz, Jun 14 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5876122314342400

Fuzzer: ifratric-browserfuzzer-v3
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0xe9912080
Crash State:
  blink::HTMLFrameElementBase::DidNotifySubtreeInsertionsToDocument
  blink::ContainerNode::DidInsertNodeVector
  blink::ContainerNode::InsertBefore
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=448729:448971

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5876122314342400


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by est...@chromium.org, Jun 14 2017

Components: Blink>DOM
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
tkent, can you please take a look? Maybe related to https://codereview.chromium.org/2496133002?

Comment 2 by tkent@chromium.org, Jun 14 2017

Status: Started (was: Assigned)
This is a SECURITY_CHECK() failure.  So this is not vulnerable.


Comment 3 by tkent@chromium.org, Jun 15 2017

Cc: hirosh...@chromium.org
hiroshige, FYI.  This is caused by recursive synchronous 'load' events.


Comment 4 by tkent@chromium.org, Jun 15 2017

Components: -Blink>DOM Blink>HTML>IFrame
I found that
 - synchronous 'load' event was not a culprit. If we make 'load' event asynchronous, the repro case in the CF entry won't crash.  However, it won't fix the root issue.

 - My CL was not a culprit. The following minimum repro should crash without my CL.

<body>
<script>
var iframe1;
window.onload = function() {
  var fragment = document.createDocumentFragment();
  var script = fragment.appendChild(document.createElement('script'));
  iframe1 = fragment.appendChild(document.createElement('iframe'));
  fragment.appendChild(document.createTextNode('foo'));
  script.textContent = 'document.body.appendChild(iframe1);';
  document.body.appendChild(fragment);
};
</script>
</body>

Comment 5 by tkent@chromium.org, Jun 15 2017

Cc: jochen@chromium.org dcheng@chromium.org
add jochen@ and dcheng@ who might review a fix.

Comment 6 by dcheng@chromium.org, Jun 15 2017

Also see  issue 631151 .

Comment 7 by tkent@chromium.org, Jun 15 2017

Mergedinto: 631151
Status: Duplicate (was: Started)
 Issue 631151  and this look identical.  Merging.

Project Member

Comment 8 by ClusterFuzz, Jun 16 2017

ClusterFuzz has detected this issue as fixed in range 479633:479657.

Detailed report: https://clusterfuzz.com/testcase?key=5876122314342400

Fuzzer: ifratric-browserfuzzer-v3
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0xe9912080
Crash State:
  blink::HTMLFrameElementBase::DidNotifySubtreeInsertionsToDocument
  blink::ContainerNode::DidInsertNodeVector
  blink::ContainerNode::InsertBefore
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=448729:448971
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=479633:479657

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5876122314342400


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 21 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment