New issue
Advanced search Search tips

Issue 733413 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug-Regression



Sign in to add a comment

hterm: moving the mouse now triggering selection in tmux

Project Member Reported by craigcitro@google.com, Jun 14 2017 
Chrome Version: 58.0.3029.140 (Official Build) (64-bit)
OS: ChromeOS

What steps will reproduce the problem?
(1) Open Secure Shell Dev (0.8.36.5)
(2) Connect to a linux machine running tmux 2.5 with `set-option -g mouse on`
(3) Move the mouse

What is the expected result? mouse moves

What happens instead? text between start and end positions is copied

Note that I *don't* see this issue on Secure Shell (0.8.36.3).

Comment 1 Deleted

Comment 2 by vapier@chromium.org, Jun 15 2017

Owner: vapier@chromium.org
looks like this was caused by:
  https://chromium-review.googlesource.com/513564

the last hunk in hterm_vt.js stopped checking e.which (since e.button==0 is the left button while e.which==0 is no buttons), but i misread the logic ... should have replaced the gate with something else since this is a mousemove event.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/50615c069111150d6879a6e3db20b95e5fd43aaf

commit 50615c069111150d6879a6e3db20b95e5fd43aaf
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jun 15 05:45:24 2017

hterm: fix mouse move reporting

The recent change 2edd36139eb27918c8f98e7430adca8126026630 (hterm:
switch to standard MouseEvent.button) broke reporting when moving
the mouse.  Before, we'd only report when a button was pushed, but
now we incorrectly reported even when no buttons are pushed.

Also take the opporunity to fix this code so that it better complies
with the xterm mouse protocol.  Namely, the middle button is higher
precedence than the right button, and we handle higher buttons.

BUG= chromium:733413 

Change-Id: I70a8cffb73230e0bc4671242eeb954e279e5774e
Reviewed-on: https://chromium-review.googlesource.com/536355
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/50615c069111150d6879a6e3db20b95e5fd43aaf/hterm/js/hterm_vt.js

Comment 4 by vapier@chromium.org, Jun 15 2017

Status: Fixed (was: Available)
this will be fixed in hterm-1.66+ and nassh-0.8.36.6+
►

Sign in to add a comment