New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733409 link

Starred by 4 users
Status: Archived
Owner:
wzang@chromium.org
Closed: Aug 2017
Cc:
█ elizabethchiu@chromium.org
zalcorn@chromium.org
abodenha@chromium.org
r...@chromium.org
wzang@chromium.org
dhadd...@chromium.org
jdufault@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 750260


Sign in to add a comment

Wallpaper appears at full brightness after boot and is later abruptly dimmed

Project Member Reported by derat@chromium.org, Jun 14 2017 
In a ToT build (61.0.3131.0) with the new login/lock screen, there's an awkward visual transition when Chrome first starts. After the boot splash screen is shown, Chrome comes up with the selected user's wallpaper at full brightness (0:11 in the video I recorded at http://dr/file/d/0ByeZYyW9WlyvUHhuRmlhLTNUQTg/view). After the user pods appear, the wallpaper is abruptly dimmed (0:14).

If we intend to dim the wallpaper, we should either make it already be dimmed when it first appears, or experiment with animating the transition from the undimmed to dimmed state. I haven't seen mocks, so I'm not sure what the expected experience is.

Comment 1 by wzang@chromium.org, Jun 15 2017

Cc: elizabethchiu@chromium.org
Owner: wzang@chromium.org
Status: Assigned (was: Available)
elizabethchiu@, please design an animation for the transition between the undimmed and dimmed states to make it more natural.

Comment 2 by elizabethchiu@chromium.org, Jun 15 2017 

wzang@ Would you mind to send me a video of how it looks currently?

Comment 3 by wzang@chromium.org, Jun 15 2017 

http://dr/file/d/0ByeZYyW9WlyvUHhuRmlhLTNUQTg/view (recorded by derat@)

Comment 4 by elizabethchiu@chromium.org, Jun 15 2017 

Please take a look at the transition animation here. 
The background should fade in smoothly, then the bottom UI show up afterwards.
after boot transition.mov
2.2 MB Download

Comment 5 by derat@chromium.org, Jun 15 2017 

Thanks. So it looks like there are two differences from the current implementation:

a) The wallpaper is supposed to fade in smoothly over the boot splash screen.
b) The wallpaper is supposed to start in an already-dimmed state.

b) is hopefully easy to fix, but a) may be harder. I've implemented a) in the past (just for lumpy, I think), but that was when we were using X11 instead of Ozone.

Comment 6 by wzang@chromium.org, Jun 19 2017

Cc: dhadd...@chromium.org abod...@chromium.org
 Issue 734802  has been merged into this issue.

Comment 7 by wzang@chromium.org, Jun 20 2017 

jdufault@, could you compare the two options in #5? What I'm able to do now is to make the dark overlay fade in gradually, but the wallpaper itself still appears rather abruptly, and we may still see a bright wallpaper for ~1 sec before the dark overlay 'smoothly' fades in.

Comment 8 by derat@chromium.org, Jun 20 2017 

I wasn't listing options in #5; I was listing individual differences between the mock and the current implementation. :-)

Can you make the dark overlay appear immediately as the same time as the wallpaper?

Comment 9 by jdufault@chromium.org, Jun 20 2017 

We should probably move the wallpaper dimming from webui into ash/views and activate it as soon as we start loading the login/lock screen. I expect that this will eliminate most of the current delay, which is caused by loading the login or lock screen html.

For example, we apply the background inside the WebUILoginView Init method[1]. This depends on the views based blur to be efficient, but I believe that is still slated for m61. If this doesn't work / is too slow for some reason, we will probably need to tie directly into the wallpaper rendering code.

1: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/webui_login_view.cc?dr=CSs&l=257

Comment 10 Deleted

Comment 11 by zalcorn@chromium.org, Jun 26 2017 

wzang@ looks like your comment was deleted, did we reach a resolution?
I actually thought option 2) (precalculating color and storing in user prefs) sounded like the best experience, but not sure how expensive it is to implement.

Comment 12 by jdufault@chromium.org, Jun 26 2017 

I'm also a fan of precalculating and storing the color in user prefs. We will need this in views-based lock as well so it can be used in both implementations.

I think implementation will be reasonable.

Comment 13 by bruthig@chromium.org, Jul 3 2017 

What color are you suggesting to store in a user pref, the color extracted from the Wallpaper?

If so, you might find this experimental CL useful: https://codereview.chromium.org/2772313004/

I explored storing the extracted color in a user pref but ended up abandoning it because we drastically reduced the duration of the extraction algorithm (and we didn't require the color at sign-in).

Anyway, notable points are:
- The CL uses old style access to the pref service, which wouldn't work in the MAsh world.  I'm not sure if the new MAsh pref service is mature enough to use yet...
- A unique id for the wallpaper is still needed; the most likely candidate is the file path which would still need to be plumbed through.
- The CL was only allowing 1 cached color per wallpaper, it would seem that more than 1 is necessary now with WallpaperController::color_profiles_ being a collection.

Comment 14 by wzang@chromium.org, Jul 5 2017 

I also had an experimental CL for caching colors but abandoned it because the pref service doesn't work with MAsh, and I noticed that the calculation actually doesn't cause delay for the sign-in screen.

Comment 15 by derat@chromium.org, Jul 19 2017 

Any progress here?

Comment 16 by wzang@chromium.org, Jul 19 2017

Cc: abodenha@chromium.org
 Issue 746685  has been merged into this issue.

Comment 17 by derat@chromium.org, Jul 19 2017 

Per  issue 746685 , this bug is also tracking making us not scale the dimming layer as it fades in when the screen is locked.

Comment 18 by wzang@chromium.org, Jul 19 2017 

We've had progress on wallpaper calculation cache which is an integral part of the new dimming method which will be able to avoid the full brightness stage. 

Even if the new dimming method doesn't work, I'll remove the scaling effect of the current dimming, but that won't happen because we'll definitely have the new dimming for M61.
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b324a8abf33635d73ad24dd30018cc08397f393e

commit b324a8abf33635d73ad24dd30018cc08397f393e
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jul 27 22:58:50 2017

Add wallpaper color caching

A wallpaper goes through at least the following stages before being
set:

|WallpaperManager|  (Keys e.g. account ID and file path are available)
        |
|WallpaperController|   (Only image is passed, not unique ID)
        |
|WallpaperResizer|        (Image itself is changed too)
        |
|WallpaperCalculator|     (Nothing stays the same)
        |
Back to |WallpaperController|

For now we can assign the |WallpaperInfo| to |WallpaperController|
for caching purpose. This method is not optimal but I believe other
available options are more problematic, e.g.,

Backup 1: Move calculation to |WallpaperManager|, but:
1) |WallpaperView| uses the color to apply dimming when painting the
wallpaper and it interacts closely with |WallpaperController|. If the
calculation is moved to |WallpaperManager|, there is no way for
|WallpaperView| to check the calculation progress.

2) Wallpaper resizing 'may' influence the color calculation so we'd
better wait until resizing is done to start color calculation.

3) Moving codes to |WallpaperManager| may involve setting a timer, but
it's hard to find a good choice of the upper limit. Currently color
calculation is only allowed during an active session, and in theory
we don't need to set a limit on the calculation time.

4) |WallpaperManager| still needs to rely on |WallpaperController| to
notify observers under /ash.

Backup 2: Pass the ID along the path till the calculation stage, but it
requires changing lots of APIs.

Backup 3: Add an inherent attribute to the image class |ImageSkia|,
but it's not doable under the current implementation.

In addition, although Account ID and file path can both be used as key,
since we need to initiate a calculation attempt whenever the session
state becomes ACTIVE, only file path can distinguish between new and
and old wallpaper.

Bug:  733409 
Change-Id: I55f27ee6fccddf74eafad559438dee241abb1522
Reviewed-on: https://chromium-review.googlesource.com/572144
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490051}
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/mus/wallpaper_delegate_mus.cc
[add] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/public/cpp/wallpaper_struct_traits.cc
[add] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/public/cpp/wallpaper_struct_traits.h
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/public/interfaces/wallpaper.typemap
[delete] https://crrev.com/bb825dab407517887387f91be66e3269fc539a31/ash/public/interfaces/wallpaper_struct_traits.h
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/wallpaper/test_wallpaper_delegate.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/wallpaper/wallpaper_controller_test_api.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/extensions/wallpaper_function_base.h
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/components/wallpaper/BUILD.gn
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/components/wallpaper/DEPS
[add] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/components/wallpaper/wallpaper_info.h
[delete] https://crrev.com/bb825dab407517887387f91be66e3269fc539a31/components/wallpaper/wallpaper_layout.h
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/components/wallpaper/wallpaper_manager_base.h
[modify] https://crrev.com/b324a8abf33635d73ad24dd30018cc08397f393e/components/wallpaper/wallpaper_resizer.h
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2398196195d7a4ca3e89ea4a173a53f3b0e89593

commit 2398196195d7a4ca3e89ea4a173a53f3b0e89593
Author: James Cook <jamescook@chromium.org>
Date: Tue Aug 01 06:11:27 2017

Revert "Add wallpaper color caching"

This reverts commit b324a8abf33635d73ad24dd30018cc08397f393e.

Reason for revert: Causes crashes in Chrome OS chrome-informational waterfall
test desktopui_MashLogin:
https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5382

https://bugs.chromium.org/p/chromium/issues/detail?id=750766

1  chrome!base::DictionaryValue::GetListWithoutPathExpansion(base::BasicStringPiece<std::string>, base::ListValue const**) const [flat_tree.h : 878 + 0x8]
2  chrome!ash::WallpaperController::CalculateWallpaperColors() [wallpaper_controller.cc : 79 + 0x8]
3  chrome!non-virtual thunk to ash::WallpaperController::OnWallpaperResized() [wallpaper_controller.cc : 374 + 0x5]
4  chrome!wallpaper::WallpaperResizer::OnResizeFinished(SkBitmap*) [wallpaper_resizer.cc : 159 + 0x5]
5  chrome!base::(anonymous namespace)::PostTaskAndReplyRelay::RunReplyAndSelfDestruct() [callback.h : 91 + 0x3]
6  chrome!base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) [callback.h : 91 + 0x3]

Original change's description:
> Add wallpaper color caching
>
> A wallpaper goes through at least the following stages before being
> set:
>
> |WallpaperManager|  (Keys e.g. account ID and file path are available)
>         |
> |WallpaperController|   (Only image is passed, not unique ID)
>         |
> |WallpaperResizer|        (Image itself is changed too)
>         |
> |WallpaperCalculator|     (Nothing stays the same)
>         |
> Back to |WallpaperController|
>
> For now we can assign the |WallpaperInfo| to |WallpaperController|
> for caching purpose. This method is not optimal but I believe other
> available options are more problematic, e.g.,
>
> Backup 1: Move calculation to |WallpaperManager|, but:
> 1) |WallpaperView| uses the color to apply dimming when painting the
> wallpaper and it interacts closely with |WallpaperController|. If the
> calculation is moved to |WallpaperManager|, there is no way for
> |WallpaperView| to check the calculation progress.
>
> 2) Wallpaper resizing 'may' influence the color calculation so we'd
> better wait until resizing is done to start color calculation.
>
> 3) Moving codes to |WallpaperManager| may involve setting a timer, but
> it's hard to find a good choice of the upper limit. Currently color
> calculation is only allowed during an active session, and in theory
> we don't need to set a limit on the calculation time.
>
> 4) |WallpaperManager| still needs to rely on |WallpaperController| to
> notify observers under /ash.
>
> Backup 2: Pass the ID along the path till the calculation stage, but it
> requires changing lots of APIs.
>
> Backup 3: Add an inherent attribute to the image class |ImageSkia|,
> but it's not doable under the current implementation.
>
> In addition, although Account ID and file path can both be used as key,
> since we need to initiate a calculation attempt whenever the session
> state becomes ACTIVE, only file path can distinguish between new and
> and old wallpaper.
>
> Bug:  733409 
> Change-Id: I55f27ee6fccddf74eafad559438dee241abb1522
> Reviewed-on: https://chromium-review.googlesource.com/572144
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
> Reviewed-by: Biao She <bshe@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Oliver Chang <ochang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490051}

TBR=derat@chromium.org,bshe@chromium.org,lhchavez@chromium.org,xdai@chromium.org,ochang@chromium.org,wzang@chromium.org

Bug:  733409 
Change-Id: Id39ad572355bcba0d1ccb5fe86bfabfb5f4ee101
Reviewed-on: https://chromium-review.googlesource.com/594715
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490879}
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/mus/wallpaper_delegate_mus.cc
[delete] https://crrev.com/d339f305e11fdc08da841c57c632094e7b9786cb/ash/public/cpp/wallpaper_struct_traits.cc
[delete] https://crrev.com/d339f305e11fdc08da841c57c632094e7b9786cb/ash/public/cpp/wallpaper_struct_traits.h
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/public/interfaces/wallpaper.typemap
[add] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/public/interfaces/wallpaper_struct_traits.h
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/wallpaper/test_wallpaper_delegate.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/wallpaper/wallpaper_controller_test_api.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/extensions/wallpaper_function_base.h
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/components/wallpaper/BUILD.gn
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/components/wallpaper/DEPS
[delete] https://crrev.com/d339f305e11fdc08da841c57c632094e7b9786cb/components/wallpaper/wallpaper_info.h
[add] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/components/wallpaper/wallpaper_layout.h
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/components/wallpaper/wallpaper_manager_base.h
[modify] https://crrev.com/2398196195d7a4ca3e89ea4a173a53f3b0e89593/components/wallpaper/wallpaper_resizer.h
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb86464a8cb4944b52be8572fbf7e7e1387381c1

commit eb86464a8cb4944b52be8572fbf7e7e1387381c1
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Aug 02 01:50:44 2017

Move all login screen related constants to a separate file

Login/lock screen related constants may be used from at least three
places: views-based lock, WebUi based login/lock and wallpaper. So
we want to move them together just as shelf_constants.h

Bug:  732566 ,  733409 
Change-Id: I791d5dfbd02f35cdcc6064b964b97b6978a376d2
Reviewed-on: https://chromium-review.googlesource.com/590483
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491196}
[modify] https://crrev.com/eb86464a8cb4944b52be8572fbf7e7e1387381c1/ash/BUILD.gn
[modify] https://crrev.com/eb86464a8cb4944b52be8572fbf7e7e1387381c1/ash/login/ui/lock_screen.cc
[add] https://crrev.com/eb86464a8cb4944b52be8572fbf7e7e1387381c1/ash/login/ui/login_constants.h
[modify] https://crrev.com/eb86464a8cb4944b52be8572fbf7e7e1387381c1/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56c29293574857438baf4215bb3a9d2df9751afe

commit 56c29293574857438baf4215bb3a9d2df9751afe
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Aug 02 04:58:34 2017

Re-land of Add Wallpaper Color Caching and skip prefs reading under MASH

After offline discussion with jamescook@, the prefs reading is skipped
in the case of config::MASH until  crbug.com/751143  is fixed.

This CL combines https://chromium-review.googlesource.com/c/572144 and 
https://chromium-review.googlesource.com/c/595123. TBR because the
entire CL has been reviewed.

Please note there's another CL
(https://chromium-review.googlesource.com/c/592228)
depending on this one. (specifically, Shell::RegisterLocalStatePrefs)

TBR=jamescook@chromium.org,derat@chromium.org,bshe@chromium.org
lhchavez@chromium.org,xdai@chromium.org,ochang@chromium.org

Bug:  733409 
Change-Id: Ibeb260c94a174819322121efe12c2865f5df78c7
Reviewed-on: https://chromium-review.googlesource.com/596801
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491271}
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/mus/wallpaper_delegate_mus.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/public/cpp/ash_pref_names.h
[add] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/public/cpp/wallpaper_struct_traits.cc
[add] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/public/cpp/wallpaper_struct_traits.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/public/interfaces/wallpaper.typemap
[delete] https://crrev.com/b798035b8d14e5539648ba3a984ac8495d2bf1cc/ash/public/interfaces/wallpaper_struct_traits.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/shell.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/shell.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/wallpaper/test_wallpaper_delegate.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/wallpaper/wallpaper_controller_test_api.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/extensions/wallpaper_function_base.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/components/wallpaper/BUILD.gn
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/components/wallpaper/DEPS
[add] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/components/wallpaper/wallpaper_info.h
[delete] https://crrev.com/b798035b8d14e5539648ba3a984ac8495d2bf1cc/components/wallpaper/wallpaper_layout.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/components/wallpaper/wallpaper_manager_base.h
[modify] https://crrev.com/56c29293574857438baf4215bb3a9d2df9751afe/components/wallpaper/wallpaper_resizer.h
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d22b5bcac4924cbec8890cdb0ad0b235b42faa6

commit 3d22b5bcac4924cbec8890cdb0ad0b235b42faa6
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Aug 08 01:37:01 2017

Let |WallpaperController| handle wallpaper dimming and blur

Wallpaper dimming and blur should be applied at the same time when the
wallpaper is being set to avoid two types of delays: the delay during
login screen startup, and the delay (inconsistent timing) when
tabbing through focused user pods at login screen (because the
wallpaper of the focused pod is shown at login screen).

There's a follow-up CL that cleans the existing HTML-based wallpaper
dimming.

Bug:  733409 , 751248
Change-Id: Ifc19751e28d6e7bf5d500423e83b57874025a20f
Reviewed-on: https://chromium-review.googlesource.com/598938
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492496}
[modify] https://crrev.com/3d22b5bcac4924cbec8890cdb0ad0b235b42faa6/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/3d22b5bcac4924cbec8890cdb0ad0b235b42faa6/ash/wallpaper/wallpaper_view.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1edb4084e3addad1c93100372f4d5b1e78c02228

commit 1edb4084e3addad1c93100372f4d5b1e78c02228
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Aug 08 01:51:23 2017

Remove HTML-based dimming and use of ScreenDimmer at login/lock/OOBE

This is a follow-up to change 598938. Several notes:

1) |LockScreen::ToggleBlur()| is changed to be used for debugging
purpose only, because wallpaper dimming and blur is handled as a whole
by |WallpaperController| now.

2) In oobe_ui.cc, the reference to crbug.com/646034 is deleted because
we don't need extra dimming for e.g. GAIA screen once the wallpaper
dimming is in place. But that bug is still relevant for use cases
where dimming within an active user session is needed.

3) In oobe_ui.cc, |hideOobeShield| is deleted. It was used to hide
OOBE shield in an active user session but it's no longer needed now
because there will not be dimming during active user session.

Bug:  733409 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I826fff9f20dba97722050f8cd72865262c0a671d
Reviewed-on: https://chromium-review.googlesource.com/599022
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492500}
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/ash/login/ui/lock_screen.h
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/chrome/browser/resources/chromeos/login/md_login_shared.js
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/chrome/browser/resources/chromeos/login/md_screen_container.html
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/chrome/browser/resources/chromeos/login/screen_container.html
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/ui/login/account_picker/md_screen_account_picker.js
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/ui/login/md_screen_container.css
[modify] https://crrev.com/1edb4084e3addad1c93100372f4d5b1e78c02228/ui/login/screen_container.css
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4453f97cff08badd9f521534fff4b1931afb92f6

commit 4453f97cff08badd9f521534fff4b1931afb92f6
Author: James Cook <jamescook@chromium.org>
Date: Tue Aug 08 16:39:50 2017

Revert "Let |WallpaperController| handle wallpaper dimming and blur"

This reverts commit 3d22b5bcac4924cbec8890cdb0ad0b235b42faa6.

Reason for revert:

Causes startup crashes (NOTREACHED) in release-with-dchecks builds (and probably debug builds too) if you run with --login manager

out/Default/chrome --user-data-dir=/w/udd --login-manager

[103521:103521:0808/093710.451744:FATAL:wallpaper_controller.cc(417)] Check failed: false. 
#0 0x7f343e518d7c base::debug::StackTrace::StackTrace()
#1 0x7f343e53e5ec logging::LogMessage::~LogMessage()
#2 0x7f34392e5386 ash::WallpaperController::InstallDesktopController()
#3 0x7f34392e543b ash::WallpaperController::OnSessionStateChanged()
#4 0x7f34392396c8 ash::SessionController::SetSessionState()
#5 0x7f3439239606 ash::SessionController::SetSessionInfo()
#6 0x7f3438ded08a ash::mojom::SessionControllerStubDispatch::Accept()
#7 0x7f343d81660b mojo::InterfaceEndpointClient::HandleValidatedMessage()
#8 0x7f343d815f36 mojo::FilterChain::Accept()

Original change's description:
> Let |WallpaperController| handle wallpaper dimming and blur
> 
> Wallpaper dimming and blur should be applied at the same time when the
> wallpaper is being set to avoid two types of delays: the delay during
> login screen startup, and the delay (inconsistent timing) when
> tabbing through focused user pods at login screen (because the
> wallpaper of the focused pod is shown at login screen).
> 
> There's a follow-up CL that cleans the existing HTML-based wallpaper
> dimming.
> 
> Bug:  733409 , 751248
> Change-Id: Ifc19751e28d6e7bf5d500423e83b57874025a20f
> Reviewed-on: https://chromium-review.googlesource.com/598938
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Reviewed-by: Biao She <bshe@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492496}

TBR=reveman@chromium.org,bshe@chromium.org,wzang@chromium.org

Change-Id: Id290f1e91324e7bdf656a3bfd2f426f9e9946d2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  733409 , 751248
Reviewed-on: https://chromium-review.googlesource.com/605988
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492655}
[modify] https://crrev.com/4453f97cff08badd9f521534fff4b1931afb92f6/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/4453f97cff08badd9f521534fff4b1931afb92f6/ash/wallpaper/wallpaper_view.cc
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8857bf3b85740531e81f105b491d12fa7e7c9d

commit 8a8857bf3b85740531e81f105b491d12fa7e7c9d
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Aug 08 23:26:31 2017

Reland "Let |WallpaperController| handle wallpaper dimming and blur"

In addition to the original description of 598938, add the checks for:

1) Wallpaper mode check, which must be WALLPAPER_IMAGE (consistent
with the other places calling InstallDesktopControllerForAllWindows())

2) Dimming and blur should only be reset for three out of the seven
session states.

TBR=bshe@chromium.org

Bug:  733409 , 751248
Change-Id: I20a6183f831caf9b53c351b2e09e4a14ee028414
Reviewed-on: https://chromium-review.googlesource.com/606995
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492772}
[modify] https://crrev.com/8a8857bf3b85740531e81f105b491d12fa7e7c9d/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/8a8857bf3b85740531e81f105b491d12fa7e7c9d/ash/wallpaper/wallpaper_view.cc

Comment 27 by wzang@chromium.org, Aug 9 2017

Labels: Merge-Request-61
Status: Fixed (was: Assigned)

Comment 28 by keta...@chromium.org, Aug 9 2017

Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 29 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/810c5a28e18e3831911df6fb01efe1cac34e49cf

commit 810c5a28e18e3831911df6fb01efe1cac34e49cf
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Aug 10 01:19:01 2017

Move all login screen related constants to a separate file

Login/lock screen related constants may be used from at least three
places: views-based lock, WebUi based login/lock and wallpaper. So
we want to move them together just as shelf_constants.h

TBR=wzang@chromium.org

(cherry picked from commit eb86464a8cb4944b52be8572fbf7e7e1387381c1)

Bug:  732566 ,  733409 
Change-Id: I791d5dfbd02f35cdcc6064b964b97b6978a376d2
Reviewed-on: https://chromium-review.googlesource.com/590483
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491196}
Reviewed-on: https://chromium-review.googlesource.com/609546
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#425}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/ash/BUILD.gn
[modify] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/ash/login/ui/lock_screen.cc
[add] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/ash/login/ui/login_constants.h
[modify] https://crrev.com/810c5a28e18e3831911df6fb01efe1cac34e49cf/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Comment 30 by wzang@chromium.org, Aug 10 2017

Blockedon: 750260
Project Member

Comment 31 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04cb57fe4280e37aca37e18de4a7832774f51112

commit 04cb57fe4280e37aca37e18de4a7832774f51112
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Aug 10 18:25:09 2017

Re-land of Add Wallpaper Color Caching and skip prefs reading under MASH

After offline discussion with jamescook@, the prefs reading is skipped
in the case of config::MASH until  crbug.com/751143  is fixed.

This CL combines https://chromium-review.googlesource.com/c/572144 and
https://chromium-review.googlesource.com/c/595123. TBR because the
entire CL has been reviewed.

Please note there's another CL
(https://chromium-review.googlesource.com/c/592228)
depending on this one. (specifically, Shell::RegisterLocalStatePrefs)

TBR=bshe@chromium.org, derat@chromium.org, jamescook@chromium.org, wzang@chromium.org
lhchavez@chromium.org,xdai@chromium.org,ochang@chromium.org

(cherry picked from commit 56c29293574857438baf4215bb3a9d2df9751afe)

Bug:  733409 
Change-Id: Ibeb260c94a174819322121efe12c2865f5df78c7
Reviewed-on: https://chromium-review.googlesource.com/596801
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491271}
Reviewed-on: https://chromium-review.googlesource.com/610896
Cr-Commit-Position: refs/branch-heads/3163@{#442}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/mus/wallpaper_delegate_mus.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/public/cpp/ash_pref_names.h
[add] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/public/cpp/wallpaper_struct_traits.cc
[add] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/public/cpp/wallpaper_struct_traits.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/public/interfaces/wallpaper.typemap
[delete] https://crrev.com/4b7dadb389a2460867d2bbd3ab4370b9b532c4d1/ash/public/interfaces/wallpaper_struct_traits.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/shell.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/shell.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/wallpaper/test_wallpaper_delegate.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/wallpaper/wallpaper_controller_test_api.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/extensions/wallpaper_function_base.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/components/wallpaper/BUILD.gn
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/components/wallpaper/DEPS
[add] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/components/wallpaper/wallpaper_info.h
[delete] https://crrev.com/4b7dadb389a2460867d2bbd3ab4370b9b532c4d1/components/wallpaper/wallpaper_layout.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/components/wallpaper/wallpaper_manager_base.h
[modify] https://crrev.com/04cb57fe4280e37aca37e18de4a7832774f51112/components/wallpaper/wallpaper_resizer.h
Project Member

Comment 32 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4adf9863caa63ae9880418f7d0b05c9088d80c37

commit 4adf9863caa63ae9880418f7d0b05c9088d80c37
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Aug 10 18:41:46 2017

Remove HTML-based dimming and use of ScreenDimmer at login/lock/OOBE

This is a follow-up to change 598938. Several notes:

1) |LockScreen::ToggleBlur()| is changed to be used for debugging
purpose only, because wallpaper dimming and blur is handled as a whole
by |WallpaperController| now.

2) In oobe_ui.cc, the reference to crbug.com/646034 is deleted because
we don't need extra dimming for e.g. GAIA screen once the wallpaper
dimming is in place. But that bug is still relevant for use cases
where dimming within an active user session is needed.

3) In oobe_ui.cc, |hideOobeShield| is deleted. It was used to hide
OOBE shield in an active user session but it's no longer needed now
because there will not be dimming during active user session.

TBR=wzang@chromium.org

(cherry picked from commit 1edb4084e3addad1c93100372f4d5b1e78c02228)

Bug:  733409 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I826fff9f20dba97722050f8cd72865262c0a671d
Reviewed-on: https://chromium-review.googlesource.com/599022
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492500}
Reviewed-on: https://chromium-review.googlesource.com/610928
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#446}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/ash/login/ui/lock_screen.h
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/chrome/browser/resources/chromeos/login/md_login_shared.js
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/chrome/browser/resources/chromeos/login/md_screen_container.html
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/chrome/browser/resources/chromeos/login/screen_container.html
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/ui/login/account_picker/md_screen_account_picker.js
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/ui/login/md_screen_container.css
[modify] https://crrev.com/4adf9863caa63ae9880418f7d0b05c9088d80c37/ui/login/screen_container.css
Project Member

Comment 33 by bugdroid1@chromium.org, Aug 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c29dfad51b0563a829b845021aa85732bf4dbd

commit 32c29dfad51b0563a829b845021aa85732bf4dbd
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Aug 10 18:47:00 2017

Reland "Let |WallpaperController| handle wallpaper dimming and blur"

In addition to the original description of 598938, add the checks for:

1) Wallpaper mode check, which must be WALLPAPER_IMAGE (consistent
with the other places calling InstallDesktopControllerForAllWindows())

2) Dimming and blur should only be reset for three out of the seven
session states.

TBR=bshe@chromium.org, wzang@chromium.org

(cherry picked from commit 8a8857bf3b85740531e81f105b491d12fa7e7c9d)

Bug:  733409 , 751248
Change-Id: I20a6183f831caf9b53c351b2e09e4a14ee028414
Reviewed-on: https://chromium-review.googlesource.com/606995
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492772}
Reviewed-on: https://chromium-review.googlesource.com/610934
Cr-Commit-Position: refs/branch-heads/3163@{#448}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/32c29dfad51b0563a829b845021aa85732bf4dbd/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/32c29dfad51b0563a829b845021aa85732bf4dbd/ash/wallpaper/wallpaper_view.cc

Comment 34 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment