New issue
Advanced search Search tips

Issue 733393 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add chrome://flag control for features::kBrowserTouchBar

Project Member Reported by thakis@chromium.org, Jun 14 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408bddbca79a0709ec2daa97872426c39bfe04b7

commit 408bddbca79a0709ec2daa97872426c39bfe04b7
Author: elawrence <elawrence@chromium.org>
Date: Thu Jun 15 16:08:03 2017

Add chrome://flag control for features::kBrowserTouchBar

Previously, the features::kBrowserTouchBar was not controllable from the
chrome://flags page. Now it is.

BUG= 733393 

Review-Url: https://codereview.chromium.org/2936273002
Cr-Commit-Position: refs/heads/master@{#479728}

[modify] https://crrev.com/408bddbca79a0709ec2daa97872426c39bfe04b7/chrome/browser/about_flags.cc
[modify] https://crrev.com/408bddbca79a0709ec2daa97872426c39bfe04b7/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/408bddbca79a0709ec2daa97872426c39bfe04b7/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/408bddbca79a0709ec2daa97872426c39bfe04b7/tools/metrics/histograms/enums.xml

Comment 2 by thakis@chromium.org, Jun 15 2017

Labels: M-60 Merge-Request-60
Could we merge this to m60? Someone asked for this. It's only for power users, so if it's late in the cycle, it's ok to wait. On the other hand, it just adds a flag to about:flags, so it's also close to zero risk.
Status: Fixed (was: Started)

Comment 4 by thakis@chromium.org, Jun 15 2017

Status: Started (was: Fixed)
Back to started for merge request

Comment 5 by thakis@chromium.org, Jun 16 2017

Labels: ReleaseBlock-Beta
Trying to trigger the merge bot
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 16 2017

Labels: -Merge-Request-60 Merge-Reject-60 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by thakis@chromium.org, Jun 16 2017

Status: Fixed (was: Started)
Alright, sounds like auto-merge bot says no. Oh well.
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue on Mac 10.12.5 with chrome #61.0.3135.4

Observed under "chrome://flags", #mac-touchbar is available.

Attaching the screenshot for reference.

thakis@ could you confirm this is the expected behavior of this fix.

Thank You...
Issue 733393.png
70.4 KB View Download
Labels: TE-Verified-61.0.3135.4
Verified in Dev- 61.0.3135.4 as per #8

Sign in to add a comment