New issue
Advanced search Search tips

Issue 733382 link

Starred by 2 users
Status: Fixed
Owner:
kpaulhamus@chromium.org
Closed: Jun 2017
Cc:
battre@chromium.org
vasi...@chromium.org
jdoerrie@chromium.org
kenrb@chromium.org
martinkr@google.com
engedy@chromium.org
ssoneff@google.com
kpaulhamus@chromium.org
mknowles@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 733029



Sign in to add a comment

Refactor CredentialUserData out of CredentialMangement API's Credential/WebCredential

Project Member Reported by kpaulhamus@chromium.org, Jun 14 2017 
The CM spec says that "Some Credential objects contain data which aims to give users a human-readable disambiguation mechanism". Prior to WebAuthN merging with the CM API, all the credential objects used CredentialUserData, but PublicKeyCredentials do not. CredentialUserData should be refactored out so PublicKeyCredential can extend Credential.

Comment 1 by kpaulhamus@chromium.org, Jun 14 2017

Blocking: 733029

Comment 2 by kpaulhamus@chromium.org, Jun 27 2017

Owner: kpaulhamus@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185

commit ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Wed Jun 28 13:52:52 2017

Refactor CredentialUserData out of [Web|Platform]Credential types

This permits the addition of PublicKeyCredential (which does not use CredentialUserData) to the CM API.

Bug:  733382 
Change-Id: I0a75bbb7361b66fc870c9db77341871fc3c67b9c
Reviewed-on: https://chromium-review.googlesource.com/549398
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482972}
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/components/password_manager/content/renderer/credential_manager_client.cc
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/credentialmanager/BUILD.gn
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/credentialmanager/Credential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/credentialmanager/Credential.h
[delete] https://crrev.com/d0d0b4672112b1fd870acc7c86496c46cfca168d/third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.cpp
[delete] https://crrev.com/d0d0b4672112b1fd870acc7c86496c46cfca168d/third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/credentialmanager/PlatformCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/credentialmanager/PlatformCredential.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/credentialmanager/PlatformFederatedCredential.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/credentialmanager/PlatformPasswordCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/credentialmanager/PlatformPasswordCredential.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/exported/WebCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/exported/WebFederatedCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/Source/platform/exported/WebPasswordCredential.cpp
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/public/platform/WebCredential.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/public/platform/WebFederatedCredential.h
[modify] https://crrev.com/ecb181bc0aaaeb7cb1533e6a2e5ffc785c20a185/third_party/WebKit/public/platform/WebPasswordCredential.h

Comment 4 by kpaulhamus@chromium.org, Jun 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment