Deprecate and remove Presentation API on insecure contexts |
|||||||||||||||||||||||||
Issue description
,
Jun 20 2017
,
Jul 17 2017
,
Jul 17 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7bed1a66272ec2f816f63d8789ed4e5025f9910 commit f7bed1a66272ec2f816f63d8789ed4e5025f9910 Author: mark a. foltz <mfoltz@chromium.org> Date: Fri Jul 21 16:50:26 2017 [Presentation API] Deprecate on insecure contexts. - Adds UseCounters to count presentations started on secure/insecure origins. - Logs a deprecation warning only when presentations are started, because of the warning frequency on PresentationRequest constructor or getAvailability. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion Bug: 733381 Change-Id: I4352b2b9d3e887ade122bb8efb6e9a8efcbfd874 Reviewed-on: https://chromium-review.googlesource.com/578687 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#488681} [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/third_party/WebKit/Source/modules/presentation/PresentationController.cpp [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/third_party/WebKit/Source/modules/presentation/PresentationRequest.h [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/third_party/WebKit/public/platform/web_feature.mojom [modify] https://crrev.com/f7bed1a66272ec2f816f63d8789ed4e5025f9910/tools/metrics/histograms/enums.xml
,
Jul 24 2017
,
Jul 24 2017
This just missed the branch cut-off and is a pretty safe change (adding a deprecation warning).
,
Jul 24 2017
Pls apply appropriate OSs. Thank you.
,
Jul 24 2017
,
Jul 25 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b commit 5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b Author: mark a. foltz <mfoltz@chromium.org> Date: Tue Jul 25 21:17:54 2017 [Presentation API] Deprecate on insecure contexts. - Adds UseCounters to count presentations started on secure/insecure origins. - Logs a deprecation warning only when presentations are started, because of the warning frequency on PresentationRequest constructor or getAvailability. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion TBR=mfoltz@chromium.org (cherry picked from commit f7bed1a66272ec2f816f63d8789ed4e5025f9910) Bug: 733381 Change-Id: I4352b2b9d3e887ade122bb8efb6e9a8efcbfd874 Reviewed-on: https://chromium-review.googlesource.com/578687 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488681} Reviewed-on: https://chromium-review.googlesource.com/585612 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#37} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/third_party/WebKit/Source/modules/presentation/PresentationRequest.h [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/third_party/WebKit/public/platform/web_feature.mojom [modify] https://crrev.com/5bd0b7cdf8d4a6e613b5d02fb04a7dca5ae3d96b/tools/metrics/histograms/enums.xml
,
Aug 14 2017
,
Sep 12 2017
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues. We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate. For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit For any questions, please contact owencm, sshruthi, larforge
,
Mar 3 2018
,
Jun 13 2018
,
Jun 13 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74f78d2d805f32d49b0672d361f07675d15e0835 commit 74f78d2d805f32d49b0672d361f07675d15e0835 Author: mark a. foltz <mfoltz@chromium.org> Date: Fri Jun 15 18:46:46 2018 [Presentation API] Update removal milestone on secure contexts Presentation API was not removed from insecure contexts on M68. Update removal milestone to Q4 until more proactive engagement can be done with remaining Cast-enabled sites on http. Bug: 733381 Change-Id: Ic035ffcbbb7a510fea158fbc70457ba286dece01 Reviewed-on: https://chromium-review.googlesource.com/1100103 Reviewed-by: Derek Cheng <imcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567748} [modify] https://crrev.com/74f78d2d805f32d49b0672d361f07675d15e0835/third_party/blink/renderer/core/frame/deprecation.cc
,
Oct 26
,
Oct 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2deb504d8ec1e8ac387e0fe52b53614e21ff4e6 commit f2deb504d8ec1e8ac387e0fe52b53614e21ff4e6 Author: mark a. foltz <mfoltz@chromium.org> Date: Sun Oct 28 00:22:54 2018 [Presentation API] Advance removal milestone for insecure contexts. Advance the removal milestone for the Presentation API on insecure contexts from M71 to M72. We have gotten the OK to remove in M72. BUG= 733381 Change-Id: I03676e1f7efb0a0200c7b7cf537c57a4504074de Reviewed-on: https://chromium-review.googlesource.com/c/1293187 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#603354} [modify] https://crrev.com/f2deb504d8ec1e8ac387e0fe52b53614e21ff4e6/third_party/blink/renderer/core/frame/deprecation.cc
,
Oct 29
Requesting merge of https://chromium-review.googlesource.com/c/1293187. This is a two-line change to update the removal milestone message for the Presentation API. I have verified the correct message is logged in 72.0.3595.0.
,
Oct 29
This bug requires manual review: We don't branch M72 until 2018-11-29. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
Added wrong label; meant Merge-Request-M71
,
Oct 29
The bug is marked as P3 or Feature. It should not be merged as M71 is in beta. Please contact the approriate milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
Bumping to P2 and re-requesting merge. Rationale: Previously we were unsure of the milestone for removal. Now that we have a target milestone, we can mark this P2. It's also a "bug" that this is available on insecure contexts.
,
Oct 29
Argh. No need to restrict to security team though.
,
Oct 29
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
Approving merge for https://chromium-review.googlesource.com/c/1293187 to M71 branch 3578 based on comments #20 and #24. Please merge ASAP so we can pick it up for this week beta. Thank you.
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ff6d7f3e536f1da50fdc637835eda3ddf7a7967 Commit: 4ff6d7f3e536f1da50fdc637835eda3ddf7a7967 Author: mfoltz@chromium.org Commiter: mfoltz@chromium.org Date: 2018-10-29 23:08:26 +0000 UTC [Presentation API] Advance removal milestone for insecure contexts. Advance the removal milestone for the Presentation API on insecure contexts from M71 to M72. We have gotten the OK to remove in M72. BUG= 733381 Change-Id: I03676e1f7efb0a0200c7b7cf537c57a4504074de Reviewed-on: https://chromium-review.googlesource.com/c/1293187 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603354}(cherry picked from commit f2deb504d8ec1e8ac387e0fe52b53614e21ff4e6) Reviewed-on: https://chromium-review.googlesource.com/c/1306636 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#379} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ff6d7f3e536f1da50fdc637835eda3ddf7a7967 commit 4ff6d7f3e536f1da50fdc637835eda3ddf7a7967 Author: mark a. foltz <mfoltz@chromium.org> Date: Mon Oct 29 23:08:26 2018 [Presentation API] Advance removal milestone for insecure contexts. Advance the removal milestone for the Presentation API on insecure contexts from M71 to M72. We have gotten the OK to remove in M72. BUG= 733381 Change-Id: I03676e1f7efb0a0200c7b7cf537c57a4504074de Reviewed-on: https://chromium-review.googlesource.com/c/1293187 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#603354}(cherry picked from commit f2deb504d8ec1e8ac387e0fe52b53614e21ff4e6) Reviewed-on: https://chromium-review.googlesource.com/c/1306636 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#379} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/4ff6d7f3e536f1da50fdc637835eda3ddf7a7967/third_party/blink/renderer/core/frame/deprecation.cc
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/592f6faa792259bb3515fea429699c3e126a143e commit 592f6faa792259bb3515fea429699c3e126a143e Author: mark a. foltz <mfoltz@chromium.org> Date: Thu Nov 01 17:10:08 2018 [Presentation API] Remove from insecure contexts. This patch removes the Presentation API from insecure contexts. The number of presentations started on insecure contexts is 0.0001% of page views on desktop and 0.0004 on Android. In addition it updates layout tests and WPT to use https: for presentation URLs. Blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/lumj0lVdtHA/discussion chromestatus.com feature entry: https://www.chromestatus.com/feature/5766218384408576 Bug: 733381 Change-Id: I9ae3025160b0e0bcf987fda0068a0e6bd92c24fd Reviewed-on: https://chromium-review.googlesource.com/c/1306336 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604621} [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/WebKit/LayoutTests/external/wpt/presentation-api/controlling-ua/PresentationRequest_error.https.html [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/WebKit/LayoutTests/presentation/presentation-onreceiverconnection.html [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/WebKit/LayoutTests/presentation/presentation-start-error.html [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/WebKit/LayoutTests/presentation/presentation-start.html [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/WebKit/LayoutTests/presentation/presentationrequest-gc.html [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-close-connection.html [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-postmessage.html [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/navigator_presentation.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_availability.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_connection.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_connection_available_event.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_connection_close_event.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_connection_list.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_controller.cc [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_controller.h [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_receiver.idl [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_receiver_test.cc [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_request.cc [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_request.h [modify] https://crrev.com/592f6faa792259bb3515fea429699c3e126a143e/third_party/blink/renderer/modules/presentation/presentation_request.idl
,
Nov 2
There is a little bit of cleanup work to remove obsolete deprecation messages/counters. Otherwise the removal is complete. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Jun 14 2017