New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733376 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Only one VPN shown in chrome://settings page.

Project Member Reported by aashuto...@chromium.org, Jun 14 2017

Issue description

Chrome Version: <From about:version: Google Chrome 61.0.3129.0>
Chrome OS Version: <From about:version: Platform 9647.0.0>
Chrome OS Platform: <Caroline>
Network info: <WiFi>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Go to chrome://settings/networks?type=VPN

Expected Result:
All configured VPN's should show up in chrome://settings page. 

Actual Result:
Only one VPN is visible under chrome://settings page. 

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always


Please provide any additional information below. Attach a screen shot or
log if possible.
Screenshot attached. 

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Screenshot.png
165 KB View Download
Labels: -Type-Bug -Pri-3 ReleaseBlock-Stable M-61 Pri-2 Type-Bug-Regression

Comment 2 by zalcorn@google.com, Jun 23 2017

Status: Assigned (was: Untriaged)
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Summary: Only one VPN shown in chrome://settings page. (was: VPN pushed via policy not visible under chrome://settings page. )
This is not specific to policy related VPNs, it is a regression in 61 only that I introduced here:
https://codereview.chromium.org/2913323003/diff/160001/chrome/browser/resources/settings/internet_page/internet_subpage.js

Fixing this now.

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3ffa5f9c0f6c2cb7405fdfb09d3b59801caf250

commit c3ffa5f9c0f6c2cb7405fdfb09d3b59801caf250
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Jun 26 23:23:33 2017

Settings: Network: Fix logic building VPN list from Tether merge.

Incorrect nesting introduced a bug in this CL:
https://codereview.chromium.org/2913323003

This fixes that bug.

BUG= 733376 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2963453002
Cr-Commit-Position: refs/heads/master@{#482454}

[modify] https://crrev.com/c3ffa5f9c0f6c2cb7405fdfb09d3b59801caf250/chrome/browser/resources/settings/internet_page/internet_subpage.js

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment