New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733372 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: charger: bd9995x: Check usb_charger_task sleep logic

Project Member Reported by sha...@chromium.org, Jun 14 2017

Issue description

*** CID 170452:  Control flow issues  (DEADCODE)
/driver/charger/bd9995x.c: 1203 in usb_charger_task()
1197                             */
1198                            if (bc12_det_mark[port]) {
1199                                    int bc12_wait_usec;
1200
1201                                    bc12_wait_usec = bc12_det_mark[port]
1202                                            - get_time().val;
>>>     CID 170452:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "sleep_usec > bc12_wait_usec" inside this statement: "if (sleep_usec < 0 || sleep...".
1203                                    if ((sleep_usec < 0) ||
1204                                        (sleep_usec > bc12_wait_usec))
1205                                            sleep_usec = bc12_wait_usec;
1206                            }
1207                    }
1208
 

Comment 1 by sha...@chromium.org, Jun 14 2017

Additional comments posted on original code review:

https://chromium-review.googlesource.com/#/c/487028/

Comment 2 by sha...@chromium.org, Oct 23 2017

Status: WontFix (was: Untriaged)

Sign in to add a comment