New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733369 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

create a slowest-pre-cq-config metric

Project Member Reported by akes...@chromium.org, Jun 14 2017

Issue description

pre-cq time is starting to become a significant fraction of CL handling time.

Taking inspiration from our last-slave metric for CQ runs http://shortn/_gIpD1MljbK 
 from  Issue 708728 , we should add a slowest-pre-cq metric as well, computed and emitted on a per-CL basis at submission time. 
 
It might be worth doing some sample CL testing. I suspect there is something causing PreCQ builds to be picked up very slowly, but have no idea what yet.

I have a metrics CL out for review that will let us see how busy the PreCQ builders pool is, but that's only one potential cause for this kind of delay.


Um... sample CL testing means select a small number and roughly timeline out what happens when.

You should be able to construct a pretty complete picture from the clActionTable entries for a given CL.
Owner: dgarr...@chromium.org
-> dgarrett@ is looking at pre-cq timeline for CLs at the moment.
Picking a random CL (mine):

https://chromium-review.googlesource.com/#/c/536353/

Gerrit flags set:           17:06
Launcher launches builders: 17:11:50
All builder launch:         ~17:12
cbuildbot:                   17:15 to 17:20
CL comment w build links:    17:24

The gap between setting flags in gerrit and the launcher scheduling PreCQ builds is 6 minutes. One sample builder took about 1 minute to launch, and 2.5 minutes to get through the build startup.

That's ~9.5 minutes from flags set to cbuildbot reached on the PreCQ builder. But on the CL, it took 24 minutes before the build links were added to the CL.

The slowest starting slave took 6 minutes to perform it's initial repo sync.

https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/no_vmtest_pre_cq/58875

Status: Assigned (was: Untriaged)
Removing from triage queue.
Status: fix (was: Assigned)
Status: Fixed (was: Fix)
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS

Sign in to add a comment