New issue
Advanced search Search tips

Issue 733366 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Googler PreStable] - Can't expand hidden sections of Wikipedia page when page is downloaded for offline mode

Project Member Reported by jainabhi...@chromium.org, Jun 14 2017

Issue description

Report : feedback/#/Report/65398077671

Description:
Can't expand hidden sections of Wikipedia page when page is downloaded for offline mode
URL: https://en.m.wikipedia.org/wiki/Sol_Invictus

UI language:
en_US

Version:
59.0.3071.92 (Currently at 2% rollout)

Device Model:
F5321

Device Release:
7.0

App Version:
59.0.3071.92

Product Specific Data (whitelisted):
Chrome Variations:  3300134 3313275 3313321 
Connection check elapsed (ms): 100
Connection type: NONE
Data Reduction Proxy Enabled: true
HTTP connection check (Android network stack): NOT_CONNECTED
HTTP connection check (Chrome network stack): NOT_CONNECTED
HTTPS connection check (Android network stack): NOT_CONNECTED
HTTPS connection check (Chrome network stack): NOT_CONNECTED

com.google.android.webview: VersionCode:292408750;VersionName:56.0.2924.87
 

Comment 1 by dim...@chromium.org, Jun 28 2017

Labels: -Pri-1 Pri-2
Owner: petewil@chromium.org
Status: Assigned (was: Untriaged)
Pete, this sounds familiar. Assigning to you for tracking.

ConOps: reducing pri to 2, we are currently working on a project that will fix this exact issue, and some others.

Owner: collinbaker@google.com
Cc: -hongchic...@chromium.org
Owner: petewil@chromium.org
Assigning back to Pete since my internship is ending soon.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17ab538d31b7a6225bee73c6fe69873a6362ae54

commit 17ab538d31b7a6225bee73c6fe69873a6362ae54
Author: Collin Baker <collinbaker@google.com>
Date: Sat Aug 05 01:10:32 2017

[Offline pages] Add page renovation for mobile Wikipedia.

Adds a renovation that unfolds sections and forces images to load for
mobile Wikipedia pages. This is part of the renovation framework for
Offline Pages that runs scripts in pages before snapshotting to
prepare them for offline viewing.

Design doc:
https://docs.google.com/document/d/1WuwRJaxBKAwVpeAHG0xhq5uRxMTB-j4LFleT4QEqANU

Bug: 736933, 733366
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I34e4ec97be79ecc43de3519f8e47a489e2732744
Reviewed-on: https://chromium-review.googlesource.com/592347
Commit-Queue: Collin Baker <collinbaker@google.com>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492205}
[modify] https://crrev.com/17ab538d31b7a6225bee73c6fe69873a6362ae54/components/offline_pages/content/renovations/test/page_renovator_browsertest.cc
[modify] https://crrev.com/17ab538d31b7a6225bee73c6fe69873a6362ae54/components/offline_pages/core/renovations/page_renovation_loader.cc
[modify] https://crrev.com/17ab538d31b7a6225bee73c6fe69873a6362ae54/components/offline_pages/resources/renovations.js
[add] https://crrev.com/17ab538d31b7a6225bee73c6fe69873a6362ae54/components/test/data/offline_pages/wikipedia_renovation_test_page.html

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f19f1a8a96d3c47df346e26b14d12370adb2d35

commit 4f19f1a8a96d3c47df346e26b14d12370adb2d35
Author: Collin Baker <collinbaker@google.com>
Date: Tue Aug 08 23:49:12 2017

[Offline pages] Use renovations in background loader.

Integrates renovations into the background loader. Use of renovations
is hidden behind a feature flag. When enabled, the renovation
framework will select renovations to run in a page, then inject their
scripts into the page before snapshotting in the background
offliner. At this point, only a renovation for unfolding sections in
mobile Wikipedia pages is implemented.

Design doc:
https://docs.google.com/document/d/1WuwRJaxBKAwVpeAHG0xhq5uRxMTB-j4LFleT4QEqANU

Bug: 736933, 733366
Change-Id: Ia97c32341952f2fce8f5c5a9225e5dc2054c78b7
Reviewed-on: https://chromium-review.googlesource.com/595011
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492777}
[modify] https://crrev.com/4f19f1a8a96d3c47df346e26b14d12370adb2d35/chrome/browser/BUILD.gn
[modify] https://crrev.com/4f19f1a8a96d3c47df346e26b14d12370adb2d35/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/4f19f1a8a96d3c47df346e26b14d12370adb2d35/chrome/browser/offline_pages/background_loader_offliner.h

Issue 787340 has been merged into this issue.
This could potentially be fixed by crbug.com/736933

Sign in to add a comment