PopupTest#testPopupWindowsAppearWhenAllowed failing on chromium.linux/Android Tests |
|||||
Issue descriptionchrome_public_test_apk failing on chromium.linux/Android Tests Builders failed on: - Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests org.chromium.chrome.browser.PopupTest#testPopupWindowsAppearWhenAllowed junit.framework.AssertionFailedError: Criteria not met in allotted time. at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.assertTrue(Assert.java:20) at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) at org.chromium.chrome.browser.PopupTest.testPopupWindowsAppearWhenAllowed(PopupTest.java:134) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:59) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) at org.chromium.chrome.test.ChromeActivityTestRule$2.evaluate(ChromeActivityTestRule.java:66) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:135) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:36) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:3115) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
,
Jun 14 2017
,
Jun 23 2017
Seeing in Android 64 official bot on M60: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm_64/builds/1635/steps/Test%3A%20ChromePublicTest/logs/stdio
,
Jun 23 2017
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a6ac61fb81df39f7542b01aa2ac6486ac73b9b5 commit 0a6ac61fb81df39f7542b01aa2ac6486ac73b9b5 Author: Charles Harrison <csharrison@chromium.org> Date: Mon Oct 02 14:34:01 2017 Make flaky android popup test spawn fewer popups It is likely previous flakes were due to the test ending up opening 7 tabs, which is pretty heaviweight and could have caused the test to start running into slowdowns, causing timeouts. This patch reduces the popup count to 5 total popups, which doesn't really change the semantics of the test at all, but should be a bit lighter-weight. Bug: 733365 Change-Id: I9b8b364b1d1287d27ed64823303c7e794f088da5 Reviewed-on: https://chromium-review.googlesource.com/693640 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#505603} [modify] https://crrev.com/0a6ac61fb81df39f7542b01aa2ac6486ac73b9b5/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java [modify] https://crrev.com/0a6ac61fb81df39f7542b01aa2ac6486ac73b9b5/chrome/test/data/android/popup_test.html
,
Oct 2 2017
Tentatively marking as fixed. Certainly another bug will be filed if it flakes again. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jun 14 2017