1. The commit to be reverted should be just committed into the codebase in the last 24 hours. 2. The number of commits reverted in the past 24 hours should not be more than 4.
Findit should be able to create reverts without limit, but commit limit amount of reverts.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/97bc8d9b9a841800a7ba599a09732c3d99d4a144 commit 97bc8d9b9a841800a7ba599a09732c3d99d4a144 Author: Chan <chanli@chromium.org> Date: Fri Jul 28 22:21:41 2017 [Findit] Add config for auto_commit. (1/3) Auto commit change part 1 of 3. Added 3 new configs for auto_commit: commit_gerrit_revert: flag to control if Findit should auto commit gerrit reverts created by Findit. culprit_commit_limit_hours: Only when the culprit is committed within this limit will Findit auto commit it's revert. auto_commit_daily_threshold: Findit will only auto commit limit number of reverts every day. Bug: 733364 Change-Id: Ief8363373ad88aba5bd0371c446717645d709f10 Reviewed-on: https://chromium-review.googlesource.com/584860 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/97bc8d9b9a841800a7ba599a09732c3d99d4a144/appengine/findit/waterfall/test/waterfall_config_test.py [modify] https://crrev.com/97bc8d9b9a841800a7ba599a09732c3d99d4a144/appengine/findit/waterfall/test/wf_testcase.py [modify] https://crrev.com/97bc8d9b9a841800a7ba599a09732c3d99d4a144/appengine/findit/handlers/test/config_test.py [modify] https://crrev.com/97bc8d9b9a841800a7ba599a09732c3d99d4a144/appengine/findit/model/wf_config.py [modify] https://crrev.com/97bc8d9b9a841800a7ba599a09732c3d99d4a144/appengine/findit/handlers/config.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826 commit b2157d7e5c6533391ba0fc6e8b3bc19a489b6826 Author: Chan <chanli@chromium.org> Date: Mon Jul 31 22:36:30 2017 [Findit] Add Gerrit API to submit a revert. (2/3) Auto commit change part 2 of 3. Bug: 733364 Change-Id: Id342bbbbb56df1b2e268689bda9ff6254434d5f2 Reviewed-on: https://chromium-review.googlesource.com/585562 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/rietveld.py [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/gerrit.py [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/codereview.py [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/test/cl_info_test.py [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/cl_info.py [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py [modify] https://crrev.com/b2157d7e5c6533391ba0fc6e8b3bc19a489b6826/appengine/findit/infra_api_clients/codereview/codereview_util.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5d896e1f86f6da457cd237db8ca10f3e29523639 commit 5d896e1f86f6da457cd237db8ca10f3e29523639 Author: Chan <chanli@chromium.org> Date: Tue Aug 01 19:41:19 2017 [Findit] Add pipeline to auto commit reverts. (3/3) Auto commit change part 3 of 3. This is the implementation of pipeline to auto commit reverts which are: 1. Created by Findit 2. Revert culprits that are responsible for compile failures The pipeline is currently disabled waiting for changes at Gerrit side. This pipeline currently only commit revert if the culprit was comitted less than 24 hours. Bug: 733364 Change-Id: I484a2727346c5dbd88f8cc7d54fcacb7ee71240d Reviewed-on: https://chromium-review.googlesource.com/585610 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/5d896e1f86f6da457cd237db8ca10f3e29523639/appengine/findit/waterfall/create_revert_cl_pipeline.py [add] https://crrev.com/5d896e1f86f6da457cd237db8ca10f3e29523639/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py [add] https://crrev.com/5d896e1f86f6da457cd237db8ca10f3e29523639/appengine/findit/waterfall/submit_revert_cl_pipeline.py [modify] https://crrev.com/5d896e1f86f6da457cd237db8ca10f3e29523639/appengine/findit/waterfall/revert_and_notify_culprit_pipeline.py [modify] https://crrev.com/5d896e1f86f6da457cd237db8ca10f3e29523639/appengine/findit/model/base_suspected_cl.py [modify] https://crrev.com/5d896e1f86f6da457cd237db8ca10f3e29523639/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py [modify] https://crrev.com/5d896e1f86f6da457cd237db8ca10f3e29523639/appengine/findit/waterfall/test/revert_and_notify_culprit_pipeline_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0ada2d089aa2751baac701c061eb310907e27713 commit 0ada2d089aa2751baac701c061eb310907e27713 Author: Chan <chanli@chromium.org> Date: Thu Aug 10 21:12:20 2017 [Findit] Add config for daily threshold for auto reverted CLs. Bug: 733364 Change-Id: If08eceacc0987027d71f0701832ec6e090ac2d13 Reviewed-on: https://chromium-review.googlesource.com/602889 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/0ada2d089aa2751baac701c061eb310907e27713/appengine/findit/waterfall/test/waterfall_config_test.py [modify] https://crrev.com/0ada2d089aa2751baac701c061eb310907e27713/appengine/findit/waterfall/test/wf_testcase.py [modify] https://crrev.com/0ada2d089aa2751baac701c061eb310907e27713/appengine/findit/handlers/test/config_test.py [modify] https://crrev.com/0ada2d089aa2751baac701c061eb310907e27713/appengine/findit/model/wf_config.py [modify] https://crrev.com/0ada2d089aa2751baac701c061eb310907e27713/appengine/findit/handlers/config.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6eec92c37cc6c1e167fa1a8fb6ca0478e78d5d86 commit 6eec92c37cc6c1e167fa1a8fb6ca0478e78d5d86 Author: Chan <chanli@chromium.org> Date: Thu Aug 10 23:07:10 2017 [Findit] Add daily limits for auto_revert. No more than 10 creation of revert in the last 24 hours No more than 4 commits of revert in the last 24 hours Bug:733364 Change-Id: I5aa47b74857fc5882b2aeb3284858e77e2c8cb1b Reviewed-on: https://chromium-review.googlesource.com/602998 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/6eec92c37cc6c1e167fa1a8fb6ca0478e78d5d86/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/6eec92c37cc6c1e167fa1a8fb6ca0478e78d5d86/appengine/findit/waterfall/test/submit_revert_cl_pipeline_test.py [modify] https://crrev.com/6eec92c37cc6c1e167fa1a8fb6ca0478e78d5d86/appengine/findit/waterfall/submit_revert_cl_pipeline.py [modify] https://crrev.com/6eec92c37cc6c1e167fa1a8fb6ca0478e78d5d86/appengine/findit/model/base_suspected_cl.py [modify] https://crrev.com/6eec92c37cc6c1e167fa1a8fb6ca0478e78d5d86/appengine/findit/waterfall/test/create_revert_cl_pipeline_test.py
Comment 1 by chanli@chromium.org
, Jul 10 2017