New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733359 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 755193



Sign in to add a comment

kill_slow_queries should emit monarch counter of queries killed

Project Member Reported by akes...@chromium.org, Jun 14 2017

Issue description

kill_slow_queries emits emails when it kills queries. That's good because it tells us which queries were killed. That's a good start (if a bit spammy) but not as good for long term analysis as a monarch counter.

Also: currently, kill_slow_queries is a one-shot script that we run as a 5 minute repeating cronjob. From a ts_mon point of view, it would be cleaner if kill_slow_queries was a long running daemon which did this work in a loop (would prevent the need to use ts_mon short_lived=True


 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0bb62f4255a9c9f43ba53ce25600e5b1296d7ef1

commit 0bb62f4255a9c9f43ba53ce25600e5b1296d7ef1
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Sat Jun 24 05:56:43 2017

autotest: teach kill_slow_queries.py to periodically check database

Teach kill_slow_queries.py to periodically check the database and kill
slow queries. After this change, there will be an upstart job setup in
autotest db server to kill slow queries periodically.

BUG= chromium:733359 
TEST=None

Change-Id: I4673cadfa4f10d3c5a2710fc76a71ed86cf7a829
Reviewed-on: https://chromium-review.googlesource.com/544336
Commit-Ready: Shuqian Zhao <shuqianz@chromium.org>
Tested-by: Shuqian Zhao <shuqianz@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/0bb62f4255a9c9f43ba53ce25600e5b1296d7ef1/site_utils/kill_slow_queries.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/7c6ff4ef1b22a4bb5d0a1febd3c9d3adb79133fd

commit 7c6ff4ef1b22a4bb5d0a1febd3c9d3adb79133fd
Author: Shuqian Zhao <shuqianz@chromium.org>
Date: Wed Jun 28 16:49:05 2017

Blockedon: 755193
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/fcb79463a2d0e5810997b1b7f61de27e9d7b580a

commit fcb79463a2d0e5810997b1b7f61de27e9d7b580a
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Aug 15 18:09:45 2017

Status: Fixed (was: Started)

Sign in to add a comment