New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733352 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: cleanup: Remove motion sense data_t externs

Project Member Reported by sha...@chromium.org, Jun 14 2017

Issue description

Certain data_t structs (eg. struct bmi160_drv_data_t g_bmi160_data) are accessed through the drv_data pointer and no longer need to be declared extern in headers. The actual struct defined at board-level (usually) can also be declared static.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/89b8ff1cba1f6399f2990a418b9846fa54187c50

commit 89b8ff1cba1f6399f2990a418b9846fa54187c50
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Fri Jun 16 06:54:00 2017

cleanup: motion_sense: Remove driver data structure externs

Driver data structs are now accessed through the drv_data pointer.

BUG= chromium:733352 
BRANCH=None
TEST=`make buildall -j`

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: I8fedb425708a08ae6900ade6f17967fe2bc75ebf
Reviewed-on: https://chromium-review.googlesource.com/537217
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>

[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/accelgyro_bmi160.h
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/eve/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/als_si114x.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/poppy/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/baro_bmp280.h
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/coral/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/scarlet/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/rowan/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/nucleo-f411re/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/als_si114x.h
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/reef/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/wheatley/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/kevin/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/oak/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/ryu/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/glados/board.c

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/89b8ff1cba1f6399f2990a418b9846fa54187c50

commit 89b8ff1cba1f6399f2990a418b9846fa54187c50
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Fri Jun 16 06:54:00 2017

cleanup: motion_sense: Remove driver data structure externs

Driver data structs are now accessed through the drv_data pointer.

BUG= chromium:733352 
BRANCH=None
TEST=`make buildall -j`

Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Change-Id: I8fedb425708a08ae6900ade6f17967fe2bc75ebf
Reviewed-on: https://chromium-review.googlesource.com/537217
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>

[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/accelgyro_bmi160.h
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/eve/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/als_si114x.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/poppy/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/baro_bmp280.h
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/coral/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/scarlet/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/rowan/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/nucleo-f411re/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/driver/als_si114x.h
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/reef/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/wheatley/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/kevin/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/oak/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/ryu/board.c
[modify] https://crrev.com/89b8ff1cba1f6399f2990a418b9846fa54187c50/board/glados/board.c

Comment 3 by sha...@chromium.org, Jun 20 2017

Status: Verified (was: Untriaged)

Sign in to add a comment