New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733344 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature



Sign in to add a comment

Mac doesn't have a tab strip context menu

Project Member Reported by rkaplow@chromium.org, Jun 14 2017

Issue description

In linux when right clicking the tab strip but not on a tab gives a small context menu (open tab, open task manager). On Mac it does not do that - why? Is this intentional?


 
Summary: Mac doesn't have a tab strip context menu (was: Mac doesn't have a window context menu)
Labels: OS-Mac
Status: Untriaged (was: Available)
Marking Untriage so that this is picked up by Mac triage queue.

Basically, I don't see a reason for this to be inconsistent between platforms. So either Mac should add it, or it should be removed on other platforms. Probably easiest to just add it for Mac.

Is this something that will come automatically with Harmony - or is Harmony mostly for dialogs and tabstrip will keep using the Cocoa code? (Questions for Mac bug triage rotation.)
Components: -UI>Browser>Core UI>Browser>TabStrip

Comment 4 by tapted@chromium.org, Jun 15 2017

Cc: rpop@chromium.org shrike@chromium.org
This is probably WontFix. I believe this is the same menu that appears when you right-click the taskbar icon on Windows. It's standard OS behavior on Windows for the same menu to appear there as it does when clicking the top-left icon in the titlebar of a "normal" window.

Mac already does have a menu when you right-click the dock icon. But it would not be standard OS behaviour to show that menu when clicking anywhere on the titlebar.

This behaviour does not change when building with mac_views_browser = true.

cc some folks for opinions.
menu_titlebar.png
13.5 KB View Download
menu_taskbar.png
23.6 KB View Download
menu_dock.png
66.7 KB View Download
Just to clarify, I'm not sure we're talking about the same thing. The menu I'm tasking about is if (on Linux) you right click the tab strip. it looks like this:

This is not the menu you're showing in the examples. That menu appears (on Linux anyway) when  you right click the bar above the tabs, which is unrelated to this.



tabstrip.png
13.1 KB View Download

Comment 6 by tapted@chromium.org, Jun 16 2017

It's effectively the same thing, but it's confusing because it's not just Mac being inconsistent :)

- Linux shows: 
 - one menu when you right-click the title bar (depending on the `Use system title bar and borders` setting)
 - a second kind of menu when you right-click the tab strip
 - a third kind of menu when you right-click the shelf icon

- Windows shows the *same* menu when you right-click on all three of these places

- ChromeOS shows
 - one menu when you right-click the tab-strip/titlebar
 - a second menu when you right-click the shelf icon

- Mac shows
 - no menu when you right-click the tab-strip/titlebar
 - one menu when you right-click the dock icon
 - another, permanent menu at the top of the screen with all the options in the titlebar-right-click-menu it doesn't have


I don't really have an opinion on whether Mac should have another menu. And I've actually since noticed that Finder shows a couple of menus when right-clicking the titlebar, so maybe it wouldn't be weird for Mac to have this. But there's no way to make all the platforms consistent.

Comment 7 by tapted@chromium.org, Jun 16 2017

Labels: -Type-Bug Hotlist-GoodFirstBug Type-Feature
Status: Available (was: Untriaged)
[mac triage] Taking out of triage. Tagging this GoodFirstBug, but if someone wants to implement they should check with a PM.

Comment 8 by kkd927@gmail.com, Oct 27 2017

Hello! Can I start this issue?

Comment 9 by meh...@chromium.org, Oct 27 2017

Cc: rsesek@chromium.org
rsesek@: Can you support kkd927@ from comment 8 please. He wants to start this issue. Thank you!
The first step would be to check with shrike@ or rpop@ about whether we want to do this on Mac. If we do, then please follow the https://www.chromium.org/developers/contributing-code page for links on how to checkout/build and then put up a patch for code review.
Status: WontFix (was: Available)
I think this would be odd behavior on the Mac so WontFixing.

Sign in to add a comment