New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733313 link

Starred by 3 users
Status: Fixed
Owner:
dougt@chromium.org
Closed: Jul 2017
Cc:
dougt@chromium.org
█ nek...@chromium.org
█ rbenz@google.com
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Win acessibility: READONLY state missing, breaks screen reader virtual buffers

Project Member Reported by dmazz...@chromium.org, Jun 14 2017 
I’ve found the cause of no virtual buffer. The readonly state of the root node is not set and thus we think the document is editable and thus do not render it. Google has intentionally or unintentionally removed the readonly MSAA state from the root document object.
Please add back in the readonly state of the root document.

Comment 1 by dmazz...@chromium.org, Jun 14 2017 

Bisect leads to this change:

https://codereview.chromium.org/2913553002
"Forward BrowserAccessibility get_accState to AXPlatformNode"

Comment 2 by dmazz...@chromium.org, Jun 14 2017 

Revert is: https://codereview.chromium.org/2937083002/

See analysis of underlying issue in https://codereview.chromium.org/2913553002/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f29d6038c0a838d1eb2e94536634b6bc83a068b5

commit f29d6038c0a838d1eb2e94536634b6bc83a068b5
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Jun 14 18:27:55 2017

Revert of Forward BrowserAccessibility get_accState to AXPlatformNode. (patchset #5 id:80001 of https://codereview.chromium.org/2913553002/ )

Reason for revert:
READONLY state missing, breaks screen reader virtual buffers

Original issue's description:
> Forward BrowserAccessibility get_accState to AXPlatformNode.
>
> This is another migration from BrowserAccessibility to AXPlatformNodeWin.
> In this installment, we're converting get_accState. This one is mostly
> straightforward. The one gotcha is that there are some types that need
> to be explictly marked as focusable if they are selectable.
>
> BUG=703369
>
> Review-Url: https://codereview.chromium.org/2913553002
> Cr-Commit-Position: refs/heads/master@{#478110}
> Committed: https://chromium.googlesource.com/chromium/src/+/2396b649beff6d478edff6334af2305418cc3c45

TBR=dougt@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=703369, 733313 

Review-Url: https://codereview.chromium.org/2937083002
Cr-Commit-Position: refs/heads/master@{#479448}

[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_fake_caret_win.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_fake_caret_win.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/f29d6038c0a838d1eb2e94536634b6bc83a068b5/ui/views/accessibility/native_view_accessibility_base.h

Comment 4 by dmazz...@chromium.org, Jun 16 2017 

 Issue 732199  has been merged into this issue.

Comment 5 by dougt@chromium.org, Jul 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment