New issue
Advanced search Search tips

Issue 733309 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

hterm: touch scrolling is reversed

Project Member Reported by la...@chromium.org, Jun 14 2017

Issue description

When scrolling by touch in e.g. crosh, scrolling is reversed (moving my finger up makes the screen move down).
 

Comment 1 Deleted

Comment 2 by vapier@chromium.org, Jun 14 2017

the scroll direction should match the system touch scroll direction.  i.e. open a webpage with long content and compare the scrolling behavior there with hterm.

when i tested on my pixel, that's what i got.  do you not see that ?

Comment 3 by la...@chromium.org, Jun 14 2017

Nope, crosh is scrolling the opposite direction from any other content. This is ToT from yesterday on pyro.

Comment 4 by vapier@chromium.org, Jun 16 2017

Owner: vapier@chromium.org
Status: Started (was: Untriaged)
i might have compared touchpad to touchscreen when i did the pixel testing.  at any rate, testing on a cyan matches your report, so i'll invert it.

don't have a touchscreen to check Windows/macOS behavior.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/6aec411b14277693e99dcd490eb185b9052348c7

commit 6aec411b14277693e99dcd490eb185b9052348c7
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jun 16 18:31:23 2017

hterm: invert touchscreen scrolling

This makes the scrolling direction match scrolling other Chrome pages
via touchscreen rather than the touchpad.

BUG= chromium:733309 

Change-Id: Ifc23204c4f70f723adeb7e189f1c8cef6191a62a
Reviewed-on: https://chromium-review.googlesource.com/537963
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6aec411b14277693e99dcd490eb185b9052348c7/hterm/js/hterm_scrollport.js

Comment 6 by vapier@chromium.org, Jun 16 2017

Status: Fixed (was: Started)
this will be fixed with hterm-1.66+ and nassh-0.8.36.6+

Sign in to add a comment