New issue
Advanced search Search tips

Issue 733286 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

FindInPageControllerTest.SingleOccurrence failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by dalecur...@chromium.org, Jun 14 2017

Issue description

browser_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29


[ RUN      ] FindInPageControllerTest.SingleOccurrence
[6636:5532:0614/073551.661:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
c:\b\c\b\win\src\chrome\browser\ui\find_bar\find_bar_host_browsertest.cc(492): error:       Expected: first_rect
      Which is: 48,5922 482x90
To be equal to: second_rect
      Which is: 48,5915 482x90
[  FAILED  ] FindInPageControllerTest.SingleOccurrence, where TypeParam =  and GetParam() =  (6409 ms)
[ RUN      ] FindInPageControllerTest.SingleOccurrence
[7352:4620:0614/074129.147:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
c:\b\c\b\win\src\chrome\browser\ui\find_bar\find_bar_host_browsertest.cc(482): error:       Expected: first_rect
      Which is: 48,5922 482x90
To be equal to: second_rect
      Which is: 48,5905 482x90
[  FAILED  ] FindInPageControllerTest.SingleOccurrence, where TypeParam =  and GetParam() =  (4081 ms)
[ RUN      ] FindInPageControllerTest.SingleOccurrence
[6644:4576:0614/074144.413:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
c:\b\c\b\win\src\chrome\browser\ui\find_bar\find_bar_host_browsertest.cc(482): error:       Expected: first_rect
      Which is: 48,5922 482x90
To be equal to: second_rect
      Which is: 48,5915 482x90
[  FAILED  ] FindInPageControllerTest.SingleOccurrence, where TypeParam =  and GetParam() =  (3998 ms)
[ RUN      ] FindInPageControllerTest.SingleOccurrence
[1408:5828:0614/074149.506:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
c:\b\c\b\win\src\chrome\browser\ui\find_bar\find_bar_host_browsertest.cc(482): error:       Expected: first_rect
      Which is: 48,5922 482x90
To be equal to: second_rect
      Which is: 48,5915 482x90
[  FAILED  ] FindInPageControllerTest.SingleOccurrence, where TypeParam =  and GetParam() =  (4383 ms)

Possibly related to issue 736123357fcf3d8bf78af92fdd24efa81333117e, will disable or revert soon.
 
 Issue 733320  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31b4c18609a59916ac3d97ee75403a94f62ced94

commit 31b4c18609a59916ac3d97ee75403a94f62ced94
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Jun 14 17:26:59 2017

Disable flaky FindInPageControllerTest.SingleOccurrence test.

BUG= 733286 
TBR=pkasting

Change-Id: Ica74eb3545aaa933c625b876376d6ebf4052b8ff
Reviewed-on: https://chromium-review.googlesource.com/534978
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479433}
[modify] https://crrev.com/31b4c18609a59916ac3d97ee75403a94f62ced94/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Labels: -Sheriff-Chromium
Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over a year.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca159597606f91cf28b847c90981e4acffafde1

commit dca159597606f91cf28b847c90981e4acffafde1
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Jan 02 19:15:01 2019

Re-enable disabled tests in c/b/ui/find_bar/.

These pass on Windows.

Bug:  11761 ,  40948 ,  43070 ,  43072 ,  367701 ,  369169 ,  733286 ,  825341 
Change-Id: Ic6ebbddbdd306ff09867a1ea2c97cbf701ee526e
Reviewed-on: https://chromium-review.googlesource.com/c/1351785
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619448}
[modify] https://crrev.com/dca159597606f91cf28b847c90981e4acffafde1/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
[modify] https://crrev.com/dca159597606f91cf28b847c90981e4acffafde1/chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc

Status: Fixed (was: Archived)

Sign in to add a comment