New issue
Advanced search Search tips

Issue 733283 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Bad-cast to blink::ResourceFinishObserver from invalid vptr;blink::NotifyFinishObservers;base::internal::Invoker<base::internal::BindState<void

Project Member Reported by ClusterFuzz, Jun 14 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4936691633881088

Fuzzer: attekett_dom_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x1dc46bc24ca8
Crash State:
  Bad-cast to blink::ResourceFinishObserver from invalid vptr
  blink::NotifyFinishObservers
  base::internal::Invoker<base::internal::BindState<void
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=479114:479272

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4936691633881088


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by est...@chromium.org, Jun 14 2017

Components: Blink>Network>FetchAPI
Owner: yhirano@chromium.org
Status: Assigned (was: Untriaged)
yhirano, can you please take a look? Looks related to https://chromium-review.googlesource.com/522185
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 15 2017

Labels: M-61
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 15 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 15 2017

Labels: Pri-1

Comment 5 by est...@chromium.org, Jun 15 2017

 Issue 733731  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e14c046442157236626bd0a8c8bf4d5128e6fd8e

commit e14c046442157236626bd0a8c8bf4d5128e6fd8e
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jun 16 10:01:30 2017

Trace ResourceFinishObservers appropriately when notifying

Previously a posted task from
Resource::TriggerNotificationForFinishObservers lacks a trace, which
resulted in use-after-poison. This CL fixes that by using Persistent.

Bug: 733581,  733507 ,  733283 
Change-Id: Id6593e8bdc3abf5e41242c50561e97f8258f4258
Reviewed-on: https://chromium-review.googlesource.com/538512
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480006}
[modify] https://crrev.com/e14c046442157236626bd0a8c8bf4d5128e6fd8e/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp

Project Member

Comment 7 by ClusterFuzz, Jun 17 2017

ClusterFuzz has detected this issue as fixed in range 480004:480008.

Detailed report: https://clusterfuzz.com/testcase?key=4936691633881088

Fuzzer: attekett_dom_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Bad-cast
Crash Address: 0x1dc46bc24ca8
Crash State:
  Bad-cast to blink::ResourceFinishObserver from invalid vptr
  blink::NotifyFinishObservers
  base::internal::Invoker<base::internal::BindState<void
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=479114:479272
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=480004:480008

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4936691633881088


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jun 17 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4936691633881088 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 17 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-0
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 23 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment