New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733277 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Link on interstitial isn't clickable

Project Member Reported by nparker@chromium.org, Jun 14 2017

Issue description

The first link on the SBER2 opt-in isn't clickable on SB and SSL interstitials.


"Automatically send some [system information and page content] to Google to help detect dangerous apps and sites. [Privacy policy]"

It's broken on Dev on Linux (61.0.3128.3) but working on stable (59.0.3071.86).

Nate/Ed -- Looks like a regression.  Did anything change here recently?

 
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: ntfschr@chromium.org
Status: Assigned (was: Untriaged)
Thanks for catching this! Yes, this was missed during https://chromium.googlesource.com/chromium/src/+/f9dfdb6d9dcd8c5f987fd7114bff3ebee6b8785f

I'll send a fix out for review. I think this was the only CMD_* that was missed in the CL.
Thanks for spotting this Nathan, and thanks for picking this up Nate.
Labels: M-61
Labels: -M-61 M-60
The breaking CL landed in 60.0.3105.0, so I'm adjusting this to M-60. Please correct me if we still want to target M-61.
All to me only not share
Agreed -- if it was broken in M60, we should merge the fix to M60
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e0ea263b4536d9faded0f8574a61159bb2befc

commit 19e0ea263b4536d9faded0f8574a61159bb2befc
Author: Nate Fischer <ntfschr@chromium.org>
Date: Fri Jun 16 17:28:35 2017

Interstitials: fix CMD_OPEN_WHITEPAPER

Clicking the "system information and page content" link in interstitials
was broken by a refactoring error in f9dfdb6d9d. CMD_* variables were
moved to be properties on SecurityInterstitialCommandId, but only
CMD_OPEN_WHITEPAPER was not updated correctly.

Bug:  733277 
Test: browser_tests --gtest_filter=SafeBrowsingBlockingPageBrowserTest*
Change-Id: I1b07f2843b7b8c367105a2280eebcae583fb9bf4
Reviewed-on: https://chromium-review.googlesource.com/536435
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480091}
[modify] https://crrev.com/19e0ea263b4536d9faded0f8574a61159bb2befc/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/19e0ea263b4536d9faded0f8574a61159bb2befc/components/security_interstitials/core/browser/resources/extended_reporting.js

Comment 8 by vakh@chromium.org, Jun 16 2017

Labels: SafeBrowsing-Triaged
Labels: Merge-Request-60
Since this is RB-Stable, I'm requesting a merge-back.

Per the new merge requirements (doc from amineer@ [1]):

 - This will benefit users because the will no longer feel broken.
 - This bug affects all users, and probably has medium impact, so this probably deserves at least RB-Stable if not RB-Beta (per the table in this guide [2])
 - The CL has full automated test coverage.
 - The merge should be safe. This only affects the JS in interstitials, so this cannot adversely impact any other area of chrome.

[1] https://docs.google.com/a/google.com/document/d/1d9ZG9W6m6Jpj72YrfcDT48yRqJrlrMTdfAYSv_bsOv0/edit?usp=sharing_eip&ts=5935e8b9
[2] https://docs.google.com/document/d/10Dr_ndtQ-KFS4AGLfqmHLlw3WP3fbsy76wAah_hGfdk/edit
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 16 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Approved for M60 branch 3112, thanks for all the details in c#9, appreciate it!
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 17 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/541faa0ed0d2a12ded471d297e36514c5bde14a4

commit 541faa0ed0d2a12ded471d297e36514c5bde14a4
Author: Nate Fischer <ntfschr@chromium.org>
Date: Sat Jun 17 00:05:58 2017

Interstitials: fix CMD_OPEN_WHITEPAPER

Clicking the "system information and page content" link in interstitials
was broken by a refactoring error in f9dfdb6d9d. CMD_* variables were
moved to be properties on SecurityInterstitialCommandId, but only
CMD_OPEN_WHITEPAPER was not updated correctly.

TBR=ntfschr@chromium.org

(cherry picked from commit 19e0ea263b4536d9faded0f8574a61159bb2befc)

Bug:  733277 
Test: browser_tests --gtest_filter=SafeBrowsingBlockingPageBrowserTest*
Change-Id: I1b07f2843b7b8c367105a2280eebcae583fb9bf4
Reviewed-on: https://chromium-review.googlesource.com/536435
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480091}
Reviewed-on: https://chromium-review.googlesource.com/538982
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#373}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/541faa0ed0d2a12ded471d297e36514c5bde14a4/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/541faa0ed0d2a12ded471d297e36514c5bde14a4/components/security_interstitials/core/browser/resources/extended_reporting.js

Status: Fixed (was: Assigned)
Verification steps:

1. Visit http://testsafebrowsing.appspot.com in chrome (on desktop or android)
2. Click on any of the first four links
3. On the red blocking page, click on the link that says "system information and page content"

The final step should redirect you to https://www.google.com/chrome/browser/privacy/whitepaper.html?hl=en-US#extendedreport
Status: Verified (was: Fixed)
Verified on ChromeOS 9592.71.0, 60.0.3112.80

Sign in to add a comment