Link on interstitial isn't clickable |
||||||||||
Issue descriptionThe first link on the SBER2 opt-in isn't clickable on SB and SSL interstitials. "Automatically send some [system information and page content] to Google to help detect dangerous apps and sites. [Privacy policy]" It's broken on Dev on Linux (61.0.3128.3) but working on stable (59.0.3071.86). Nate/Ed -- Looks like a regression. Did anything change here recently?
,
Jun 15 2017
Thanks for spotting this Nathan, and thanks for picking this up Nate.
,
Jun 15 2017
,
Jun 15 2017
The breaking CL landed in 60.0.3105.0, so I'm adjusting this to M-60. Please correct me if we still want to target M-61.
,
Jun 15 2017
All to me only not share
,
Jun 16 2017
Agreed -- if it was broken in M60, we should merge the fix to M60
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19e0ea263b4536d9faded0f8574a61159bb2befc commit 19e0ea263b4536d9faded0f8574a61159bb2befc Author: Nate Fischer <ntfschr@chromium.org> Date: Fri Jun 16 17:28:35 2017 Interstitials: fix CMD_OPEN_WHITEPAPER Clicking the "system information and page content" link in interstitials was broken by a refactoring error in f9dfdb6d9d. CMD_* variables were moved to be properties on SecurityInterstitialCommandId, but only CMD_OPEN_WHITEPAPER was not updated correctly. Bug: 733277 Test: browser_tests --gtest_filter=SafeBrowsingBlockingPageBrowserTest* Change-Id: I1b07f2843b7b8c367105a2280eebcae583fb9bf4 Reviewed-on: https://chromium-review.googlesource.com/536435 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#480091} [modify] https://crrev.com/19e0ea263b4536d9faded0f8574a61159bb2befc/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/19e0ea263b4536d9faded0f8574a61159bb2befc/components/security_interstitials/core/browser/resources/extended_reporting.js
,
Jun 16 2017
,
Jun 16 2017
Since this is RB-Stable, I'm requesting a merge-back. Per the new merge requirements (doc from amineer@ [1]): - This will benefit users because the will no longer feel broken. - This bug affects all users, and probably has medium impact, so this probably deserves at least RB-Stable if not RB-Beta (per the table in this guide [2]) - The CL has full automated test coverage. - The merge should be safe. This only affects the JS in interstitials, so this cannot adversely impact any other area of chrome. [1] https://docs.google.com/a/google.com/document/d/1d9ZG9W6m6Jpj72YrfcDT48yRqJrlrMTdfAYSv_bsOv0/edit?usp=sharing_eip&ts=5935e8b9 [2] https://docs.google.com/document/d/10Dr_ndtQ-KFS4AGLfqmHLlw3WP3fbsy76wAah_hGfdk/edit
,
Jun 16 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 16 2017
Approved for M60 branch 3112, thanks for all the details in c#9, appreciate it!
,
Jun 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/541faa0ed0d2a12ded471d297e36514c5bde14a4 commit 541faa0ed0d2a12ded471d297e36514c5bde14a4 Author: Nate Fischer <ntfschr@chromium.org> Date: Sat Jun 17 00:05:58 2017 Interstitials: fix CMD_OPEN_WHITEPAPER Clicking the "system information and page content" link in interstitials was broken by a refactoring error in f9dfdb6d9d. CMD_* variables were moved to be properties on SecurityInterstitialCommandId, but only CMD_OPEN_WHITEPAPER was not updated correctly. TBR=ntfschr@chromium.org (cherry picked from commit 19e0ea263b4536d9faded0f8574a61159bb2befc) Bug: 733277 Test: browser_tests --gtest_filter=SafeBrowsingBlockingPageBrowserTest* Change-Id: I1b07f2843b7b8c367105a2280eebcae583fb9bf4 Reviewed-on: https://chromium-review.googlesource.com/536435 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#480091} Reviewed-on: https://chromium-review.googlesource.com/538982 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#373} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/541faa0ed0d2a12ded471d297e36514c5bde14a4/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/541faa0ed0d2a12ded471d297e36514c5bde14a4/components/security_interstitials/core/browser/resources/extended_reporting.js
,
Jun 20 2017
Verification steps: 1. Visit http://testsafebrowsing.appspot.com in chrome (on desktop or android) 2. Click on any of the first four links 3. On the red blocking page, click on the link that says "system information and page content" The final step should redirect you to https://www.google.com/chrome/browser/privacy/whitepaper.html?hl=en-US#extendedreport
,
Jul 28 2017
Verified on ChromeOS 9592.71.0, 60.0.3112.80 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ntfschr@chromium.org
, Jun 15 2017Owner: ntfschr@chromium.org
Status: Assigned (was: Untriaged)