New issue
Advanced search Search tips

Issue 733276 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Invoking password generator on hm.com crashes in ios simulator

Project Member Reported by rogerm@chromium.org, Jun 14 2017

Issue description

Chrome Version: 61.0.331.0 (Developer Build) unknown 64-bit
OS: iOS

What steps will reproduce the problem?
(1) launch chrome in the iPhone 6s simulator
(2) browse to hm.com
(3) click on the shopping bag / cart icon
(4) Create a New Account
(5) Focus on the Email field
(6) click on "Generate Password" at the botton of the screen

What is the expected result?

Should see the password generator view

What happens instead?

Crash


 

Comment 1 by rogerm@chromium.org, Jun 14 2017

2017-06-14 11:41:25.360 Chromium[2811:2978518] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[1]'
*** First throw call stack:
(
	0   CoreFoundation                      0x00000001188aad4b __exceptionPreprocess + 171
	1   libobjc.A.dylib                     0x000000011cdb821e objc_exception_throw + 48
	2   CoreFoundation                      0x00000001187c115f -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 351
	3   CoreFoundation                      0x00000001187c0fcb +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59
	4   Chromium                            0x000000010ca78143 -[PasswordGenerationPromptView configure] + 1059
	5   Chromium                            0x000000010ca7a770 -[PasswordGenerationPromptDialog configureGlobalViewWithPassword:] + 240
	6   Chromium                            0x000000010ca7b152 -[PasswordGenerationPromptViewController viewDidLoad] + 306
	7   UIKit                               0x000000011710fa3d -[UIViewController loadViewIfRequired] + 1258
	8   UIKit                               0x000000011710fe70 -[UIViewController view] + 27
	9   UIKit                               0x00000001170f1ac5 -[UIPresentationController presentedView] + 48
	10  Chromium                            0x000000010c2619eb __58-[MDCDialogPresentationController keyboardWatcherHandler:]_block_invoke + 139
	11  UIKit                               0x00000001170285c0 +[UIView(UIViewAnimationWithBlocks) _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:] + 581
	12  UIKit                               0x0000000117028ad9 +[UIView(UIViewAnimationWithBlocks) animateWithDuration:delay:options:animations:completion:] + 105
	13  Chromium                            0x000000010c261935 -[MDCDialogPresentationController keyboardWatcherHandler:] + 245
	14  CoreFoundation                      0x00000001188485ec __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
	15  CoreFoundation                      0x00000001188484eb _CFXRegistrationPost + 427
	16  CoreFoundation                      0x0000000118848252 ___CFXNotificationPost_block_invoke + 50
	17  CoreFoundation                      0x000000011880b282 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 2018
	18  CoreFoundation                      0x000000011880a31b _CFXNotificationPost + 667
	19  Foundation                          0x00000001195c981b -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
	20  Chromium                            0x000000010c2a0325 -[MDCKeyboardWatcher updateOffsetWithUserInfo:forceHidden:notificationToPost:] + 213
	21  Chromium                            0x000000010c2a0512 -[MDCKeyboardWatcher keyboardWillChangeFrame:] + 114
	22  CoreFoundation                      0x00000001188485ec __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
	23  CoreFoundation                      0x00000001188484eb _CFXRegistrationPost + 427
	24  CoreFoundation                      0x0000000118848252 ___CFXNotificationPost_block_invoke + 50
	25  CoreFoundation                      0x000000011880b282 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 2018
	26  CoreFoundation                      0x000000011880a31b _CFXNotificationPost + 667
	27  Foundation                          0x00000001195c981b -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
	28  UIKit                               0x00000001179e3dbf -[UIInputWindowController postStartNotifications:withInfo:] + 227
	29  UIKit                               0x00000001179e60f7 __77-[UIInputWindowController moveFromPlacement:toPlacement:starting:completion:]_block_invoke.871 + 382
	30  UIKit                               0x00000001170285c0 +[UIView(UIViewAnimationWithBlocks) _setupAnimationWithDuration:delay:view:options:factory:animations:start:animationStateGenerator:completion:] + 581
	31  UIKit                               0x0000000117028a4d +[UIView(UIViewAnimationWithBlocks) _animateWithDuration:delay:options:animations:start:completion:] + 119
	32  UIKit                               0x00000001179e5b24 -[UIInputWindowController moveFromPlacement:toPlacement:starting:completion:] + 1627
	33  UIKit                               0x00000001179edb0b -[UIInputWindowController setInputViewSet:] + 1700
	34  UIKit                               0x00000001179e5138 -[UIInputWindowController performOperations:withAnimationStyle:] + 50
	35  UIKit                               0x000000011765833d -[UIPeripheralHost(UIKitInternal) setInputViews:animationStyle:] + 1432
	36  UIKit                               0x00000001176595f8 -[UIPeripheralHost(UIKitInternal) _preserveInputViewsWithId:animated:reset:] + 498
	37  UIKit                               0x0000000117121543 -[UIViewController _presentViewController:modalSourceViewController:presentationController:animationController:interactionController:completion:] + 1178
	38  UIKit                               0x000000011712328e -[UIViewController _presentViewController:withAnimationController:completion:] + 4971
	39  UIKit                               0x000000011712626b -[UIViewController _performCoordinatedPresentOrDismiss:animated:] + 530
	40  UIKit                               0x0000000117125d51 -[UIViewController presentViewController:animated:completion:] + 179
	41  Chromium                            0x000000010c869e0a -[BrowserViewController presentViewController:animated:completion:] + 2426
	42  Chromium                            0x000000010ca30fc5 -[MainViewController presentViewController:animated:completion:] + 85
	43  Chromium                            0x000000010ca7bc60 -[PasswordsUiDelegateImpl showGenerationAlertWithPassword:andPromptDelegate:] + 960
	44  Chromium                            0x000000010c2091a5 -[PasswordGenerationAgent generatePassword] + 229
	45  UIKit                               0x0000000116f6f8bc -[UIApplication sendAction:to:from:forEvent:] + 83
	46  UIKit                               0x00000001170f5c38 -[UIControl sendAction:to:forEvent:] + 67
	47  UIKit                               0x00000001170f5f51 -[UIControl _sendActionsForEvents:withEvent:] + 444
	48  UIKit                               0x00000001170f4e4d -[UIControl touchesEnded:withEvent:] + 668
	49  UIKit                               0x0000000116fdd545 -[UIWindow _sendTouchesForEvent:] + 2747
	50  UIKit                               0x0000000116fdec33 -[UIWindow sendEvent:] + 4011
	51  UIKit                               0x0000000116f8b9ab -[UIApplication sendEvent:] + 371
	52  UIKit                               0x000000011777872d __dispatchPreprocessedEventFromEventQueue + 3248
	53  UIKit                               0x0000000117771463 __handleEventQueue + 4879
	54  CoreFoundation                      0x000000011884f761 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
	55  CoreFoundation                      0x000000011883498c __CFRunLoopDoSources0 + 556
	56  CoreFoundation                      0x0000000118833e76 __CFRunLoopRun + 918
	57  CoreFoundation                      0x0000000118833884 CFRunLoopRunSpecific + 420
	58  GraphicsServices                    0x000000011dfc7a6f GSEventRunModal + 161
	59  UIKit                               0x0000000116f6dc68 UIApplicationMain + 159
	60  Chromium                            0x000000010bbe4e9b main + 1051
	61  libdyld.dylib                       0x00000001204ca68d start + 1
	62  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Comment 2 by sczs@chromium.org, Jun 14 2017

Owner: rogerm@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by rogerm@chromium.org, Jun 14 2017

Owner: vabr@chromium.org

Comment 4 by vabr@chromium.org, Jun 16 2017

Labels: Hotlist-Polish
Owner: ----
Status: Available (was: Assigned)
Thanks for the report. Password generation should be behind a flag and is definitely not ready on iOS yet. Therefore fixing this crash is not a priority now. I will leave this as Available, so that we don't forget to check it before launching on iOS.

Comment 5 by vabr@chromium.org, Jun 16 2017

Also, I think this might have been caused by the bug fixed in https://codereview.chromium.org/2942003002/.

Comment 6 by rogerm@chromium.org, Jun 16 2017

FWIW, this was a pretty fresh simulator instance with no non-default flags or settings specified. From c4, I would then have expected not to even see the password generator prompt.

Comment 7 by vabr@chromium.org, Jun 19 2017

Status: WontFix (was: Available)
I checked the repro steps with Chrome 61.0.3134.0 on iOS and the crash is no more (see #5 for why). Therefore closing the bug.

Thanks for pointing out that we are actually shipping this to some groups of users, rogerm@! I will follow-up with dvadym@, who leads this project, to fix that.

Sign in to add a comment