Adding Pawel as he handles committership nominations.

@Pierre: as I understand, you used to be able to commit in the V8 repository in the past?

Hi, thanks for the follow-up!

Yes, I'm able to commit using Rietveld, after an OWNER has issues an LGTM.

Thanks,
Pierre

+agable

Looks like Pierre is not a committer, and doesn't have tryjob access. I'm not sure how this worked before.

See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ipfokfDWtP4/eyGJNoivCAAJ and http://go/gerrit-cq-for-contributors (internal) for some context.

Apologies, the v8 CQ permissions were configured correctly for release branches but not for master. I have now fixed it and you should be able to set the CQ label.

I can confirm it works! Thank you!

Pierre

Hello,

I'm afraid I'm unable to submit to the CQ again, as you can see here: https://chromium-review.googlesource.com/c/544956/

Any ideas what is happening?
Thanks,
Pierre

This is because you have not been granted tryjob access by the v8 project.

Michael, please evaluate whether pierre.langlois@arm.com should have tryjob access or not, and grant it if so. (Or get someone more appropriate to do so, if that's a better path forward.)

Oh, I'm a little confused. Do I need tryjob access if the change was already approved by an OWNER? This is the case here.

Thanks a lot!
Pierre

Correct, that is unfortunately the case. Folks without tryjob access cannot start tryjobs, no matter the approvals on the change. This may change in the future, but it is how things work for now.

OK, thanks for clarifying.

Would it be possible to make sure the following people are also granted try job access for V8? I want to make sure we don't have to re-open this tickets as the rest of the team transitions over to gerrit :-).

- rodolph.perfetta@arm.com
- martyn.capewell@arm.com (I've checked with Martyn and it works for him)
- georgia.kouveli@arm.com
- baptiste.afsa@arm.com
- jacob.bramley@arm.com
- vincent.belliard@arm.com

Thanks,

It might already work for some of those, who had general chromium tryjob access before.

To make sure, I added all these emails now specifically for v8 tryjob access.

 Issue gerrit:6643  has been merged into this issue.

Great! Did you also include my own email in the list? Sorry I forgot to add it.

I did now ;)