New issue
Advanced search Search tips

Issue 733247 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 725351



Sign in to add a comment

Flashing / Blinking MJPEG Streams and JPEG images on reload

Reported by st...@moonware.ch, Jun 14 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3130.0 Safari/537.36

Example URL:
http://www.insecam.org/en/view/257192/

Steps to reproduce the problem:
1. Open page with a network camera stream (either a refreshing JPEG images or an MJPEG stream)
2. 
3. 

What is the expected behavior?
No blinking between 2 frames.

Worked fine since years but seems suddenly broken in 61.0.3130 / 3131

What went wrong?
The images (fake streams) are blinking every time a new image is about to be displayed

Did this work before? Yes 61.0.3125.0

Is it a problem with Flash or HTML5? N/A

Does this work in other browsers? Yes

Chrome version: 61.0.3130.0  Channel: canary
OS Version: 10.0
Flash Version: 

Contents of chrome://gpu: 
Note: To properly save this page, select the "Webpage, Complete" option in the Save File dialog.
Graphics Feature Status
Canvas: Hardware accelerated
CheckerImaging: Enabled
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Enabled
Native GpuMemoryBuffers: Software only. Hardware acceleration disabled
Rasterization: Hardware accelerated
Video Decode: Hardware accelerated
Video Encode: Hardware accelerated
WebGL: Hardware accelerated
WebGL2: Hardware accelerated
Driver Bug Workarounds
clear_uniforms_before_first_program_use
decode_encode_srgb_for_generatemipmap
disable_discard_framebuffer
disable_dxgi_zero_copy_video
disable_framebuffer_cmaa
exit_on_context_lost
force_cube_complete
scalarize_vec_and_mat_constructor_args
texsubimage_faster_than_teximage
Problems Detected
Some drivers are unable to reset the D3D device in the GPU process sandbox
Applied Workarounds: exit_on_context_lost
TexSubImage is faster for full uploads on ANGLE
Applied Workarounds: texsubimage_faster_than_teximage
Clear uniforms before first program use on all platforms: 124764, 349137
Applied Workarounds: clear_uniforms_before_first_program_use
Always rewrite vec/mat constructors to be consistent: 398694
Applied Workarounds: scalarize_vec_and_mat_constructor_args
ANGLE crash on glReadPixels from incomplete cube map texture: 518889
Applied Workarounds: force_cube_complete
Framebuffer discarding can hurt performance on non-tilers: 570897
Applied Workarounds: disable_discard_framebuffer
Limited enabling of Chromium GL_INTEL_framebuffer_CMAA: 535198
Applied Workarounds: disable_framebuffer_cmaa
Disable KHR_blend_equation_advanced until cc shaders are updated: 661715
Decode and Encode before generateMipmap for srgb format textures on Windows: 634519
Applied Workarounds: decode_encode_srgb_for_generatemipmap
Zero-copy DXGI video hangs or displays incorrect colors on AMD drivers: 623029
Applied Workarounds: disable_dxgi_zero_copy_video
Native GpuMemoryBuffers have been disabled, either via about:flags or command line.
Disabled Features: native_gpu_memory_buffers
Version Information
Data exported	14/06/2017 à 15:43:29
Chrome version	Chrome/61.0.3130.0
Operating system	Windows NT 10.0.15063
Software rendering list version	13.8
Driver bug list version	10.13
ANGLE commit id	fb05bcbacca8
2D graphics backend	Skia/61 e8f28818a2c0fe967f9fc4cec4bb9dc78af78212-
Command Line	"C:\Users\sniquille\AppData\Local\Google\Chrome SxS\Application\chrome.exe" --flag-switches-begin --flag-switches-end
Driver Information
Initialization time	83
In-process GPU	false
Passthrough Command Decoder	false
Supports overlays	false
Sandboxed	false
GPU0	VENDOR = 0x1002, DEVICE= 0x6811
Optimus	false
Optimus	false
AMD switchable	false
Desktop compositing	Aero Glass
Diagonal Monitor Size of \\.\DISPLAY1	26.9"
Driver vendor	Advanced Micro Devices, Inc.
Driver version	22.19.162.4
Driver date	4-24-2017
Pixel shader version	5.0
Vertex shader version	5.0
Max. MSAA samples	8
Machine model name	
Machine model version	
GL_VENDOR	Google Inc.
GL_RENDERER	ANGLE (AMD Radeon (TM) R7 370 Series Direct3D11 vs_5_0 ps_5_0)
GL_VERSION	OpenGL ES 3.0 (ANGLE 2.1.0.fb05bcbacca8)
GL_EXTENSIONS	GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_robust_resource_initialization GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object
Disabled Extensions	GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent
Window system binding vendor	Google Inc. (adapter LUID: 000000000000bd6c)
Window system binding version	1.4 (ANGLE 2.1.0.fb05bcbacca8)
Window system binding extensions	EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays
Direct rendering	Yes
Reset notification strategy	0x8252
GPU process crash count	0
Compositor Information
Tile Update Mode	One-copy
Partial Raster	Enabled
GpuMemoryBuffers Status
ATC	Software only
ATCIA	Software only
DXT1	Software only
DXT5	Software only
ETC1	Software only
R_8	Software only
RG_88	Software only
BGR_565	Software only
RGBA_4444	Software only
RGBX_8888	Software only
RGBA_8888	Software only
BGRX_8888	Software only
BGRA_8888	Software only
RGBA_F16	Software only
YVU_420	Software only
YUV_420_BIPLANAR	Software only
UYVY_422	Software only
Diagnostics
... loading ...

If the sample page / stream is broken it should be easy to find another one to reproduce the problem here:
http://www.insecam.org/en/byrating/?page=2

Both Chromium and Chrome Canary impacted (on 2 different PC).
 
Components: -Internals>Media Blink>Image
Components: -Blink>Image Internals>Network
Labels: -Pri-2 BugSource-User PaintTeamTriaged-20170615 OS-Linux Pri-1
Owner: mmenke@chromium.org
Status: Assigned (was: Unconfirmed)
Bisects to https://chromium.googlesource.com/chromium/src/+log/6a32dcf0c4968f022b2f603912ce2804606636e1..fb9bbbcec682d33356ae79cf42809d3926f59c39

Within that, nothing screams at me but this is the only one that seems plausible: https://chromium.googlesource.com/chromium/src/+/6ddfbead4aad126ef4fef58346ef11ff94a7d2e7

Note that would have shipped in 61.0.3117.0, which is not quite what the original reporter said.

On current trunk a DCHECK hits:
[1:5:0615/094500.663700:FATAL:proxy_impl.cc(534)] Check failed: layer_tree_host_impl_->CanDraw(). 
#0 0x7f7fb6bb3877 base::debug::StackTrace::StackTrace()
#1 0x7f7fb6bd8f6d logging::LogMessage::~LogMessage()
#2 0x7f7fb2db6646 cc::ProxyImpl::ScheduledActionDrawIfPossible()
#3 0x7f7fb2d2aed0 cc::Scheduler::DrawIfPossible()
#4 0x7f7fb2d27d1c cc::Scheduler::ProcessScheduledActions()
#5 0x7f7fb2d279b9 cc::Scheduler::OnBeginImplFrameDeadline()
#6 0x7f7fb2c7bf97 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#7 0x7f7fb2c7beb4 base::CancelableCallback<>::Forward()
#8 0x7f7fb2c7bf97 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#9 0x7f7fb6b9ea81 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#10 0x7f7fb6bb41a3 base::debug::TaskAnnotator::RunTask()
#11 0x7f7faea8a313 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#12 0x7f7faea879d8 blink::scheduler::TaskQueueManager::DoWork()
#13 0x7f7faea8c6f7 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9scheduler16TaskQueueManagerEFvbEJNS_7WeakPtrIS5_EEbEEEFvvEE3RunEPNS0_13BindStateBaseE
#14 0x7f7fb6b9ea81 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#15 0x7f7fb6bb41a3 base::debug::TaskAnnotator::RunTask()
#16 0x7f7fb6be660d base::MessageLoop::RunTask()
#17 0x7f7fb6be6a38 base::MessageLoop::DeferOrRunPendingTask()
#18 0x7f7fb6be6e87 base::MessageLoop::DoWork()
#19 0x7f7fb6be8849 base::MessagePumpDefault::Run()
#20 0x7f7fb6be61e2 base::MessageLoop::Run()
#21 0x7f7fb6c1c2b7 base::RunLoop::Run()
#22 0x7f7fb6c5b66c base::Thread::Run()
#23 0x7f7fb6c5bb8e base::Thread::ThreadMain()
#24 0x7f7fb6c52aec base::(anonymous namespace)::ThreadFunc()
#25 0x7f7fb6d34184 start_thread
#26 0x7f7faa43bbed clone

Comment 3 by mmenke@chromium.org, Jun 15 2017

Status: uncom (was: Assigned)
A change to network stack setup in the browser process cannot cause a crash in the renderer processes drawing code - even if we sent it complete nonsense data, the drawing code should not crash.

Comment 4 by mmenke@chromium.org, Jun 15 2017

Components: -Internals>Network
Owner: ----
Status: Unconfirmed (was: uncom)
I have no idea how to triage renderer crashes, as I don't work there.  Removing myself from this bug.

Comment 5 by mmenke@chromium.org, Jun 15 2017

Components: Blink>Compositing
Adding the compositing label, actually.  I think "cc" may mean Chromium Compositor?
Cc: mmenke@chromium.org
Components: -Blink>Compositing Internals>Compositing
Status: Untriaged (was: Unconfirmed)
mmenke@, the crash stack may be unrelated to the failure. I put it in there for completeness.

But could you try reverting your change locally and see if the bug disappears. You do not need to run a DCHECK build as I did.

And yes, cc is Internals>Compositor.

Comment 7 by mmenke@chromium.org, Jun 15 2017

I'm not seeing a way that CL could cause this failure - I split a data structure in two.  If the network stack were set up incorrectly, you'd be seeing a lot worse than blinking.  And looking at the site, I see a single network request downloading the "mjpg" without error - incorrect setup would not randomly corrupt every other frame of the download, either.

Comment 8 by st...@moonware.ch, Jun 15 2017

Little addition here:

I've put in the report that it was working in 61.0.3125 because it's the version of Google Canary which I run on my Macbook and it does not have the problem however after updating to 61.0.3131 on the Macbook as well it's not impacted so the problem seems only on PC.

I actually don't know what was the version I had on the PCs before updating but it could be that 61.0.3125 for PC already had the issue as i don't know exactly in since which version the problem is.

Btw, where you able to reproduce the problem ?

Thanks!

Comment 9 Deleted

Cc: -mmenke@chromium.org asvitk...@chromium.org
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Oops, ignore that last message.  Messed up in my bisect.

[+khushalsagar]  So it looks to me like this is due to https://codereview.chromium.org/2918633002 (Which is just a json change...but is the only CL with "cc" in its title).  So presumably it just activated a new, experimental code path by default.
OK. steve@, yes we can reproduce reliably. I only tried linux but I can see if I get a different bisect on Mac.

mmenke@, thanks. The bisect script only went down to the range I originally posted and the other changes seemed to be related to histograms and other metrics gathering, which seemed inlikely. But enabling an experiment would explain why it shows up at different times on different platforms.
Blocking: 725351
Cc: vmp...@chromium.org
This definitely looks like the result of checker-imaging. It is currently only enabled on canary behind a finch trial.
https://codereview.chromium.org/2939243002/ fixes this. In review.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54b956cfa0755b0e4777d1e422e3e560c00c6f92

commit 54b956cfa0755b0e4777d1e422e3e560c00c6f92
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Jun 21 15:54:05 2017

cc/blink: Veto checker-imaging for multipart image resources.

Multipart images resources can be used for displaying mjpg videos which
should not be checkered. Plumb this state from blink to cc using
PaintImage to veto them from checkering.

BUG= 733247 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2939243002
Cr-Commit-Position: refs/heads/master@{#481216}

[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/cc/paint/paint_image.cc
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/cc/paint/paint_image.h
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/cc/tiles/checker_image_tracker.cc
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/cc/tiles/checker_image_tracker_unittest.cc
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/core/loader/resource/ImageResource.cpp
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.h
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/platform/graphics/BitmapImage.h
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/54b956cfa0755b0e4777d1e422e3e560c00c6f92/third_party/WebKit/Source/platform/graphics/Image.h

Status: Fixed (was: Assigned)

Sign in to add a comment