New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733243 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 732161



Sign in to add a comment

[NTP::Push] Extract BreakingNewsListener Interface

Project Member Reported by mamir@chromium.org, Jun 14 2017

Issue description

[NTP::Push] Extract BreakingNewsListener Interface
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261b525dcd5e3d29e1981c0e9a741477de8b678d

commit 261b525dcd5e3d29e1981c0e9a741477de8b678d
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Thu Jun 22 14:14:26 2017

[NTP::Push] Rename content_suggestions_gcm_app_handler

Rename content_suggestions_gcm_app_handler to
breaking_news_gcm_app_handler in preparation for extracting
breaking_news_listener interface.

Bug:  733243 
Change-Id: I37897e703a04928e2301d458ecad898aa00ec123
Reviewed-on: https://chromium-review.googlesource.com/544876
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481523}
[modify] https://crrev.com/261b525dcd5e3d29e1981c0e9a741477de8b678d/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/261b525dcd5e3d29e1981c0e9a741477de8b678d/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/261b525dcd5e3d29e1981c0e9a741477de8b678d/components/ntp_snippets/BUILD.gn
[rename] https://crrev.com/261b525dcd5e3d29e1981c0e9a741477de8b678d/components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler.cc
[rename] https://crrev.com/261b525dcd5e3d29e1981c0e9a741477de8b678d/components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler.h
[modify] https://crrev.com/261b525dcd5e3d29e1981c0e9a741477de8b678d/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.cc
[modify] https://crrev.com/261b525dcd5e3d29e1981c0e9a741477de8b678d/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h

Comment 2 by fi...@chromium.org, Jul 21 2017

Labels: zine-triaged
Should this still be targeted at M61? Or is this complete?

Comment 4 by mamir@chromium.org, Aug 2 2017

Status: Fixed (was: Started)
Complete!

Sign in to add a comment