New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733175 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Sep 2017
Cc:
qyears...@chromium.org
█ mcgreevy@chromium.org
dpranke@chromium.org
█ earthdok@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

MSANExpectations references path that don't exist

Project Member Reported by tansell@chromium.org, Jun 14 2017 

https://chromium-swarm.appspot.com/task?id=36bf0d8e1becbf10&refresh=10&show_raw=1

---------------------------
03:54:03.625 25766 Parsing expectations ...
03:54:03.629 25766 reading additional_expectations from path '../../third_party/WebKit/LayoutTests/MSANExpectations'
03:54:04.291 25766 --lint-test-files warnings:
03:54:04.291 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:8 Path does not exist. virtual/slimmingpaint/fast/js/regress
03:54:04.291 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:9 Path does not exist. editing/selection/move-by-word-visually-crash-test-5.html
03:54:04.291 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:10 Path does not exist. perf/array-nested-loop.html
03:54:04.291 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:12 Path does not exist. virtual/slimmingpaint/fast/css/fontface-arraybuffer.html
03:54:04.292 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:17 Path does not exist. virtual/slimmingpaint/fast/workers/shared-worker-constructor.html
03:54:04.292 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:19 Path does not exist. virtual/slimmingpaint/fast/workers/worker-constructor.html
03:54:04.292 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:24 Path does not exist. inspector/tracing/animations.html
03:54:04.292 25766 ../../third_party/WebKit/LayoutTests/MSANExpectations:25 Path does not exist. virtual/deferred/inspector/tracing/animations.html
03:54:04.292 25766 

---------------------------

Comment 1 by qyears...@chromium.org, Jun 14 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Unconfirmed)
Normally, this kind of thing is supposed to be prevented by the Tools/Scripts/lint-test-expectations script, but it isn't currently because that script decide what files to look at using port_to_lint.all_expectations_dict(), and MSANExpectations (and LeakExpectations, ASANExpectations) are never in there.

To do: lint_test_expectations.py should be changed to also check those files. Also, of course, these particular lines should be removed.

https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py

Comment 2 by qyears...@chromium.org, Jun 15 2017 

Filed a separate issue for fixing lint-test-expectations ( bug 733696 ), this bug can be considered fixed when those particular lines are removed.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c40bbd209ea230399bd66c18fec8162b72e71005

commit c40bbd209ea230399bd66c18fec8162b72e71005
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Jun 23 00:27:02 2017

Remove non-existent tests from MSANExpectations.

Bug:  733175 ,420198, 420606 , 450639 
Change-Id: I575ef6c633111c64420de7e7b3434c269066cddf
Reviewed-on: https://chromium-review.googlesource.com/540268
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481743}
[modify] https://crrev.com/c40bbd209ea230399bd66c18fec8162b72e71005/third_party/WebKit/LayoutTests/MSANExpectations

Comment 4 by qyears...@chromium.org, Sep 4 2017

Owner: qyears...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment