Panel windows' icons are not switched after switching desktop to another user |
||||||||
Issue descriptionGoogle Chrome 60.0.3112.20 (Official Build) dev (64-bit) OS: Chrome OS What steps will reproduce the problem? (1) Show a panel window and see an icon at the right of the bottom shelf (2) Sign in to another user without logging out the current user using multiple-user feature. (3) See the desktop of the switched to new user What is the expected result? The icon of the panel window should hide because the window is the previous user's. What happens instead? The icon of the panel window still remains in the shelf. Clicking the icon happens nothing. Please use labels and text to provide additional information. Panel window can be created by some chrome app like https://chrome.google.com/webstore/detail/picture-in-picture-viewer/efaagmolahogmekmnmkigonhfcdiemnl. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jul 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad83a01926b39a02b242074a8b8aba7f385a7ffb commit ad83a01926b39a02b242074a8b8aba7f385a7ffb Author: Michael Wasserman <msw@chromium.org> Date: Wed Jul 12 01:50:50 2017 ash: Fix panel shelf item removal on multi-user switch. Clear the shelf item type of other users' panels on user switch. (in MultiProfileAppWindowLauncherController::ActiveUserChanged) This will cause ShelfWindowWatcher to remove the shelf item. The item is already restored when switching back to the right user. (via ExtensionAppWindowLauncherController::RegisterApp) Add a unit test to guard against regressions. Bug: 733155 , 557406 Test: Switching ChromeOS users hides user-specific panel shelf items. Change-Id: Ic72d3f2646cadb426f4bf0341f26bf27dd26aa53 Reviewed-on: https://chromium-review.googlesource.com/567431 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485786} [modify] https://crrev.com/ad83a01926b39a02b242074a8b8aba7f385a7ffb/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/ad83a01926b39a02b242074a8b8aba7f385a7ffb/chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc
,
Jul 12 2017
This should be fixed with the above change; requesting merge. I'm not sure if the issue severity and frequency merits a merge... (I bet that neither panels nor multi-user are commonly used)
,
Jul 12 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2017
Consider this merge approved, but please wait to merge until the CL is verified on a canary build.
,
Jul 12 2017
Currently still broken on ChromeOS 61.0.3154.0 canary (485485 is before my CL) I'll check back again tomorrow.
,
Jul 17 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccd05ea7faa56007fa535fb718a8ec21f2d6e575 commit ccd05ea7faa56007fa535fb718a8ec21f2d6e575 Author: Michael Wasserman <msw@chromium.org> Date: Mon Jul 17 18:19:34 2017 Merge to M60: ash: Fix panel shelf item removal on multi-user switch. Clear the shelf item type of other users' panels on user switch. (in MultiProfileAppWindowLauncherController::ActiveUserChanged) This will cause ShelfWindowWatcher to remove the shelf item. The item is already restored when switching back to the right user. (via ExtensionAppWindowLauncherController::RegisterApp) Add a unit test to guard against regressions. TBR=msw@chromium.org (cherry picked from commit ad83a01926b39a02b242074a8b8aba7f385a7ffb) Bug: 733155 , 557406 Test: Switching ChromeOS users hides user-specific panel shelf items. Change-Id: Ic72d3f2646cadb426f4bf0341f26bf27dd26aa53 Reviewed-on: https://chromium-review.googlesource.com/567431 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#485786} Reviewed-on: https://chromium-review.googlesource.com/574879 Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#620} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/ccd05ea7faa56007fa535fb718a8ec21f2d6e575/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/ccd05ea7faa56007fa535fb718a8ec21f2d6e575/chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc
,
Jul 17 2017
I verified that this is fixed on a Chromebook pixel at 61.0.3159.0 canary. I merged the CL to branch 3112 in https://chromium-review.googlesource.com/574879 Please help verify the fix on the next M60 update.
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yoshiki@chromium.org
, Jun 14 2017Owner: msw@chromium.org
Status: Assigned (was: Available)
Summary: Panel windows' icons are not switched after switching desktop to another user (was: Panel windows' icons are not switched after )