New issue
Advanced search Search tips

Issue 733137 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect activationTarget selection

Project Member Reported by tkent@chromium.org, Jun 14 2017 
Chrome Version: 61 canary
OS: All

What steps will reproduce the problem?
(1) Open http://w3c-test.org/dom/events/Event-dispatch-click.html
(2) Observe the page

What is the expected result?
No failing tests

What happens instead?
Two failing tests.
 - "look at parents when event bubbles"
 - "pick the first with activation behavior <input type=checkbox>"

Please use labels and text to provide additional information.
The following paragraph is relevant.

https://dom.spec.whatwg.org/#dispatching-events
> 9.2.1. If isActivationEvent is true, event’s bubbles attribute is true, activationTarget is null, and parent has activation behavior, then set activationTarget to parent.

INPUT element has legacy pre-activation behavior.
https://html.spec.whatwg.org/multipage/input.html#the-input-element:legacy-pre-activation-behavior

Comment 1 by tkent@chromium.org, Jun 15 2017

Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c

commit d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Jun 16 14:16:32 2017

Fix activationTarget selection algorithm.

Node::PreDispatchEventHandler() should be called for the deepest node with
activation behavior, not the target node.

Also, fix a test bug in dom/events/Event-dispatch-click.html.

Bug:  733137 
Change-Id: I2c89a782326f8fd9d41892c9c6f6d827b2d6b235
Reviewed-on: https://chromium-review.googlesource.com/536718
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480036}
[delete] https://crrev.com/8fdedc252f470e49320a13ac80233176f6d2f385/third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-dispatch-click-expected.txt
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-dispatch-click.html
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/events/EventDispatcher.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/events/EventDispatcher.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLAnchorElement.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLButtonElement.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLInputElement.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLLabelElement.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLLinkElement.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/html/HTMLSummaryElement.h
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/svg/SVGAElement.cpp
[modify] https://crrev.com/d5b292d1b3e678dbd21f5f2e38ecdfec9c2a5e3c/third_party/WebKit/Source/core/svg/SVGAElement.h

Comment 3 by tkent@chromium.org, Jun 18 2017

Labels: M-61
Status: Fixed (was: Started)
►

Sign in to add a comment