LeakExpectations references not existant files |
||
Issue descriptionExample - https://chromium-swarm.appspot.com/task?id=36be5b49f04f2010&refresh=10&show_raw=1 00:39:04.360 9568 reading additional_expectations from path '../../third_party/WebKit/LayoutTests/LeakExpectations' 00:39:05.255 9568 --lint-test-files warnings: 00:39:05.255 9568 ../../third_party/WebKit/LayoutTests/LeakExpectations:48 Path does not exist. virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/resolve-after-window-close.html 00:39:05.255 9568 ../../third_party/WebKit/LayoutTests/LeakExpectations:49 Path does not exist. virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/window-close-during-registration.html 00:39:05.256 9568 ../../third_party/WebKit/LayoutTests/LeakExpectations:50 Path does not exist. virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/resolve-after-window-close.html 00:39:05.256 9568 ../../third_party/WebKit/LayoutTests/LeakExpectations:51 Path does not exist. virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/chromium/window-close-during-registration.html 00:39:05.256 9568 ../../third_party/WebKit/LayoutTests/LeakExpectations:59 Path does not exist. external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001.html
,
Jun 14 2017
Same underlying issue as bug 733175 -- lint-test-expectations doesn't check this file; to fix this particular issue we can just remove these lines; but in any case to prevent this in the future we want to fix webkitpy/layout_tests/lint_test_expectations.py to check LeakExpectations too.
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/812d922bd835a38412a1f9464d7d5f6241a2e6f6 commit 812d922bd835a38412a1f9464d7d5f6241a2e6f6 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Jun 15 00:48:41 2017 Remove unexisting tests from LeakExpectations Bug: 733130 , 506754, 594309 Change-Id: Id11c5fa51b73d00656496df14209449a53525041 Reviewed-on: https://chromium-review.googlesource.com/535416 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#479562} [modify] https://crrev.com/812d922bd835a38412a1f9464d7d5f6241a2e6f6/third_party/WebKit/LayoutTests/LeakExpectations
,
Jun 15 2017
Thanks hajimehoshi@! Note, I filed a separate bug for checking these files on presubmit: bug 733696 .
,
Jun 19 2017
Thanks, I'll take a look! |
||
►
Sign in to add a comment |
||
Comment 1 by hajimehoshi@chromium.org
, Jun 14 2017Status: Assigned (was: Unconfirmed)