New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733115 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Sep 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 610428



Sign in to add a comment

Views: TabbedPane is messed up in RTL

Reported by sans...@etouch.net, Jun 14 2017 
Chrome Version: 60.0.3112.32 (Official Build)17d6d37b6632cc655909327c7c0559c28bdbf388-refs/branch-heads/3112@{#330}-32/64 bit
OS: Windows (7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

Pre-condition: Enable 'Force UI direction' and 'Material Design in the rest of the browser's native UI' from chrome://flags

Steps:
1. Launch Chrome and navigate to https://www.google.com/intl/en/chrome/browser/welcome.html
2. Click on 'lock icon' and click on Cookies (in use link) and observe

Actual: Blue focus line is seen under 'Blocked' tab even when 'Allowed' tab is selected and vice versa

Expected: Blue focus line should be seen under 'Allowed' tab when 'Allowed' tab is selected and same for 'Blocked' tab

This is a Regression issue broken in M-56, will soon update other info

Good build: 56.0.2889.0
Bad build: 56.0.2890.0
Actual_video.mp4
444 KB View Download
Actual_Expected_result.jpg
82.7 KB View Download

Comment 1 by rbasuvula@chromium.org, Jun 14 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:56.0.2889.0 (Revision:424926).
Bad build:56.0.2890.0 (Revision:425218).

You are probably looking for a change made after 425094 (known good), but no later than 425095 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/d38152e1420a5ee6dcf4768a8254da959045307a..8002657452fc6b81b73ce8c77713b938080c9a2d

From the CL above, assigning the issue to the concern owner

@ellyjones: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2412163003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3130.0.

Comment 2 by ellyjo...@chromium.org, Jun 14 2017

Components: -UI>Browser>Bubbles Internals>Views
Labels: -Type-Bug-Regression -hasbisect-per-revision MacViews-Controls Type-Bug
Summary: Views: TabbedPane is messed up in RTL (was: Regression: Blue focus line is misplaced in Cookies overlay for RTL)
TabbedPane is all messed up in RTL. Hum. Thanks for filing this; I'll take a look.

Comment 3 by ellyjo...@chromium.org, Jun 27 2017

Blocking: 610428
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f20c4c038611f40f0915e27b18086d5fea9e18e

commit 3f20c4c038611f40f0915e27b18086d5fea9e18e
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri Sep 29 12:14:28 2017

views: fix TabbedPane rendering in RTL

TabbedPane's focus indicator line should have been mirrored in RTL so it was
under the focused tab, but it was not.

Bug:  733115 
Change-Id: I25e663300e75aee849aa3804a8e1a5d13f97acf8
Reviewed-on: https://chromium-review.googlesource.com/690796
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505351}
[modify] https://crrev.com/3f20c4c038611f40f0915e27b18086d5fea9e18e/ui/views/controls/tabbed_pane/tabbed_pane.cc

Comment 5 by ellyjo...@chromium.org, Sep 29 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment