New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733113 link

Starred by 1 user
Status: Fixed
Owner:
█ yipengw@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In chrome://credits, focus does not navigate to 'show license' link on pressing Tab key.

Reported by ngu...@etouch.net, Jun 14 2017 
Chrome Version: 61.0.3130.0 (Official Build) 34174075ba5fe272eb1666f4d04857cadc24a83d-refs/heads/master@{#479232} (32/64-bit)
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (Ubuntu 14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome, navigate to chrome://credits, press Tab key multiple times and observe.

Focus does not navigate to 'show license' link.

Focus should navigate to 'show license' link.

This is a Regression issue broken in M-61, will soon update other info
Manual bisect:
Good build: 61.0.3124.0
Bad build: 61.0.3125.0
credits_actual.mp4
434 KB View Download
credits_expected.mp4
508 KB View Download

Comment 1 by rbasuvula@chromium.org, Jun 14 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: yipengw@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3124.0 (Revision:477839).
Bad build:61.0.3125.0 (Revision:478135).

You are probably looking for a change made after 478051 (known good), but no later than 478052 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/b5da5970c259c2bd86f1e3808248e1923c2fbb63..5671d4fe7016d6a2306db39021fb16d51c6ac543

From the CL above, assigning the issue to the concern owner

@Yipeng Wang: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on:https://chromium-review.googlesource.com/497870
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3130.0

Comment 2 by yipengw@chromium.org, Jun 20 2017 

This CL should fix the bug: https://chromium-review.googlesource.com/c/541601/

Comment 3 by yipengw@chromium.org, Jun 21 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f44e29c25a15fe16c90e352c25375a32e1656fda

commit f44e29c25a15fe16c90e352c25375a32e1656fda
Author: Yipeng Wang <yipengw@chromium.org>
Date: Wed Jun 21 21:08:31 2017

[about:credits] Add tab navigation to 'show license' link

Bug:  733113 
Change-Id: I23311150f470455fe7a5860d7fee5bcd65732bec
Reviewed-on: https://chromium-review.googlesource.com/541601
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481295}
[modify] https://crrev.com/f44e29c25a15fe16c90e352c25375a32e1656fda/components/about_ui/resources/about_credits_entry.tmpl
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f44e29c25a15fe16c90e352c25375a32e1656fda

commit f44e29c25a15fe16c90e352c25375a32e1656fda
Author: Yipeng Wang <yipengw@chromium.org>
Date: Wed Jun 21 21:08:31 2017

[about:credits] Add tab navigation to 'show license' link

Bug:  733113 
Change-Id: I23311150f470455fe7a5860d7fee5bcd65732bec
Reviewed-on: https://chromium-review.googlesource.com/541601
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481295}
[modify] https://crrev.com/f44e29c25a15fe16c90e352c25375a32e1656fda/components/about_ui/resources/about_credits_entry.tmpl

Comment 6 by ngu...@etouch.net, Jun 27 2017

Labels: TE-Verified-61.0.3141.0 TE-Verified-M61
Verified above issue on latest Dev 61.0.3141.0 on Windows (7,8,10), Mac (10.11.6,10.12.1) and Linux (14.04 LTS). The issue is fixed and working as intended.
►

Sign in to add a comment