New issue
Advanced search Search tips

Issue 733071 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Event handler should work in cloned Documents

Project Member Reported by tkent@chromium.org, Jun 14 2017

Issue description

Chrome Version: 61 Canary
OS: All but iOS

What steps will reproduce the problem?
(1) Open http://w3c-test.org/dom/events/Event-dispatch-bubbles-false.html or http://w3c-test.org/dom/events/Event-dispatch-bubbles-true.html
(2) Observe

What is the expected result?
No failing tests

What happens instead?
One failing test, "In window.document.cloneNode(xxx)"

Please use labels and text to provide additional information.
It tests event handler in cloned Documents.
At this moment, we don't kick event handlers in such documents.

Edge: NG
Firefox: OK
Safari: OK
 

Comment 1 by tkent@chromium.org, Jun 14 2017

Components: Blink>DOM
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8d6871f9de55fe8fdc606efd101c39792a18a2

commit 2c8d6871f9de55fe8fdc606efd101c39792a18a2
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Jun 14 09:05:44 2017

Allow to execute event handlers listening to events in cloned documents.

Similar to Documents created by DOMImplementation, DOMParser,
Document constructor, cloned Documents should inherit ContextDocument.

Note that <script> and attribute event listeners in such documents
still don't work.

Bug:  733071 
Change-Id: I55ba719647a4b5b1147aedbc25fef100bb7e49af
Reviewed-on: https://chromium-review.googlesource.com/535256
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479332}
[delete] https://crrev.com/95a755f230846d3eb0322b00d39bff5c41cd6cde/third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-dispatch-bubbles-false-expected.txt
[delete] https://crrev.com/95a755f230846d3eb0322b00d39bff5c41cd6cde/third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-dispatch-bubbles-true-expected.txt
[modify] https://crrev.com/2c8d6871f9de55fe8fdc606efd101c39792a18a2/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2c8d6871f9de55fe8fdc606efd101c39792a18a2/third_party/WebKit/Source/core/html/HTMLDocument.cpp

Comment 3 by tkent@chromium.org, Jun 15 2017

Labels: M-61
Status: Fixed (was: Started)

Sign in to add a comment