New issue
Advanced search Search tips

Issue 733070 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Adjust service worker _StartWorkerExistingProcess UMA to accomodate for PlzNavigate

Project Member Reported by falken@chromium.org, Jun 14 2017

Issue description

Some of our UMA focuses on the _StartWorkerExistingProcess breakdown, since that was the common case for navigations. However, with PlzNavigate, _StartWorkerNewProcess becomes the common case. We should adjust our UMAs to fit the PlzNavigate world.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f954b63b01f228cf352d7b0294c291d24a1e9249

commit f954b63b01f228cf352d7b0294c291d24a1e9249
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jun 14 23:02:47 2017

service worker: Migrate away from _StartWorkerExistingProcess metrics

These metrics are obsolete in the post-PlzNavigate world. Pre-PlzNavigate,
_StartWorkerExistingProcess was the common case for navigations,
because navigation and service worker startup would start after the renderer
process launches and issues the request for the URL. Therefore, we
targeted SWEP as the common case to optimize and care about.

However, post-PlzNavigate, _StartWorkerNewProcess is the common case, and
_StartWorkerExistingProcess is also fairly common.

Move the metrics to log to _WorkerStartOccurred, which is logged whenever the
worker was not already in status RUNNING. This is wider than the union of
_StartWorkerExistingProcess and _StartWorkerNewProcess, since it also includes
_DuringStartup as well as cases where the worker was originally in status
STOPPING or STARTING. But in practice, these other cases are rare and this
strikes a good balance of not creating a histogram for every possible state
while capturing what we really care about: whether the worker was already
running or not.

Bug:  733070 
Change-Id: If3aa99e6d83e6b47d6a81d2cc37fb6922e36fa97
Reviewed-on: https://chromium-review.googlesource.com/535374
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479535}
[modify] https://crrev.com/f954b63b01f228cf352d7b0294c291d24a1e9249/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/f954b63b01f228cf352d7b0294c291d24a1e9249/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/f954b63b01f228cf352d7b0294c291d24a1e9249/content/browser/service_worker/service_worker_metrics_unittest.cc
[modify] https://crrev.com/f954b63b01f228cf352d7b0294c291d24a1e9249/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/f954b63b01f228cf352d7b0294c291d24a1e9249/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/f954b63b01f228cf352d7b0294c291d24a1e9249/tools/metrics/histograms/histograms.xml

Comment 2 by falken@chromium.org, Jun 15 2017

Labels: M-61
Status: Fixed (was: Started)
We're pretty good here now, there weren't as many as I thought.

Sign in to add a comment