Chrome Version       : 61.0.3128.0
OS Version: OS X 10.12.5

What steps will reproduce the problem?
1a. On a Mac debug build, right-click the reload button
1b. On a Mac release, right-click the reload button


What is the expected result?

a) No crash
b) A menu appears


What happens instead of that?

a) DCHECKs
b) No menu appears


[ReloadButton awakeFromNib] calls [self setOpenMenuOnRightClick:YES]; And it has a -populateMenu: method that looks like it tries to add things, but the menu doesn't show up.

Did we ever show this menu? Other platforms don't seem to have it. Can we just delete this reload button menu code?


https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm?type=cs&q=setopenmenuonrightclick+package:%5Echromium$&l=74


[98544:775:0614/132405.555057:FATAL:menu_button.mm(201)] Check failed: [self attachedMenu].
0   libbase.dylib                       0x00000001034dceee base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x00000001034dcf8d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x00000001034db20c base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x000000010357b18f logging::LogMessage::~LogMessage() + 479
4   libbase.dylib                       0x0000000103578b05 logging::LogMessage::~LogMessage() + 21
5   libchrome_dll.dylib                 0x0000000116bf2483 -[MenuButton(Private) clickShowMenu:] + 259
6   libchrome_dll.dylib                 0x0000000116bf14ad -[MenuButton rightMouseDown:] + 125
7   AppKit                              0x00007fffb22da7a9 forwardMethod + 133
8   AppKit                              0x00007fffb2538eea -[NSView rightMouseDown:] + 152
9   AppKit                              0x00007fffb2a52c10 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 6458
10  AppKit                              0x00007fffb2a50f0a -[NSWindow(NSEventRouting) sendEvent:] + 541
11  libchrome_dll.dylib                 0x0000000116ade54a -[ChromeEventProcessingWindow sendEvent:] + 122
12  AppKit                              0x00007fffb28d5e7e -[NSApplication(NSEvent) sendEvent:] + 3190
13  libchrome_dll.dylib                 0x000000011104d043 __34-[BrowserCrApplication sendEvent:]_block_invoke + 259
14  libbase.dylib                       0x00000001035837da base::mac::CallWithEHFrame(void () block_pointer) + 10
15  libchrome_dll.dylib                 0x000000011104cdcf -[BrowserCrApplication sendEvent:] + 575
16  AppKit                              0x00007fffb2150427 -[NSApplication run] + 1002