New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 733063 link

Starred by 2 users
Status: Fixed
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Jul 2017
Cc:
█ mgiuca@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Update ShareData.idl to use USVString instead of DOMString?

Project Member Reported by mgiuca@chromium.org, Jun 14 2017 
Chrome Version: 61
OS: All

ShareData.idl in third_party/WebKit/Source/modules/webshare currently looks like this:

dictionary ShareData {
  DOMString? title;
  DOMString? text;
  DOMString? url;
};

Whereas the version in the draft standard (https://wicg.github.io/web-share/#sharedata-dictionary) looks like this:

dictionary ShareData {
    USVString title;
    USVString text;
    USVString url;
};

See https://github.com/WICG/web-share/issues/19 for why this change was made.

Update the Chrome version (as well as the layout test) to match the spec. This should be a non-controversial change, as it should only prevent null and invalid UTF-16 surrogates from being passed.

Comment 1 by mgiuca@chromium.org, Jul 4 2017

Status: Fixed (was: Assigned)
This landed 2 weeks ago but Bugdroid was down:

commit 9e214d9180b8e996f40591ae0a616e667b9a4be5
Author: Matt Giuca <mgiuca@chromium.org>
Date:   Tue Jun 20 13:41:12 2017 +1000

    ShareData IDL definition: Match Web Share draft spec.
    
    - No longer allows null. Passing null as a value will now implicitly
      convert it into the string 'null'.
    - Changed DOMString to USVString. Illegal UTF-16 surrogates now map onto
      U+FFFD, rather than being passed through to the implementation.
    
    Bug:  733063 
    Change-Id: I1382d8cb47d42ff596ef2162603471d014d6d22d
    Reviewed-on: https://chromium-review.googlesource.com/536560
    Commit-Queue: Matt Giuca <mgiuca@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#480753}
►

Sign in to add a comment