New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 733061 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: ----



Sign in to add a comment

components_unittests failing on chromium.chromiumos/Linux ChromiumOS Tests (1)

Project Member Reported by ortuno@chromium.org, Jun 14 2017

Issue description

components_unittests failing on chromium.chromiumos/Linux ChromiumOS Tests (1)

Builders failed on: 
- Linux ChromiumOS Tests (1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29


Filling for sheriff bookkeeping.

Change reverted at:
http://crrev.com/2937853002
 
Status: Assigned (was: Available)
Original CL https://codereview.chromium.org/2911293003/
Stack trace examples:

[ RUN      ] PasswordProtectionServiceTest.TestCacheUnfamiliarLoginVerdicts
Received signal 11 SEGV_MAPERR 000000000008
#0 0x0000037d9987 base::debug::StackTrace::StackTrace()
#1 0x0000037d94ff base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f7c2638f330 <unknown>
#3 0x000003240d1e base::internal::flat_tree<>::equal_range()
#4 0x000003845961 base::DictionaryValue::HasKey()
#5 0x000003752345 safe_browsing::PasswordProtectionService::CacheVerdict()
#6 0x0000024e7e45 safe_browsing::PasswordProtectionServiceTest_TestCacheUnfamiliarLoginVerdicts_Test::TestBody()
#7 0x0000028ece36 testing::Test::Run()
#8 0x0000028ed850 testing::TestInfo::Run()
#9 0x0000028edd77 testing::TestCase::Run()
#10 0x0000028f4ed7 testing::internal::UnitTestImpl::RunAllTests()
#11 0x0000028f4b67 testing::UnitTest::Run()
#12 0x0000047924d1 base::TestSuite::Run()
#13 0x000004794b9a base::(anonymous namespace)::LaunchUnitTestsInternal()
#14 0x000004794a64 base::LaunchUnitTests()
#15 0x0000007426ac main
#16 0x7f7c1ffbef45 __libc_start_main
#17 0x0000007425ad <unknown>
  r8: 0000000006837d21  r9: 000000000683ad40 r10: 000000000683ae40 r11: 00007f7c20126cf0
 r12: 00007ffdcca3c180 r13: 00001af5f2c03480 r14: 0000000000000000 r15: 00007ffdcca3c2c8
  di: 0000000000000008  si: 00007ffdcca3c110  bp: 0000000000000000  bx: 0000000000000008
  dx: 000000000000000c  ax: 00001af5f2c4f3d8  cx: 00001af5f2c4f3d8  sp: 00007ffdcca3c0a0
  ip: 0000000003240d1e efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000008
[end of stack trace]
Calling _exit(1). Core file will not be generated.
Cc: raymes@chromium.org
Components: Services>Safebrowsing
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
+raymes@, as you're the expert in content settings related code. 
My code passed all try bots but failed in waterfall. I couldn't reproduce locally either. 
It seems the failing point is inside base::DictionaryValue::HasKey(), have you encounter similar situation?  Do you know what leads to the different behaviors on try bots/local v.s. the water fall build bots. 

Thank you so much for helping out!

Comment 3 by ortuno@chromium.org, Jun 14 2017

Labels: -Sheriff-Chromium

Comment 4 by raymes@chromium.org, Jun 14 2017

Sorry jialiul@ I had a look but I'm not sure what the problem is. It looks like memory corruption of some kind that may not be consistently reproducible. My best guess that the Dictionary is somehow being deleted. It may have something to do with the way we're manipulating the unique_ptrs but I couldn't see anything specifically wrong.

Comment 5 by vakh@chromium.org, Jun 16 2017

Labels: SafeBrowsing-Triaged
Status: Fixed (was: Assigned)

Sign in to add a comment