New issue
Advanced search Search tips

Issue 733056 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bring the trace diffing tool to catapult

Project Member Reported by etienneb@chromium.org, Jun 14 2017

Issue description

We implemented a trace diff script that is performing a memory dump diff and reporting the potential memory leaks.

This tool should be added to the 'contrib' folder in cataput.
It is currently blocked by a CL changing the trace format.
 
Status: Assigned (was: Untriaged)
missing features:
  * options parsing
  * creating output directory
  * UI enhancement in the web view (flame graph)
  * Adding more information: size / types / components / line of code
  * Performing diff with different PIDs
  * Automatically call the symbolisation when needed.
missing feature
  * Instead of a diff, a view of all allocated objects
Cc: fmea...@chromium.org
fmeawad proposed to use a viewer instead of running a webserver for the flame-graph.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4aa831fb4a764cbfa2c58c318849c8a967d7735

commit d4aa831fb4a764cbfa2c58c318849c8a967d7735
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Jun 28 21:48:11 2017

Roll src/third_party/catapult/ 8114d33c7..9d1bd9e64 (4 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8114d33c7d55..9d1bd9e6442b

$ git log 8114d33c7..9d1bd9e64 --date=short --no-merges --format='%ad %ae %s'
2017-06-28 etienneb Fix coding style issue with diff_heap_profiler script
2017-06-28 erikchen symbolize_trace: Always symbolize all symbols by default.
2017-06-28 erikchen Increase flush timeout for fetching and compressing a memory dump.
2017-06-28 etienneb Add traces diffing tool for memory dumps between chrome traces

Created with:
  roll-dep src/third_party/catapult
BUG= 733056 , 737658 ,726393, 733056 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I918fd6b10c13bd20a170680c102ff30de6beebf6
Reviewed-on: https://chromium-review.googlesource.com/552873
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483151}
[modify] https://crrev.com/d4aa831fb4a764cbfa2c58c318849c8a967d7735/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec58a2d0b9e1ab222b4490cf0cf31f63b721cd3e

commit ec58a2d0b9e1ab222b4490cf0cf31f63b721cd3e
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Jun 29 23:24:13 2017

Roll src/third_party/catapult/ ee25754a9..94654a44c (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ee25754a916e..94654a44cb89

$ git log ee25754a9..94654a44c --date=short --no-merges --format='%ad %ae %s'
2017-06-29 etienneb Fix incorrect memory dump indexes update

Created with:
  roll-dep src/third_party/catapult
BUG= 733056 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id2395b8c930160e716db20a464b8224dd978a699
Reviewed-on: https://chromium-review.googlesource.com/557000
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483543}
[modify] https://crrev.com/ec58a2d0b9e1ab222b4490cf0cf31f63b721cd3e/DEPS

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfbde222c87f52f3fe87ed0f53962922376267a1

commit dfbde222c87f52f3fe87ed0f53962922376267a1
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Sep 09 00:13:14 2017

Roll src/third_party/catapult/ cd2d1cccb..7a80ad340 (5 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cd2d1cccba76..7a80ad3406d1

$ git log cd2d1cccb..7a80ad340 --date=short --no-merges --format='%ad %ae %s'
2017-09-08 benjhayden Dashboard charts: display sparklines of related timeseries in a tab strip.
2017-09-08 etienneb Add support for opening uncompressed traces
2017-09-08 dtu [pinpoint] Show status for every Execution.
2017-09-08 johnchen Port a media metric to TBMv2
2017-09-08 eakuefner Revert of Plumb trace canonicalUrl through TelemetryInfo. (patchset #6 id:160001 of https://chromiumcodereview.appspot.com/3007063002/ )

Created with:
  roll-dep src/third_party/catapult
BUG= 733056 , 700160 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I2ccf4499cb84911b324307d1263cf82aa6b082d4
Reviewed-on: https://chromium-review.googlesource.com/657243
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500751}
[modify] https://crrev.com/dfbde222c87f52f3fe87ed0f53962922376267a1/DEPS

Sign in to add a comment