New issue
Advanced search Search tips

Issue 733040 link

Starred by 1 user
Status: Assigned
Owner:
bsep@chromium.org
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Collapse "dialog" and "bubble" layouts

Project Member Reported by bsep@chromium.org, Jun 14 2017 
Right now "dialogs" (subclasses of DialogDelegateView, which are modal popups) and "bubbles" (subclasses of BubbleDialogDelegateView, which are non-modal popups) have different layouts in ways that aren't related to their modalness. In particular:
* Dialogs are draggable
* Dialogs have slightly larger margins around their edges, and between their buttons and content
* Dialogs consider the buttons to be outside their content, whereas bubbles consider them to be inside
* Dialogs do not have a default margin around their content

We should remove these distinctions.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ef329f8cf6cdc5cb663fa704dd66580c2f538b

commit 70ef329f8cf6cdc5cb663fa704dd66580c2f538b
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Aug 11 01:17:08 2017

DialogClientView handles dialog content margins.

Previously DialogDelegateView subclasses had to specify their own
content margins, and BubbleDialogDelegateView subclasses would set
their margins on BubbleFrameView. With this patch, they now work the
same way: DialogClientView insets the content bounds.

However, DialogDelegateView specifies a margin of 0 for now. Giving
its subclasses a default margin has been deferred to a future patch.

This patch also removes the bubble-specific layout metrics (changing
all metrics pre-Harmony to 13 dips) and collapses the dialog layout
metrics to these three:
* INSETS_DIALOG: The margins around the edge of the dialog.
* DISTANCE_DIALOG_TITLE_CONTENT_MARGIN: The margins between the title
  and the content.
* DISTANCE_DIALOG_BUTTON_CONTENT_MARGIN: The margins between the button
  row and the content.

Metrics that are redundant with those have been removed, and
INSETS_DIALOG_* metrics are now defined in terms of those three.

Bug: 733040
Change-Id: I054654e6cf6e4e7602972216f2b1f76513135aa2
Reviewed-on: https://chromium-review.googlesource.com/607398
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493630}
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/bubble/bubble_dialog_delegate.h
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/bubble/bubble_frame_view.h
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/layout/layout_provider.h
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/window/dialog_client_view.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/window/dialog_delegate.cc
[modify] https://crrev.com/70ef329f8cf6cdc5cb663fa704dd66580c2f538b/ui/views/window/dialog_delegate.h
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6194b55c9e4bdc9268245ef62e8816161d96122

commit f6194b55c9e4bdc9268245ef62e8816161d96122
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Aug 25 23:06:04 2017

Delete GridLayout::CreatePanel.

Subclasses of DialogDelegate now call set_margin. Other usages
explicitly set a border on themselves. This decouples GridLayout
creation and actual layout declaration.

Also made GridLayout call SetLayoutManager on the host when
constructed, since we never want to not call it.

Bug: 733040
Change-Id: I4272d5a78f5b0b78ce15bb6b75867d44a879d7c8
Reviewed-on: https://chromium-review.googlesource.com/627096
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497584}
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ash/system/date/date_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/enrollment_dialog_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/options/vpn_config_view.h
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/chromeos/ui/request_pin_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/certificate_selector.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/confirm_bubble_views.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/crypto_module_password_dialog_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/first_run_bubble.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/first_run_dialog.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/hung_renderer_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/intent_picker_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/login_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/page_info/chosen_object_row.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/passwords/credentials_selection_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/passwords/manage_password_items_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/profiles/forced_reauthentication_dialog_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/try_chrome_dialog.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/content/shell/browser/shell_views.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/mash/catalog_viewer/catalog_viewer.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/app_list/views/suggestions_container_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/message_center/views/notifier_settings_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/controls/message_box_view.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/button_sticker_sheet.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/dialog_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/examples_window.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/label_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/message_box_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/multiline_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/progress_bar_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/radio_button_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/scroll_view_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/tabbed_pane_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/table_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/text_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/textfield_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/examples/tree_view_example.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/layout/grid_layout.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/layout/grid_layout.h
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/layout/grid_layout_unittest.cc
[modify] https://crrev.com/f6194b55c9e4bdc9268245ef62e8816161d96122/ui/views/window/dialog_client_view.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e2f764f37025fdd52da2bd63032d5f55afea0c

commit 64e2f764f37025fdd52da2bd63032d5f55afea0c
Author: Henrik Andreasson <henrika@chromium.org>
Date: Mon Aug 28 09:00:07 2017

Reverted by Chrome sheriff. Seems to break OneClickSigninDialogViewTest.

See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20CFI/builds/1395/steps/unit_tests

Revert "Delete GridLayout::CreatePanel."

This reverts commit f6194b55c9e4bdc9268245ef62e8816161d96122.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Delete GridLayout::CreatePanel.
> 
> Subclasses of DialogDelegate now call set_margin. Other usages
> explicitly set a border on themselves. This decouples GridLayout
> creation and actual layout declaration.
> 
> Also made GridLayout call SetLayoutManager on the host when
> constructed, since we never want to not call it.
> 
> Bug: 733040
> Change-Id: I4272d5a78f5b0b78ce15bb6b75867d44a879d7c8
> Reviewed-on: https://chromium-review.googlesource.com/627096
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497584}

NOTRY=TRUE
TBR=xiyuan@chromium.org,dgozman@chromium.org,sky@chromium.org,bsep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 733040
Change-Id: Icf677a1de200d7b1fe3b51b480fb5b547a431c90
Reviewed-on: https://chromium-review.googlesource.com/636244
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497720}
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ash/system/date/date_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/enrollment_dialog_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/options/vpn_config_view.h
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/chromeos/ui/request_pin_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/certificate_selector.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/confirm_bubble_views.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/crypto_module_password_dialog_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/first_run_bubble.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/first_run_dialog.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/hung_renderer_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/intent_picker_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/login_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/page_info/chosen_object_row.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/passwords/credentials_selection_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/passwords/manage_password_items_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/profiles/forced_reauthentication_dialog_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/try_chrome_dialog.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/content/shell/browser/shell_views.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/mash/catalog_viewer/catalog_viewer.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/app_list/views/suggestions_container_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/message_center/views/notifier_settings_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/controls/message_box_view.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/button_sticker_sheet.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/dialog_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/examples_window.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/label_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/message_box_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/multiline_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/progress_bar_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/radio_button_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/scroll_view_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/tabbed_pane_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/table_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/text_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/textfield_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/examples/tree_view_example.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/layout/grid_layout.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/layout/grid_layout.h
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/layout/grid_layout_unittest.cc
[modify] https://crrev.com/64e2f764f37025fdd52da2bd63032d5f55afea0c/ui/views/window/dialog_client_view.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01402a48c7112dee07d962c5c1f79759754fbda2

commit 01402a48c7112dee07d962c5c1f79759754fbda2
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Sep 01 02:39:46 2017

Delete GridLayout::CreatePanel.

Reland of chromium-review.googlesource.com/c/chromium/src/+/627096

Subclasses of DialogDelegate now call set_margin. Other usages
explicitly set a border on themselves. This decouples GridLayout
creation and actual layout declaration.

Also made GridLayout call SetLayoutManager on the host when
constructed, since we never want to not call it.

TBR=sky@chromium.org,xiyuan@chromium.org,dgozman@chromium.org

Bug: 733040
Change-Id: I837800b914218c8677e0b3550d41632218e9b041
Reviewed-on: https://chromium-review.googlesource.com/647030
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499115}
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ash/system/date/date_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/enrollment_dialog_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/options/vpn_config_view.h
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/chromeos/ui/request_pin_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/certificate_selector.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/confirm_bubble_views.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/confirm_bubble_views_unittest.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/crypto_module_password_dialog_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/first_run_bubble.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/first_run_dialog.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/hung_renderer_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/intent_picker_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/login_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/page_info/chosen_object_row.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/passwords/credentials_selection_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/passwords/manage_password_items_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/editor_view_controller.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/payment_request_dialog_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/profiles/forced_reauthentication_dialog_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/proximity_auth/proximity_auth_error_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/sync/one_click_signin_dialog_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/translate/translate_bubble_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/try_chrome_dialog.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/chrome/browser/ui/views/uninstall_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/content/shell/browser/shell_views.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/mash/catalog_viewer/catalog_viewer.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/app_list/views/suggestions_container_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/message_center/views/notifier_settings_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/color_chooser/color_chooser_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/controls/message_box_view.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/button_sticker_sheet.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/dialog_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/examples_window.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/label_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/message_box_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/multiline_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/progress_bar_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/radio_button_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/scroll_view_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/tabbed_pane_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/table_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/text_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/textfield_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/examples/tree_view_example.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/layout/grid_layout.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/layout/grid_layout.h
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/layout/grid_layout_unittest.cc
[modify] https://crrev.com/01402a48c7112dee07d962c5c1f79759754fbda2/ui/views/window/dialog_client_view.cc

Comment 5 by nyerramilli@chromium.org, Nov 22

Labels: Hotlist-DesktopUIValid Hotlist-DesktopUIChecked
**UI Mass triage**

adding labels for expert review.
►

Sign in to add a comment